Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4245] Fix start eventmesh failed. #4246

Closed
wants to merge 28 commits into from
Closed

[ISSUE #4245] Fix start eventmesh failed. #4246

wants to merge 28 commits into from

Conversation

Alonexc
Copy link
Contributor

@Alonexc Alonexc commented Jul 18, 2023

Fixes #4245 .

Motivation

fix start failed.

Modifications

fix start failed.

Documentation

  • Does this pull request introduce a new feature? no

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xwm1992
xwm1992 previously approved these changes Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4246 (16fde26) into master (cc43dee) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 16fde26 differs from pull request most recent head 8df9311. Consider uploading reports for the commit 8df9311 to get more accurate results

@@             Coverage Diff              @@
##             master    #4246      +/-   ##
============================================
+ Coverage     16.77%   16.78%   +0.01%     
- Complexity     1415     1416       +1     
============================================
  Files           592      592              
  Lines         26040    26033       -7     
  Branches       2400     2398       -2     
============================================
+ Hits           4367     4369       +2     
+ Misses        21235    21227       -8     
+ Partials        438      437       -1     
Impacted Files Coverage Δ
...esh/registry/consul/service/HeatBeatScheduler.java 0.00% <0.00%> (ø)
...he/eventmesh/runtime/boot/EventMeshHTTPServer.java 0.52% <0.00%> (ø)
...re/protocol/grpc/processor/HeartbeatProcessor.java 0.00% <0.00%> (ø)
...ntime/core/protocol/grpc/service/ServiceUtils.java 0.00% <0.00%> (ø)
...ocol/http/processor/BatchSendMessageProcessor.java 0.00% <0.00%> (ø)
.../protocol/http/processor/CreateTopicProcessor.java 0.00% <0.00%> (ø)
.../protocol/http/processor/DeleteTopicProcessor.java 0.00% <0.00%> (ø)
...col/http/processor/QuerySubscriptionProcessor.java 0.00% <0.00%> (ø)
...e/core/protocol/http/producer/ProducerManager.java 0.00% <0.00%> (ø)
.../apache/eventmesh/client/tcp/common/TcpClient.java 15.30% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992
Copy link
Contributor

xwm1992 commented Jul 20, 2023

This pull request‘s commits log seems not right, please fix it. @Alonexc

@Alonexc Alonexc closed this by deleting the head repository Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Startup failed due to NullPointerException.
4 participants