Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES #3482]Replace this call to "replaceAll()" by a call to the "replace()" method.[ProducerImpl] #3631

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

harshithasudhakar
Copy link
Member

Fixes #3482

Motivation

When String::replaceAll is used, the first argument should be a real regular expression. If it’s not the case, String::replace does exactly the same thing as String::replaceAll without the performance drawback of the regex.

Modifications

Replaced "replaceAll()" to "replace()"

Documentation

  • Does this pull request introduce a new feature? (yes / no)
    No

Replaced "replaceAll()" to "replace()"
Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 changed the title [ISSUES#3482]Replace this call to "replaceAll()" by a call to the "replace()" method.[ProducerImpl] [ISSUES #3482]Replace this call to "replaceAll()" by a call to the "replace()" method.[ProducerImpl] Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #3631 (bf6992c) into master (4eb819f) will not change coverage.
The diff coverage is 50.00%.

❗ Current head bf6992c differs from pull request most recent head dba92da. Consider uploading reports for the commit dba92da to get more accurate results

@@            Coverage Diff            @@
##             master    #3631   +/-   ##
=========================================
  Coverage     13.76%   13.76%           
  Complexity     1291     1291           
=========================================
  Files           571      571           
  Lines         29239    29239           
  Branches       2885     2885           
=========================================
  Hits           4024     4024           
  Misses        24841    24841           
  Partials        374      374           
Impacted Files Coverage Δ
...ntmesh/storage/rocketmq/producer/ProducerImpl.java 21.64% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit c10796c into apache:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Replace this call to "replaceAll()" by a call to the "replace()" method.[ProducerImpl]
3 participants