[ISSUE #3323] Unsubscribe from a single topic #3324
Conversation
… into fix-3323 � Conflicts: � eventmesh-connector-plugin/eventmesh-connector-pulsar/src/main/java/org/apache/eventmesh/connector/pulsar/consumer/PulsarConsumerImpl.java
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
============================================
- Coverage 13.09% 13.03% -0.07%
- Complexity 1159 1191 +32
============================================
Files 550 551 +1
Lines 28718 28728 +10
Branches 2854 2851 -3
============================================
- Hits 3761 3744 -17
- Misses 24632 24659 +27
Partials 325 325
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -17,15 +17,15 @@ | |||
| ###############################EVNETMESH-runtime ENV################################# | |||
| eventMesh.server.idc=DEFAULT | |||
| eventMesh.server.env=PRD | |||
| eventMesh.server.provide.protocols=HTTP,TCP,GRPC | |||
| eventMesh.server.provide.protocols=HTTP,TCP | |||
There was a problem hiding this comment.
Used during testing, can be ignored
| eventMesh.server.cluster=COMMON | ||
| eventMesh.server.name=EVENTMESH-runtime | ||
| eventMesh.sysid=0000 | ||
| eventMesh.server.http.port=10105 | ||
| eventMesh.server.grpc.port=10205 | ||
| ########################## eventMesh tcp configuration ############################ | ||
| eventMesh.server.tcp.enabled=true | ||
| eventMesh.server.tcp.port=10002 | ||
| eventMesh.server.tcp.port=10102 | ||
| eventMesh.server.tcp.readerIdleSeconds=120 |
There was a problem hiding this comment.
Used during testing, can be ignored
| Assert.assertEquals(config.getAuthParams(), "authParams-success!!!"); | ||
| Assert.assertEquals(config.getServiceAddr(), null); | ||
| Assert.assertEquals(config.getAuthPlugin(), null); | ||
| Assert.assertEquals(config.getAuthParams(), null); | ||
| } |
There was a problem hiding this comment.
This modification makes the testcase meaningless. You can try to locate the root cause and then fix.
Alternatively, you can refactor the relevant test cases.
There was a problem hiding this comment.
ok,I will repair it as soon as possible
| @@ -36,4 +36,7 @@ public class ClientConfiguration { | |||
|
|
|||
| @ConfigFiled(field = "authParams") | |||
| private String authParams; | |||
|
|
|||
| @ConfigFiled(field = "topicPrefix") | |||
| private String topicPrefix; | |||
| } | |||
There was a problem hiding this comment.
It may be better to add some descriptive information, such as application scenarios.
There was a problem hiding this comment.
Because the full format of topic needs a prefix, but the prefix cannot be passed in the url when the topic is carried
Motivation
Manage subscribed topics uniformly. When unsubscribing, you can unsubscribe a single topic
Issue #3323
Modifications
Add consumermap to manage all the consumer of pulsar. The consumer has topic information. When adding a subscription, add the consumer into the consumermap. When canceling the subscription, delete the corresponding consumer from it
Documentation