Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2675] [Enhancement] Method appears to call the same method on the same object redundantly [SubscribeProcessor] #2701

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

ayushsinghal90
Copy link
Contributor

Fixes #2675.

Motivation

  • Redundant function call in eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SubscribeProcessor.java lines 82 and 91.

Modifications

  • Method call combined with a local variable.

Documentation

  • Does this pull request introduces a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Apache EventMesh (incubating) community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!

Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!

Want to get closer to the community?

WeChat Group:
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #2701 (929a904) into master (7502437) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 929a904 differs from pull request most recent head da05232. Consider uploading reports for the commit da05232 to get more accurate results

@@            Coverage Diff            @@
##             master    #2701   +/-   ##
=========================================
  Coverage     11.90%   11.90%           
  Complexity      905      905           
=========================================
  Files           476      476           
  Lines         27100    27100           
  Branches       2764     2764           
=========================================
  Hits           3227     3227           
  Misses        23586    23586           
  Partials        287      287           
Impacted Files Coverage Δ
...re/protocol/http/processor/SubscribeProcessor.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonyangx jonyangx merged commit efef5a3 into apache:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Method appears to call the same method on the same object redundantly [SubscribeProcessor]
2 participants