Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Comparison using reference equality instead of value equality.[Heartbeat] #4029

Closed
1 of 2 tasks
Alonexc opened this issue May 25, 2023 · 0 comments · Fixed by #4037
Closed
1 of 2 tasks

[Enhancement] Comparison using reference equality instead of value equality.[Heartbeat] #4029

Alonexc opened this issue May 25, 2023 · 0 comments · Fixed by #4037
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented May 25, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
image
located at:
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/grpc/protos/Heartbeat.java line 554,675,1181,1336
analysis and explanation:
Reference types that declare an equals() method, or that inherit equals() from a type other than Object, should not be compared for reference equality with == or !=. Instead, always compare for value equality with .equals().

Describe the solution you'd like

change to use equals() to compare.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label May 25, 2023
@Alonexc Alonexc mentioned this issue May 25, 2023
Open
@nitheesh-daram nitheesh-daram mentioned this issue May 27, 2023
Merged
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label May 29, 2023
wqliang added a commit that referenced this issue May 30, 2023
@wqliang
Merge pull request #4037 from nitheesh-daram/ISSUE-4029
a6a2793 
[ISSUE #4029 ] Comparison using reference equality instead of value equality.[Heartbeat]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4029 ] Comparison using reference equality instead of value equality.[Heartbeat]
2 participants
@xwm1992 @Alonexc