Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] RequestMapping, UrlMappingPattern can apply some optimizing #3918

Closed
2 tasks done
pandaapo opened this issue May 13, 2023 · 0 comments · Fixed by #3919
Closed
2 tasks done

[Enhancement] RequestMapping, UrlMappingPattern can apply some optimizing #3918

pandaapo opened this issue May 13, 2023 · 0 comments · Fixed by #3919
Labels
enhancement New feature or request

Comments

@pandaapo
Copy link
Member

pandaapo commented May 13, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

org.apache.eventmesh.admin.rocketmq.util.RequestMapping :

This class has redundant code.

org.apache.eventmesh.admin.rocketmq.util.UrlMappingPattern :

The private method getUrlMappingPattern() only return a field value.

The private method setUrlMappingPattern(String pattern) only assign a value to a field.

The class has no parent class except Object, so super() is no needed.

Describe the solution you'd like

org.apache.eventmesh.admin.rocketmq.util.RequestMapping:

Resolve the redundant code.

org.apache.eventmesh.admin.rocketmq.util.UrlMappingPattern :

Do some simplifying.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@pandaapo pandaapo added the enhancement New feature or request label May 13, 2023
@pandaapo pandaapo changed the title [Enhancement] RequestMapping has redundant code [Enhancement] RequestMapping, UrlMappingPattern can apply some optimizing May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant