Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Do some code optimization.[ZookeeperMetaService] #3833

Closed
1 of 2 tasks
Alonexc opened this issue Apr 27, 2023 · 2 comments · Fixed by #4780
Closed
1 of 2 tasks

[Enhancement] Do some code optimization.[ZookeeperMetaService] #3833

Alonexc opened this issue Apr 27, 2023 · 2 comments · Fixed by #4780
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Apr 27, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
image
located at:
eventmesh-registry-plugin/eventmesh-registry-zookeeper/src/main/java/org/apache/eventmesh/registry/zookeeper/service/ZookeeperRegistryService.java line 71,202-223,251-272.

Describe the solution you'd like

a. Change to private modifier.
b. Repeat code extraction as method.
image
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Apr 27, 2023
@pandaapo pandaapo changed the title [Enhancement] Do some code optimization.[ZookeeperRegistryService] [Enhancement] Do some code optimization.[ZookeeperMetaService] Nov 22, 2023
@Pil0tXia Pil0tXia added the good first issue Issues for first-time contributors label Jan 19, 2024
@Ish1yu
Copy link
Contributor

Ish1yu commented Feb 27, 2024

Hello, I am a beginner in eventmesh. Upon seeing the problem described in this issue, I wonder if eventmesh has already been refactored. I couldn't find the location of eventmesh-registry-zookeeper, but I found one located in eventmesh metaeventmesh-meta\eventmesh-meta-zookeeper\src\main\java\org\apache\eventmesh\meta\zookeeper\service\ZookeeperMetaService. Do I need to modify it here?

Meanwhile, regarding the document "Quick Start", I think the description of meta (Registry Meta Service) is too simple. I only understood it based on the code. Can I try to improve the Chinese description of Quick Start in the document?(https://eventmesh.apache.org/zh/docs/instruction/runtime)

@Alonexc
Copy link
Contributor Author

Alonexc commented Feb 27, 2024

Yes, the location may have changed due to updates to the code module, this looks unfinished, welcome to the eventmesh community.

mxsm pushed a commit that referenced this issue Feb 27, 2024
a. Change to private modifier.
b. Repeat code extraction as method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants