Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: fix typo #3491

Merged
merged 1 commit into from
Feb 17, 2019
Merged

[Enhancement]: fix typo #3491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dubbo-common/src/main/java/org/apache/dubbo/common/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ public class Constants {

public static final String PROTOCOL_KEY = "protocol";

public static final String DOBBO_PROTOCOL = DUBBO;
public static final String DUBBO_PROTOCOL = DUBBO;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍


public static final String ZOOKEEPER_PROTOCOL = "zookeeper";

Expand Down
4 changes: 2 additions & 2 deletions ...onfig/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,12 +350,12 @@ protected URL loadMonitor(URL registryURL) {
if (getExtensionLoader(MonitorFactory.class).hasExtension("logstat")) {
map.put(Constants.PROTOCOL_KEY, "logstat");
} else {
map.put(Constants.PROTOCOL_KEY, Constants.DOBBO_PROTOCOL);
map.put(Constants.PROTOCOL_KEY, Constants.DUBBO_PROTOCOL);
}
}
return UrlUtils.parseURL(address, map);
} else if (Constants.REGISTRY_PROTOCOL.equals(monitor.getProtocol()) && registryURL != null) {
return registryURL.setProtocol(Constants.DOBBO_PROTOCOL).addParameter(Constants.PROTOCOL_KEY, Constants.REGISTRY_PROTOCOL).addParameterAndEncoded(Constants.REFER_KEY, StringUtils.toQueryString(map));
return registryURL.setProtocol(Constants.DUBBO_PROTOCOL).addParameter(Constants.PROTOCOL_KEY, Constants.REGISTRY_PROTOCOL).addParameterAndEncoded(Constants.REFER_KEY, StringUtils.toQueryString(map));
}
return null;
}
Expand Down
8 changes: 4 additions & 4 deletions dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ProtocolConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ public String getCodec() {
}

public void setCodec(String codec) {
if (Constants.DOBBO_PROTOCOL.equals(name)) {
if (Constants.DUBBO_PROTOCOL.equals(name)) {
checkMultiExtension(Codec.class, Constants.CODEC_KEY, codec);
}
this.codec = codec;
Expand All @@ -328,7 +328,7 @@ public String getSerialization() {
}

public void setSerialization(String serialization) {
if (Constants.DOBBO_PROTOCOL.equals(name)) {
if (Constants.DUBBO_PROTOCOL.equals(name)) {
checkMultiExtension(Serialization.class, Constants.SERIALIZATION_KEY, serialization);
}
this.serialization = serialization;
Expand Down Expand Up @@ -371,7 +371,7 @@ public String getServer() {
}

public void setServer(String server) {
if (Constants.DOBBO_PROTOCOL.equals(name)) {
if (Constants.DUBBO_PROTOCOL.equals(name)) {
checkMultiExtension(Transporter.class, Constants.SERVER_KEY, server);
}
this.server = server;
Expand All @@ -382,7 +382,7 @@ public String getClient() {
}

public void setClient(String client) {
if (Constants.DOBBO_PROTOCOL.equals(name)) {
if (Constants.DUBBO_PROTOCOL.equals(name)) {
checkMultiExtension(Transporter.class, Constants.CLIENT_KEY, client);
}
this.client = client;
Expand Down