[Dubbo-1485] Remove deprecated AnnotationBean. #2676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w method to replace.
beiwei30
requested changes
Oct 30, 2018
dubbo-config/dubbo-config-spring/src/main/resources/META-INF/compat/dubbo.xsd
Show resolved
Hide resolved
1. add ConfigManager 2. Reference/Service hold reference of ConfigCenterConfig 3. change from-spring to include-spring-env
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractInterfaceConfig.java # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java # dubbo-demo/dubbo-demo-api/dubbo-demo-api-provider/src/main/java/org/apache/dubbo/demo/provider/DemoServiceImpl.java
…Config and remove RegistryDataConfig (apache#3129)
…ties format 'dubbo.metadata-report.address=XXx' (apache#3138) * fix apache#3124 . move RegistryDataConfig configuration into RegistryConfig and remove RegistryDataConfig * fix apache#3123. support metadata xml configuration; support configuration format dubbo.metadata-report.address=xxx
…hypher case instead of camel case.
…void dup refresh for registry config. * avoid dup refresh for registry config * fix unit test * fix unit test, org.apache.dubbo.config.AbstractInterfaceConfig#convertRegistryIdsToRegistries generates invalid registry config * should not give RegistryConfig a default value 'RegistryConfig.NO_AVAILABLE'
remove checkApplication for it is invoked before.
* ../routers/condition * ../routers/tag * ../routers/otherRouter
* modify metadata node path in zookeeper * add licence
/router/condition -> router-codition
* give router rule a more layered extensiable ZK path: * ../routers/condition * ../routers/tag * ../routers/otherRouter * Fix UT * Adjust ZK to handle layered routers path * Remove BlackWhiteListRule * Adjust code to avoid possible ConcurrentModificationException * revert router from layered path to flat path: /router/condition -> router-codition * adjust router path in UT * change suffix literal: router-condition to condition-router * change suffix literal: router-condition to condition-router
… not completed yet. (apache#3185) * Announce AsyncRpcResult internally use only; Check future status before get(). * Code review: simplify code
* fix prefix * Missing '@OverRide' annotation
* Provider async enhancement, user doesn't have to use 'async=true' on provider side. * only keep zero-args constructor * stop router tag from being transferred in the RPC chain * Code review: use 'this.future= new Future()''; remove setAsyncContext() from RpcContext * revert getInternalFuture() * Fix UT
…e as well as on impl.
… zooke… (apache#3182) * fix apache#3179. Make registry, configcenter, matadata-report share a zookeeper connection * fix apache#3179. optimize registry, configcenter, matadata-report share a zookeeper connection * fix apache#3179. add licence * fix some review issue: just optimize constuctor order and refactor some code * modify HashMap to ConcurrentHashMap * add some comments * remove ZookeeperClientData and originalURLs * remove ZookeeperClientData and originalURLs * fix apache#3205 . add group into MetadataReport * remove SOURCE_URL_KEY from Constants * fix apache#3179 , apache#3205, apache#3218. modify review issue; when sharing zookeeper connection, it should judge zookeeperClient.isConnected()
# Conflicts: # dubbo-compatible/src/main/java/org/apache/dubbo/config/spring/schema/CompatibleAnnotationBeanDefinitionParser.java # dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/AnnotationBean.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated AnnotationBean, please refer #1485 for the new configuration method to replace.
What is the purpose of the change
AnnotationBean was found to have some problems and has been replaced and marked deprecated since version 2.5.7.
Brief changelog
AnnotationBean.javaVerifying this change
Check dubbo-spring-boot-project for how the new way to use.
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.