Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #10839, #11082 and #11086 #11160

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Revert #10839, #11082 and #11086 #11160

merged 1 commit into from
Dec 16, 2022

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Fix #11159

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11160 (462bcaa) into 3.1 (b1ae0de) will decrease coverage by 4.88%.
The diff coverage is 86.36%.

@@             Coverage Diff              @@
##                3.1   #11160      +/-   ##
============================================
- Coverage     69.48%   64.59%   -4.89%     
+ Complexity      112       14      -98     
============================================
  Files          1496     1421      -75     
  Lines         79473    59304   -20169     
  Branches      14076     8720    -5356     
============================================
- Hits          55218    38310   -16908     
+ Misses        19485    16953    -2532     
+ Partials       4770     4041     -729     
Impacted Files Coverage Δ
...he/dubbo/common/config/CompositeConfiguration.java 67.85% <ø> (ø)
.../dubbo/common/config/EnvironmentConfiguration.java 100.00% <ø> (+26.66%) ⬆️
...che/dubbo/common/config/InmemoryConfiguration.java 94.73% <ø> (+1.63%) ⬆️
.../common/config/OrderedPropertiesConfiguration.java 80.76% <ø> (+12.19%) ⬆️
...che/dubbo/common/config/PrefixedConfiguration.java 60.00% <ø> (+10.00%) ⬆️
...e/dubbo/common/config/PropertiesConfiguration.java 100.00% <ø> (ø)
...fig/configcenter/AbstractDynamicConfiguration.java 84.48% <ø> (+0.16%) ⬆️
...nfig/configcenter/nop/NopDynamicConfiguration.java 25.00% <ø> (+8.33%) ⬆️
...gcenter/wrapper/CompositeDynamicConfiguration.java 69.23% <ø> (-3.08%) ⬇️
...bbo/config/context/ConfigConfigurationAdapter.java 71.42% <ø> (+21.42%) ⬆️
... and 512 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 705b327 into apache:3.1 Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.1] Configurations cannot be loaded correctly unless set in SystemProperty
3 participants