Fix npe when package is null. (#3557)

apache · Feb 26, 2019 · 5434ab7 · 5434ab7
1 parent ade0cd7
commit 5434ab7
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
@@ -144,14 +144,18 @@ private static String getPrefixDigits(String v) {
     public static String getVersion(Class<?> cls, String defaultVersion) {
         try {
             // find version info from MANIFEST.MF first
-            String version = cls.getPackage().getImplementationVersion();
-            if (!StringUtils.isEmpty(version)) {
-                return version;
-            }
-
-            version = cls.getPackage().getSpecificationVersion();
-            if (!StringUtils.isEmpty(version)) {
-                return version;
+            Package pkg = cls.getPackage();
+            String version = null;
+            if (pkg != null) {
+                version = pkg.getImplementationVersion();
+                if (!StringUtils.isEmpty(version)) {
+                    return version;
+                }
+
+                version = pkg.getSpecificationVersion();
+                if (!StringUtils.isEmpty(version)) {
+                    return version;
+                }
             }
 
             // guess version fro jar file name if nothing's found from MANIFEST.MF