Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][routine-load] fix bug that routine load cannot cancel task when append_data return error #8457

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

caiconghui
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiconghui caiconghui changed the title [fix][routine-load] fix bug for race condition problem when routine_load task change result_status [fix][routine-load] fix bug that routine load cannot cancel task when append_data return error Mar 13, 2022
@caiconghui caiconghui added the kind/fix Categorizes issue or PR as related to a bug. label Mar 13, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 13, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman added the dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 label Mar 13, 2022
@caiconghui caiconghui merged commit 991dc7f into apache:master Mar 14, 2022
@morningman morningman added dev/backlog waiting to be merged in future dev branch and removed dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 labels Mar 14, 2022
morningman pushed a commit that referenced this pull request Mar 14, 2022
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/backlog waiting to be merged in future dev branch labels Mar 14, 2022
zhengte pushed a commit to zhengte/incubator-doris that referenced this pull request Mar 15, 2022
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Mar 16, 2022
Henry2SS added a commit to Henry2SS/incubator-doris that referenced this pull request Mar 16, 2022
[fix][routine-load] fix bug that routine load cannot cancel task when append_data return error (apache#8457)
@caiconghui caiconghui deleted the routine_load_bug branch August 3, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/fix Categorizes issue or PR as related to a bug. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants