[Feature] Support for storage layer benchmark #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trans benchmark_tool to unit test fix eof remove unused code and file add SegmentWrite&& support multi benchmark test add PageEncodeBenchmark remove time count at first turn run && move some util fuction to test_util&& add benchmark name display add MultiBenchmark to manage benchmarks add SegmentWriteByFileBenchmark add SegmentScanByFileBenchmark add ignore case compare add benchmark include build promote usage
yangzhg
reviewed
Aug 26, 2021
|
|
||
| auto* dest_slice = (Slice*)target; | ||
| dest_slice->size = src_len; | ||
| dest_slice->data = (char*)pool->allocate(src_len); |
yangzhg
reviewed
Aug 26, 2021
be/test/olap/tablet_schema_helper.h
Outdated
| void set_column_value_by_type(FieldType fieldType, std::string src, char* target, MemPool* pool, | ||
| size_t _length = 0) { | ||
| if (fieldType == OLAP_FIELD_TYPE_CHAR) { | ||
| char* src_value = &src[0]; |
There was a problem hiding this comment.
use src.data() or use src.copy() at line 135
yangzhg
reviewed
Aug 26, 2021
be/test/olap/tablet_schema_helper.h
Outdated
| @@ -123,4 +123,28 @@ void set_column_value_by_type(FieldType fieldType, int src, char* target, MemPoo | |||
| } | |||
| } | |||
|
|
|||
| void set_column_value_by_type(FieldType fieldType, std::string src, char* target, MemPool* pool, | |||
There was a problem hiding this comment.
Suggested change
| void set_column_value_by_type(FieldType fieldType, std::string src, char* target, MemPool* pool, | |
| void set_column_value_by_type(FieldType fieldType, const std::string& src, char* target, MemPool* pool, |
yangzhg
reviewed
Aug 26, 2021
be/test/test_util/test_util.cpp
Outdated
| @@ -74,4 +73,42 @@ void InitConfig() { | |||
| } | |||
| } | |||
|
|
|||
| std::vector<std::string> split_str(const std::string& str, char separation) { | |||
yangzhg
reviewed
Aug 26, 2021
thirdparty/build-thirdparty.sh
Outdated
| sed -i '160 i \ \ add_cxx_compiler_flag(-lrt)' ./CMakeLists.txt | ||
|
|
||
| cmake -E make_directory "build" | ||
| cmake -E chdir "build" cmake -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on -DCMAKE_BUILD_TYPE=Release ../ |
There was a problem hiding this comment.
Suggested change
| cmake -E chdir "build" cmake -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on -DCMAKE_BUILD_TYPE=Release ../ | |
| CXXFLAGS="-lresolv -pthread -lrt" cmake -E chdir "build" cmake -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on -DCMAKE_BUILD_TYPE=Release ../ |
yangzhg
reviewed
Aug 26, 2021
thirdparty/build-thirdparty.sh
Outdated
|
|
||
| sed -i '160 i \ \ add_cxx_compiler_flag(-lresolv)' ./CMakeLists.txt | ||
| sed -i '160 i \ \ add_cxx_compiler_flag(-pthread)' ./CMakeLists.txt | ||
| sed -i '160 i \ \ add_cxx_compiler_flag(-lrt)' ./CMakeLists.txt |
|
@yangzhg I do some change to fix those problems |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
like here #6505
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...