-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](function) Fix the issue where using convert_tz and ifnull together causes an error. #48029
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 31764 ms
|
TPC-DS: Total hot run time: 183897 ms
|
ClickBench: Total hot run time: 30.02 s
|
TeamCity be ut coverage result: |
run p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
In this PR #40366, an optimization was introduced.
However, because ifnull would return const at runtime (even if there was no const column during open), t
his would cause an error: "ConvertTzState is not initialized in function convert_tz".
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)