Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance](function) add more signatures for lag/lead fucntion #47940

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Feb 14, 2025

What problem does this PR solve?

Problem Summary:
lag/lead it's should support three params, and it's have the same means
lag(column) = lag(column,1)=lag(column,1,NULL)

https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31615 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2defb4aed2a53174c0c67578f3759b0c808d39c3, data reload: false

------ Round 1 ----------------------------------
q1	17567	5229	5017	5017
q2	2053	308	164	164
q3	10411	1233	758	758
q4	10230	1036	538	538
q5	7650	2473	2278	2278
q6	191	165	133	133
q7	904	754	618	618
q8	9384	1416	1136	1136
q9	5007	4819	4681	4681
q10	6881	2296	1926	1926
q11	482	276	250	250
q12	345	356	224	224
q13	17772	3769	3046	3046
q14	232	220	210	210
q15	507	464	456	456
q16	622	604	573	573
q17	600	868	338	338
q18	6678	6263	6313	6263
q19	1654	945	560	560
q20	324	322	186	186
q21	2890	2245	1959	1959
q22	367	332	301	301
Total cold run time: 102751 ms
Total hot run time: 31615 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5163	5110	5079	5079
q2	244	333	231	231
q3	2159	2839	2299	2299
q4	1452	1807	1383	1383
q5	4246	4145	4165	4145
q6	215	168	124	124
q7	1859	1824	1735	1735
q8	2624	2555	2547	2547
q9	7137	7159	7137	7137
q10	3021	3187	2789	2789
q11	568	513	510	510
q12	689	755	637	637
q13	3506	3896	3241	3241
q14	284	301	279	279
q15	520	453	463	453
q16	642	720	650	650
q17	1148	1647	1288	1288
q18	7552	7354	7162	7162
q19	820	847	938	847
q20	1929	1995	1876	1876
q21	5335	5007	4824	4824
q22	605	591	546	546
Total cold run time: 51718 ms
Total hot run time: 49782 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189804 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2defb4aed2a53174c0c67578f3759b0c808d39c3, data reload: false

query1	1313	972	919	919
query2	6232	1846	1794	1794
query3	10990	4370	4354	4354
query4	54949	25524	22902	22902
query5	5222	571	469	469
query6	364	194	177	177
query7	5020	537	300	300
query8	333	244	235	235
query9	6247	2501	2511	2501
query10	433	320	253	253
query11	15161	15014	14843	14843
query12	160	116	110	110
query13	1146	507	394	394
query14	10836	7135	6434	6434
query15	209	198	187	187
query16	6934	682	481	481
query17	1077	747	602	602
query18	1505	426	318	318
query19	202	209	177	177
query20	133	128	130	128
query21	209	131	104	104
query22	4587	4582	4571	4571
query23	34014	33478	33414	33414
query24	5615	2440	2391	2391
query25	467	461	397	397
query26	658	275	151	151
query27	1766	515	329	329
query28	2805	2455	2386	2386
query29	568	543	437	437
query30	215	186	157	157
query31	894	890	858	858
query32	80	62	59	59
query33	428	363	303	303
query34	754	891	498	498
query35	789	837	765	765
query36	980	985	923	923
query37	132	96	81	81
query38	4371	4267	4249	4249
query39	1482	1448	1513	1448
query40	206	116	101	101
query41	55	50	48	48
query42	120	107	101	101
query43	497	518	473	473
query44	1296	810	796	796
query45	178	175	162	162
query46	867	1050	662	662
query47	1861	1897	1804	1804
query48	398	425	320	320
query49	704	506	450	450
query50	691	735	426	426
query51	4303	4524	4227	4227
query52	111	106	94	94
query53	235	253	183	183
query54	464	482	411	411
query55	84	78	80	78
query56	268	279	267	267
query57	1194	1212	1111	1111
query58	245	250	251	250
query59	2696	2728	2783	2728
query60	288	321	263	263
query61	118	117	121	117
query62	786	754	689	689
query63	230	196	193	193
query64	1414	1029	694	694
query65	3219	3145	3130	3130
query66	710	383	311	311
query67	16006	15638	15611	15611
query68	5396	763	497	497
query69	517	296	260	260
query70	1257	1130	1059	1059
query71	423	302	251	251
query72	5888	3604	3919	3604
query73	1159	738	341	341
query74	9068	9229	8920	8920
query75	3151	3152	2692	2692
query76	3746	1174	732	732
query77	550	359	286	286
query78	10061	10058	9295	9295
query79	2665	833	583	583
query80	693	525	467	467
query81	493	272	241	241
query82	438	133	98	98
query83	180	168	147	147
query84	286	93	74	74
query85	776	344	303	303
query86	372	328	307	307
query87	4610	4449	4439	4439
query88	3418	2173	2157	2157
query89	404	312	286	286
query90	1730	195	194	194
query91	131	136	109	109
query92	71	60	55	55
query93	2598	996	564	564
query94	701	399	302	302
query95	341	267	258	258
query96	484	558	275	275
query97	2816	2843	2740	2740
query98	248	209	200	200
query99	1287	1397	1269	1269
Total cold run time: 294482 ms
Total hot run time: 189804 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2defb4aed2a53174c0c67578f3759b0c808d39c3, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.62	0.09	0.10
query5	0.41	0.44	0.41
query6	1.16	0.67	0.65
query7	0.02	0.02	0.01
query8	0.03	0.03	0.03
query9	0.59	0.52	0.53
query10	0.57	0.59	0.57
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.63	0.61	0.60
query14	2.71	2.73	2.72
query15	0.92	0.84	0.84
query16	0.37	0.39	0.37
query17	0.99	1.04	1.02
query18	0.22	0.19	0.19
query19	1.95	1.76	2.01
query20	0.01	0.02	0.01
query21	15.36	0.92	0.55
query22	0.76	1.26	0.69
query23	14.79	1.40	0.64
query24	9.11	3.31	0.49
query25	0.33	0.35	0.08
query26	0.90	0.19	0.15
query27	0.06	0.05	0.05
query28	6.34	0.80	0.43
query29	12.66	4.02	3.30
query30	0.25	0.09	0.06
query31	2.83	0.60	0.38
query32	3.22	0.54	0.46
query33	2.95	3.03	3.13
query34	15.94	5.10	4.53
query35	4.52	4.52	4.51
query36	0.66	0.50	0.49
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.02 s
Total hot run time: 30.28 s

@wm1581066 wm1581066 added dev/3.0.x usercase Important user case type label labels Feb 15, 2025
HappenLee
HappenLee previously approved these changes Feb 17, 2025
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 17, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 17, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 31755 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e75f1557f77aab8925ff679489b75ad31e42def2, data reload: false

------ Round 1 ----------------------------------
q1	17631	5348	5162	5162
q2	2047	308	165	165
q3	10405	1330	741	741
q4	10216	1002	538	538
q5	7539	2329	2418	2329
q6	192	166	136	136
q7	912	732	605	605
q8	9317	1271	1054	1054
q9	4995	4645	4857	4645
q10	6820	2301	1896	1896
q11	470	273	246	246
q12	350	355	210	210
q13	17769	3690	3043	3043
q14	230	221	209	209
q15	507	470	450	450
q16	648	615	575	575
q17	581	871	341	341
q18	6628	6459	6384	6384
q19	1225	948	579	579
q20	307	321	195	195
q21	2827	2114	1951	1951
q22	372	331	301	301
Total cold run time: 101988 ms
Total hot run time: 31755 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5186	5190	5565	5190
q2	241	328	235	235
q3	2139	2705	2311	2311
q4	1491	1870	1362	1362
q5	4241	4140	4130	4130
q6	214	163	122	122
q7	1879	1798	1766	1766
q8	2624	2636	2609	2609
q9	7160	7119	7095	7095
q10	3024	3182	2724	2724
q11	578	519	484	484
q12	692	760	594	594
q13	3551	3877	3276	3276
q14	292	310	290	290
q15	507	458	458	458
q16	641	686	646	646
q17	1147	1559	1355	1355
q18	7498	7423	7221	7221
q19	840	850	894	850
q20	1983	2007	1866	1866
q21	5448	4825	4886	4825
q22	632	600	542	542
Total cold run time: 52008 ms
Total hot run time: 49951 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183303 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e75f1557f77aab8925ff679489b75ad31e42def2, data reload: false

query1	954	376	381	376
query2	6515	1866	1827	1827
query3	6819	219	215	215
query4	26188	23222	22962	22962
query5	4316	639	482	482
query6	330	197	184	184
query7	4605	497	297	297
query8	285	243	223	223
query9	8623	2479	2501	2479
query10	467	309	248	248
query11	15644	15226	15018	15018
query12	146	105	105	105
query13	1664	505	369	369
query14	8494	6417	6503	6417
query15	211	189	185	185
query16	7129	670	489	489
query17	922	704	562	562
query18	1955	403	300	300
query19	194	186	159	159
query20	116	116	116	116
query21	210	123	107	107
query22	4335	4423	4296	4296
query23	34051	33089	32985	32985
query24	7732	2379	2379	2379
query25	576	467	406	406
query26	1230	272	164	164
query27	2243	489	330	330
query28	4024	2393	2372	2372
query29	778	565	442	442
query30	238	189	159	159
query31	914	845	817	817
query32	78	129	60	60
query33	563	339	288	288
query34	773	846	485	485
query35	790	805	744	744
query36	961	958	866	866
query37	128	96	76	76
query38	4169	4156	4185	4156
query39	1418	1396	1396	1396
query40	211	117	104	104
query41	54	55	50	50
query42	115	103	103	103
query43	481	533	472	472
query44	1261	770	770	770
query45	174	168	160	160
query46	863	1042	646	646
query47	1783	1810	1703	1703
query48	370	404	298	298
query49	769	518	417	417
query50	696	731	411	411
query51	4152	4208	4083	4083
query52	103	108	90	90
query53	231	250	183	183
query54	479	496	404	404
query55	85	81	82	81
query56	263	263	236	236
query57	1113	1148	1023	1023
query58	248	238	234	234
query59	2547	2655	2533	2533
query60	274	257	249	249
query61	111	115	110	110
query62	804	721	670	670
query63	222	192	187	187
query64	4334	965	723	723
query65	3222	3131	3126	3126
query66	1138	408	301	301
query67	16004	15479	15447	15447
query68	7836	760	497	497
query69	479	291	265	265
query70	1184	1099	1107	1099
query71	391	282	248	248
query72	5811	3631	3765	3631
query73	754	729	349	349
query74	8844	8893	8858	8858
query75	3116	3189	2725	2725
query76	3187	1159	737	737
query77	460	365	284	284
query78	10086	10007	9351	9351
query79	2338	789	578	578
query80	599	513	451	451
query81	509	283	244	244
query82	479	128	95	95
query83	170	170	152	152
query84	289	89	75	75
query85	804	341	336	336
query86	380	303	292	292
query87	4476	4504	4322	4322
query88	3866	2166	2124	2124
query89	390	307	285	285
query90	1899	191	193	191
query91	140	139	115	115
query92	71	60	57	57
query93	1948	1023	575	575
query94	676	413	272	272
query95	365	268	262	262
query96	486	577	269	269
query97	2793	2889	2739	2739
query98	237	203	199	199
query99	1305	1400	1271	1271
Total cold run time: 269263 ms
Total hot run time: 183303 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.45 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e75f1557f77aab8925ff679489b75ad31e42def2, data reload: false

query1	0.03	0.05	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.44	0.43	0.40
query6	1.15	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.52	0.52
query10	0.58	0.57	0.58
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.59	0.60
query14	2.75	2.71	2.73
query15	0.92	0.85	0.83
query16	0.38	0.38	0.39
query17	1.01	1.02	1.01
query18	0.21	0.19	0.20
query19	1.97	1.80	1.93
query20	0.02	0.01	0.01
query21	15.36	0.92	0.54
query22	0.75	1.19	0.70
query23	14.91	1.37	0.61
query24	8.53	1.94	0.61
query25	0.51	0.26	0.12
query26	0.58	0.17	0.13
query27	0.05	0.06	0.05
query28	10.01	0.85	0.44
query29	12.52	3.96	3.28
query30	0.25	0.09	0.06
query31	2.80	0.58	0.38
query32	3.22	0.56	0.47
query33	2.98	3.03	3.00
query34	15.72	5.18	4.53
query35	4.58	4.54	4.56
query36	0.67	0.51	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.89 s
Total hot run time: 30.45 s

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31529 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5a54c59dbee4655f0d4b05548687fdd6a19dd0bc, data reload: false

------ Round 1 ----------------------------------
q1	17606	5250	5041	5041
q2	2048	326	186	186
q3	10372	1292	765	765
q4	10213	1040	533	533
q5	7533	2436	2356	2356
q6	186	163	130	130
q7	900	759	599	599
q8	9305	1372	1106	1106
q9	4819	4740	4593	4593
q10	6860	2336	1900	1900
q11	483	267	249	249
q12	348	343	216	216
q13	17762	3728	3128	3128
q14	227	226	202	202
q15	527	473	460	460
q16	622	605	600	600
q17	596	882	340	340
q18	7149	6358	6136	6136
q19	1732	974	573	573
q20	308	318	187	187
q21	2820	2244	1932	1932
q22	364	328	297	297
Total cold run time: 102780 ms
Total hot run time: 31529 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5182	5151	5102	5102
q2	246	333	231	231
q3	2205	2713	2289	2289
q4	1457	1870	1400	1400
q5	4247	4127	4178	4127
q6	212	177	124	124
q7	1898	1836	1765	1765
q8	2624	2622	2565	2565
q9	7160	7108	7034	7034
q10	3020	3206	2838	2838
q11	595	518	497	497
q12	686	771	633	633
q13	3439	3901	3315	3315
q14	305	301	290	290
q15	519	470	471	470
q16	638	680	632	632
q17	1155	1642	1337	1337
q18	7723	7437	7390	7390
q19	819	802	886	802
q20	2017	2061	1908	1908
q21	5480	4987	4821	4821
q22	644	579	534	534
Total cold run time: 52271 ms
Total hot run time: 50104 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188638 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5a54c59dbee4655f0d4b05548687fdd6a19dd0bc, data reload: false

query1	1290	965	920	920
query2	6224	1852	1764	1764
query3	10969	4532	4264	4264
query4	53597	24676	23036	23036
query5	5248	549	505	505
query6	367	197	199	197
query7	5127	505	289	289
query8	320	237	235	235
query9	6610	2497	2493	2493
query10	423	297	255	255
query11	15174	15201	14811	14811
query12	163	105	107	105
query13	1164	500	373	373
query14	10542	6194	6368	6194
query15	212	195	178	178
query16	6977	661	493	493
query17	1048	697	586	586
query18	1221	380	295	295
query19	216	196	158	158
query20	126	124	116	116
query21	209	118	102	102
query22	4546	4401	4360	4360
query23	34085	33281	33338	33281
query24	5610	2485	2421	2421
query25	445	462	400	400
query26	672	276	151	151
query27	1769	473	329	329
query28	2838	2436	2398	2398
query29	560	563	428	428
query30	205	194	158	158
query31	885	910	808	808
query32	76	66	60	60
query33	452	356	297	297
query34	778	872	485	485
query35	797	843	752	752
query36	951	993	895	895
query37	123	100	70	70
query38	4180	4425	4215	4215
query39	1485	1438	1621	1438
query40	227	114	103	103
query41	53	55	53	53
query42	129	101	103	101
query43	504	497	463	463
query44	1294	811	782	782
query45	177	173	165	165
query46	866	1063	649	649
query47	1860	1872	1820	1820
query48	377	414	309	309
query49	681	511	411	411
query50	725	745	418	418
query51	4225	4328	4272	4272
query52	107	107	106	106
query53	244	263	195	195
query54	476	484	409	409
query55	84	84	84	84
query56	258	266	247	247
query57	1181	1211	1147	1147
query58	239	229	235	229
query59	2675	2696	2567	2567
query60	287	291	259	259
query61	121	128	119	119
query62	765	815	669	669
query63	222	200	181	181
query64	1460	1002	662	662
query65	3295	3180	3098	3098
query66	710	390	283	283
query67	15751	15492	15415	15415
query68	3093	793	516	516
query69	474	300	312	300
query70	1198	1115	1118	1115
query71	358	300	252	252
query72	6266	3531	3691	3531
query73	621	746	338	338
query74	9205	9242	9031	9031
query75	3163	3127	2664	2664
query76	2059	1157	744	744
query77	561	365	281	281
query78	10094	10289	9328	9328
query79	994	905	573	573
query80	818	531	451	451
query81	522	276	238	238
query82	231	129	97	97
query83	179	178	154	154
query84	283	88	70	70
query85	863	350	302	302
query86	353	317	272	272
query87	4475	4641	4467	4467
query88	2811	2193	2152	2152
query89	386	324	284	284
query90	1597	185	189	185
query91	136	137	107	107
query92	60	63	56	56
query93	1166	998	569	569
query94	623	400	298	298
query95	344	259	252	252
query96	494	547	267	267
query97	2801	2872	2747	2747
query98	220	202	206	202
query99	1302	1426	1264	1264
Total cold run time: 284427 ms
Total hot run time: 188638 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5a54c59dbee4655f0d4b05548687fdd6a19dd0bc, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.62	0.11	0.10
query5	0.40	0.41	0.40
query6	1.19	0.67	0.65
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.51	0.52
query10	0.57	0.57	0.56
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.69	2.72	2.70
query15	0.91	0.85	0.86
query16	0.37	0.37	0.38
query17	1.05	1.02	1.05
query18	0.21	0.20	0.19
query19	1.92	1.76	1.93
query20	0.02	0.02	0.01
query21	15.37	0.87	0.55
query22	0.75	1.12	0.62
query23	15.05	1.42	0.63
query24	9.79	1.75	1.21
query25	0.46	0.20	0.15
query26	0.92	0.18	0.13
query27	0.05	0.05	0.05
query28	7.02	0.80	0.45
query29	12.55	3.92	3.28
query30	0.25	0.08	0.06
query31	2.83	0.59	0.38
query32	3.22	0.55	0.46
query33	2.99	3.10	2.99
query34	15.77	5.14	4.47
query35	4.55	4.51	4.52
query36	0.64	0.50	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.57 s
Total hot run time: 30.83 s

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32431 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b8f22de676528e1807e503e6653e6f87856e58db, data reload: false

------ Round 1 ----------------------------------
q1	17782	5332	5141	5141
q2	2046	312	166	166
q3	10891	1266	769	769
q4	10213	1027	542	542
q5	7580	2462	2390	2390
q6	182	166	134	134
q7	945	765	611	611
q8	9310	1298	1141	1141
q9	4864	4777	4768	4768
q10	6831	2339	1908	1908
q11	464	274	256	256
q12	354	352	230	230
q13	18391	3752	3089	3089
q14	220	229	201	201
q15	501	475	456	456
q16	619	617	581	581
q17	571	876	333	333
q18	6964	6828	6648	6648
q19	1509	1002	569	569
q20	332	337	215	215
q21	2772	2290	1955	1955
q22	391	341	328	328
Total cold run time: 103732 ms
Total hot run time: 32431 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5178	5091	5165	5091
q2	235	331	245	245
q3	2164	2717	2350	2350
q4	1455	1880	1428	1428
q5	4254	4188	4194	4188
q6	214	170	124	124
q7	1928	1927	1758	1758
q8	2663	2647	2574	2574
q9	7207	7122	7152	7122
q10	3016	3235	2753	2753
q11	563	510	501	501
q12	686	733	591	591
q13	3475	3889	3299	3299
q14	299	314	267	267
q15	505	492	465	465
q16	636	685	625	625
q17	1128	1587	1356	1356
q18	7594	7443	7430	7430
q19	789	828	1076	828
q20	1981	2026	1870	1870
q21	5818	4911	4722	4722
q22	584	628	518	518
Total cold run time: 52372 ms
Total hot run time: 50105 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190017 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b8f22de676528e1807e503e6653e6f87856e58db, data reload: false

query1	1325	953	950	950
query2	6247	1811	1788	1788
query3	11134	4607	4607	4607
query4	54260	25418	23657	23657
query5	5309	535	467	467
query6	379	191	182	182
query7	5218	505	307	307
query8	333	249	237	237
query9	6791	2503	2510	2503
query10	409	315	250	250
query11	15314	15211	14942	14942
query12	154	106	106	106
query13	1208	512	381	381
query14	10958	6316	6442	6316
query15	216	194	175	175
query16	6990	649	477	477
query17	1058	780	614	614
query18	1508	408	315	315
query19	203	189	170	170
query20	129	126	132	126
query21	209	124	112	112
query22	4485	4559	4226	4226
query23	34171	33036	33439	33036
query24	5818	2476	2481	2476
query25	529	500	423	423
query26	648	284	159	159
query27	1617	514	405	405
query28	2925	2431	2395	2395
query29	568	566	421	421
query30	213	189	154	154
query31	912	862	820	820
query32	76	62	62	62
query33	441	347	309	309
query34	749	908	519	519
query35	782	866	760	760
query36	949	987	906	906
query37	123	100	77	77
query38	4145	4290	4255	4255
query39	1495	1484	1436	1436
query40	207	119	100	100
query41	53	51	48	48
query42	124	107	107	107
query43	505	511	470	470
query44	1280	792	798	792
query45	180	173	162	162
query46	878	1067	663	663
query47	1830	1852	1859	1852
query48	388	425	309	309
query49	705	529	412	412
query50	728	746	448	448
query51	4197	4347	4252	4252
query52	111	112	99	99
query53	230	263	198	198
query54	487	504	419	419
query55	83	77	78	77
query56	281	273	265	265
query57	1180	1186	1133	1133
query58	247	237	238	237
query59	2752	2846	2642	2642
query60	285	288	291	288
query61	120	119	116	116
query62	706	752	700	700
query63	230	186	198	186
query64	1797	1007	729	729
query65	3320	3181	3106	3106
query66	724	384	353	353
query67	15924	15552	15601	15552
query68	5745	763	504	504
query69	536	290	268	268
query70	1187	1139	1106	1106
query71	436	294	264	264
query72	5980	3714	3729	3714
query73	1067	745	343	343
query74	8924	9170	8683	8683
query75	3294	3156	2692	2692
query76	3956	1181	741	741
query77	546	372	277	277
query78	10034	10133	9249	9249
query79	2297	810	574	574
query80	606	534	442	442
query81	500	284	241	241
query82	550	129	97	97
query83	181	168	148	148
query84	289	95	83	83
query85	788	419	307	307
query86	402	286	296	286
query87	4507	4586	4353	4353
query88	3529	2198	2178	2178
query89	410	313	282	282
query90	1788	193	262	193
query91	134	141	109	109
query92	72	62	53	53
query93	1920	1019	578	578
query94	662	422	309	309
query95	341	269	252	252
query96	478	577	268	268
query97	2823	2845	2686	2686
query98	222	207	203	203
query99	1322	1424	1298	1298
Total cold run time: 295076 ms
Total hot run time: 190017 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b8f22de676528e1807e503e6653e6f87856e58db, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.04	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.42	0.42	0.41
query6	1.17	0.65	0.65
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.60	0.53	0.51
query10	0.57	0.58	0.57
query11	0.16	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.61
query14	2.70	2.72	2.72
query15	0.91	0.85	0.83
query16	0.38	0.38	0.38
query17	1.06	0.98	1.03
query18	0.21	0.19	0.19
query19	1.82	1.84	2.04
query20	0.01	0.01	0.01
query21	15.36	0.89	0.53
query22	0.73	1.13	0.63
query23	15.08	1.36	0.62
query24	11.68	1.10	0.53
query25	0.50	0.23	0.06
query26	0.81	0.19	0.14
query27	0.05	0.05	0.05
query28	6.48	0.79	0.44
query29	12.55	3.96	3.29
query30	0.25	0.10	0.06
query31	2.82	0.58	0.39
query32	3.23	0.56	0.46
query33	2.97	3.04	3.11
query34	15.78	5.18	4.58
query35	4.56	4.56	4.55
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.15	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.79 s
Total hot run time: 30.33 s

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31504 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f4f12ba1b826d3c0e24a3729778ae617f9b579a6, data reload: false

------ Round 1 ----------------------------------
q1	17602	5288	5136	5136
q2	2051	316	163	163
q3	10399	1226	745	745
q4	10201	1008	537	537
q5	7548	2397	2360	2360
q6	184	174	134	134
q7	910	758	589	589
q8	9308	1319	1061	1061
q9	4913	4854	4642	4642
q10	6803	2350	1891	1891
q11	472	279	255	255
q12	340	353	224	224
q13	17790	3715	3132	3132
q14	221	229	209	209
q15	513	477	460	460
q16	623	609	578	578
q17	566	870	331	331
q18	6847	6226	6117	6117
q19	1203	936	526	526
q20	316	319	196	196
q21	2880	2126	1927	1927
q22	352	325	291	291
Total cold run time: 102042 ms
Total hot run time: 31504 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5149	5195	5194	5194
q2	230	333	228	228
q3	2177	2725	2310	2310
q4	1422	1831	1368	1368
q5	4223	4123	4169	4123
q6	202	177	128	128
q7	1911	1835	1658	1658
q8	2637	2701	2555	2555
q9	7230	7241	7252	7241
q10	3056	3277	2828	2828
q11	569	527	501	501
q12	704	774	611	611
q13	3447	3911	3333	3333
q14	284	293	256	256
q15	514	465	459	459
q16	634	681	631	631
q17	1139	1577	1357	1357
q18	7587	7275	7363	7275
q19	769	786	810	786
q20	1978	2027	1905	1905
q21	5443	4978	4864	4864
q22	615	580	523	523
Total cold run time: 51920 ms
Total hot run time: 50134 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190413 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f4f12ba1b826d3c0e24a3729778ae617f9b579a6, data reload: false

query1	1311	960	956	956
query2	6225	1847	1820	1820
query3	11068	4631	4428	4428
query4	52809	25521	23623	23623
query5	5048	609	500	500
query6	332	190	185	185
query7	4885	499	294	294
query8	325	243	240	240
query9	5418	2598	2598	2598
query10	439	322	276	276
query11	15278	15034	14907	14907
query12	155	105	102	102
query13	1020	500	370	370
query14	10195	6822	6527	6527
query15	199	204	177	177
query16	7117	678	459	459
query17	1052	739	573	573
query18	1555	403	314	314
query19	194	190	169	169
query20	130	123	122	122
query21	211	123	102	102
query22	4439	4575	4319	4319
query23	33967	33397	33410	33397
query24	5721	2456	2432	2432
query25	456	478	398	398
query26	664	283	154	154
query27	1717	469	341	341
query28	2758	2485	2446	2446
query29	575	541	442	442
query30	211	185	152	152
query31	891	877	865	865
query32	78	63	65	63
query33	456	360	304	304
query34	797	857	520	520
query35	823	850	738	738
query36	947	992	928	928
query37	122	100	70	70
query38	4290	4373	4252	4252
query39	1513	1456	1427	1427
query40	208	117	102	102
query41	51	49	54	49
query42	120	109	114	109
query43	500	541	477	477
query44	1328	809	806	806
query45	183	170	166	166
query46	864	1059	666	666
query47	1862	1927	1792	1792
query48	390	417	308	308
query49	702	510	435	435
query50	704	766	425	425
query51	4255	4301	4313	4301
query52	123	116	96	96
query53	234	261	186	186
query54	479	505	414	414
query55	76	76	77	76
query56	268	270	243	243
query57	1200	1226	1097	1097
query58	253	249	237	237
query59	2704	2760	2754	2754
query60	277	262	255	255
query61	113	138	144	138
query62	760	738	666	666
query63	234	199	194	194
query64	1561	1096	783	783
query65	3322	3201	3161	3161
query66	778	414	311	311
query67	15762	15722	15355	15355
query68	3913	787	526	526
query69	504	313	281	281
query70	1180	1122	1102	1102
query71	419	299	260	260
query72	6437	3530	3724	3530
query73	748	735	359	359
query74	9220	9200	8826	8826
query75	3145	3264	2669	2669
query76	2764	1161	739	739
query77	517	373	284	284
query78	10100	10285	9208	9208
query79	2388	809	594	594
query80	1322	508	439	439
query81	553	283	242	242
query82	412	126	94	94
query83	241	170	159	159
query84	283	140	76	76
query85	776	347	303	303
query86	391	292	276	276
query87	4383	4406	4388	4388
query88	2872	2227	2208	2208
query89	395	332	286	286
query90	1623	194	193	193
query91	140	139	109	109
query92	65	58	57	57
query93	1717	1016	585	585
query94	680	417	305	305
query95	345	266	260	260
query96	485	557	268	268
query97	2836	2880	2747	2747
query98	224	202	204	202
query99	1309	1437	1246	1246
Total cold run time: 287089 ms
Total hot run time: 190413 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f4f12ba1b826d3c0e24a3729778ae617f9b579a6, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.03	0.04
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.40	0.41	0.42
query6	1.15	0.66	0.67
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.60	0.54	0.53
query10	0.58	0.57	0.58
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.60
query14	2.73	2.70	2.75
query15	0.93	0.86	0.83
query16	0.41	0.37	0.38
query17	1.02	1.03	0.99
query18	0.22	0.20	0.19
query19	1.89	1.84	1.99
query20	0.01	0.01	0.01
query21	15.35	0.94	0.54
query22	0.74	1.22	0.64
query23	14.99	1.41	0.59
query24	10.00	1.08	1.48
query25	0.55	0.27	0.05
query26	0.68	0.18	0.14
query27	0.05	0.05	0.04
query28	7.31	0.77	0.44
query29	12.54	3.96	3.30
query30	0.27	0.09	0.07
query31	2.81	0.57	0.39
query32	3.23	0.54	0.46
query33	3.00	3.02	3.01
query34	15.61	5.15	4.47
query35	4.53	4.57	4.55
query36	0.68	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.68 s
Total hot run time: 30.73 s

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31810 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 82df9e11b05b4a2c3d1eba63efecfe8030c66436, data reload: false

------ Round 1 ----------------------------------
q1	17596	5288	5139	5139
q2	2054	292	173	173
q3	10490	1337	757	757
q4	10234	1036	539	539
q5	7620	2504	2356	2356
q6	194	170	136	136
q7	926	771	614	614
q8	9314	1364	1204	1204
q9	4944	4745	4610	4610
q10	6840	2347	1875	1875
q11	474	279	259	259
q12	356	367	222	222
q13	17760	3701	3105	3105
q14	235	223	215	215
q15	509	490	461	461
q16	617	605	578	578
q17	605	878	353	353
q18	6658	6256	6132	6132
q19	1462	966	572	572
q20	323	327	194	194
q21	2962	2165	2014	2014
q22	360	331	302	302
Total cold run time: 102533 ms
Total hot run time: 31810 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5203	5143	5182	5143
q2	241	333	235	235
q3	2129	2691	2323	2323
q4	1457	1827	1357	1357
q5	4245	4168	4155	4155
q6	206	164	129	129
q7	1869	1858	1754	1754
q8	2614	2634	2562	2562
q9	7275	7081	7051	7051
q10	3016	3177	2801	2801
q11	578	523	495	495
q12	686	730	603	603
q13	3450	3924	3227	3227
q14	281	285	266	266
q15	504	466	448	448
q16	651	665	636	636
q17	1123	1613	1331	1331
q18	7583	7429	7410	7410
q19	810	836	870	836
q20	1960	2013	1867	1867
q21	5390	4974	4945	4945
q22	631	617	551	551
Total cold run time: 51902 ms
Total hot run time: 50125 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182803 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 82df9e11b05b4a2c3d1eba63efecfe8030c66436, data reload: false

query1	979	393	388	388
query2	6543	1994	1961	1961
query3	6803	222	215	215
query4	26127	23992	23694	23694
query5	4286	649	503	503
query6	300	199	178	178
query7	4610	493	295	295
query8	278	230	239	230
query9	8614	2537	2506	2506
query10	446	311	235	235
query11	15693	15147	14925	14925
query12	157	103	101	101
query13	1664	525	379	379
query14	9138	6315	6140	6140
query15	233	191	172	172
query16	7155	663	503	503
query17	1216	713	552	552
query18	1953	432	284	284
query19	186	181	146	146
query20	119	122	115	115
query21	207	131	102	102
query22	4184	4204	4079	4079
query23	33965	32943	32997	32943
query24	8032	2397	2371	2371
query25	509	442	381	381
query26	1243	274	153	153
query27	2608	475	340	340
query28	4378	2424	2396	2396
query29	743	552	412	412
query30	227	186	152	152
query31	960	863	754	754
query32	70	64	63	63
query33	554	346	299	299
query34	770	835	526	526
query35	784	813	726	726
query36	959	974	864	864
query37	118	100	79	79
query38	4073	4270	4115	4115
query39	1441	1386	1376	1376
query40	206	114	105	105
query41	57	56	50	50
query42	121	104	99	99
query43	517	528	495	495
query44	1303	800	791	791
query45	175	166	159	159
query46	875	1035	645	645
query47	1756	1845	1710	1710
query48	381	418	306	306
query49	771	502	413	413
query50	684	724	432	432
query51	4177	4186	4113	4113
query52	104	107	97	97
query53	239	262	187	187
query54	477	493	411	411
query55	82	78	78	78
query56	256	288	261	261
query57	1120	1150	1086	1086
query58	267	241	255	241
query59	2779	2703	2835	2703
query60	306	282	273	273
query61	145	170	114	114
query62	780	716	659	659
query63	252	194	199	194
query64	4371	981	689	689
query65	3243	3134	3107	3107
query66	1142	401	305	305
query67	16100	15425	15096	15096
query68	4640	799	553	553
query69	478	303	272	272
query70	1228	1120	1088	1088
query71	407	290	268	268
query72	5678	2662	3735	2662
query73	704	763	356	356
query74	9254	9078	8929	8929
query75	3147	3185	2705	2705
query76	3162	1165	725	725
query77	465	356	277	277
query78	9943	10103	9213	9213
query79	1340	875	637	637
query80	610	533	506	506
query81	481	275	239	239
query82	192	126	91	91
query83	166	173	157	157
query84	239	95	70	70
query85	730	341	307	307
query86	322	296	291	291
query87	4445	4601	4466	4466
query88	2915	2251	2214	2214
query89	399	318	288	288
query90	1771	201	196	196
query91	138	139	107	107
query92	61	63	56	56
query93	1149	982	582	582
query94	588	391	339	339
query95	351	262	263	262
query96	497	525	266	266
query97	2735	2888	2750	2750
query98	222	206	197	197
query99	1341	1373	1262	1262
Total cold run time: 264809 ms
Total hot run time: 182803 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 82df9e11b05b4a2c3d1eba63efecfe8030c66436, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.63	0.10	0.10
query5	0.43	0.41	0.41
query6	1.16	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.51	0.51
query10	0.57	0.58	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.60	0.60
query14	2.68	2.70	2.72
query15	0.94	0.85	0.87
query16	0.38	0.37	0.37
query17	1.06	1.06	1.04
query18	0.22	0.21	0.20
query19	1.88	1.81	1.98
query20	0.01	0.02	0.01
query21	15.35	0.87	0.55
query22	0.77	1.14	0.62
query23	15.03	1.42	0.65
query24	12.46	1.09	0.35
query25	0.32	0.12	0.14
query26	1.02	0.19	0.15
query27	0.05	0.04	0.04
query28	6.00	0.77	0.43
query29	12.57	3.98	3.31
query30	0.25	0.08	0.06
query31	2.83	0.58	0.38
query32	3.22	0.55	0.46
query33	3.14	3.00	3.07
query34	15.76	5.11	4.54
query35	4.52	4.52	4.53
query36	0.66	0.50	0.48
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.32 s
Total hot run time: 30.2 s

Copy link
Contributor

@starocean999 starocean999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 19, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@HappenLee HappenLee merged commit 8c7a76a into apache:master Feb 19, 2025
24 checks passed
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Feb 19, 2025
…#47940)

Problem Summary:
lag/lead it's should support three params, and it's have the same means
lag(column) = lag(column,1)=lag(column,1,NULL)

https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag

None

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Feb 19, 2025
…#47940)

Problem Summary:
lag/lead it's should support three params, and it's have the same means
lag(column) = lag(column,1)=lag(column,1,NULL)

https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag

None

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.x dev/3.0.x-conflict reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants