-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](function) add more signatures for lag/lead fucntion #47940
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 31615 ms
|
TPC-DS: Total hot run time: 189804 ms
|
ClickBench: Total hot run time: 30.28 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
TPC-H: Total hot run time: 31755 ms
|
TPC-DS: Total hot run time: 183303 ms
|
ClickBench: Total hot run time: 30.45 s
|
run buildall |
TPC-H: Total hot run time: 31529 ms
|
TPC-DS: Total hot run time: 188638 ms
|
ClickBench: Total hot run time: 30.83 s
|
run buildall |
TPC-H: Total hot run time: 32431 ms
|
TPC-DS: Total hot run time: 190017 ms
|
ClickBench: Total hot run time: 30.33 s
|
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java
Outdated
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 31504 ms
|
TPC-DS: Total hot run time: 190413 ms
|
ClickBench: Total hot run time: 30.73 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
TPC-H: Total hot run time: 31810 ms
|
TPC-DS: Total hot run time: 182803 ms
|
ClickBench: Total hot run time: 30.2 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…#47940) Problem Summary: lag/lead it's should support three params, and it's have the same means lag(column) = lag(column,1)=lag(column,1,NULL) https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag None - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…#47940) Problem Summary: lag/lead it's should support three params, and it's have the same means lag(column) = lag(column,1)=lag(column,1,NULL) https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag None - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
What problem does this PR solve?
Problem Summary:
lag/lead it's should support three params, and it's have the same means
lag(column) = lag(column,1)=lag(column,1,NULL)
https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_lag
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)