Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Initialize the KerberosTicketEntry struct variable in kerberos ticket. #47826

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zhangm365
Copy link

@zhangm365 zhangm365 commented Feb 12, 2025

What problem does this PR solve?

fix the KerberosTicketEntry entry initialization to enable compile pass.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangm365 zhangm365 changed the title Fix the variable initialization in kerberos_ticket_mgr.cpp. Fix the variable initialization in kerberos ticket. Feb 17, 2025
@zhangm365 zhangm365 changed the title Fix the variable initialization in kerberos ticket. [Fix] Initialize the KerberosTicketEntry struct variable in kerberos ticket. Feb 17, 2025
@zhangm365
Copy link
Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 43.43% (11528/26545)
Line Coverage: 33.57% (97005/289006)
Region Coverage: 32.69% (49697/152027)
Branch Coverage: 28.44% (24994/87888)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60cdef88da46e52bb60c6e9e721487d0deb33954_60cdef88da46e52bb60c6e9e721487d0deb33954/report/index.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 19, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

run buildall

@morningman morningman self-assigned this Feb 19, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 31681 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60cdef88da46e52bb60c6e9e721487d0deb33954, data reload: false

------ Round 1 ----------------------------------
q1	17581	5307	5078	5078
q2	2057	310	175	175
q3	10469	1366	740	740
q4	10246	1011	534	534
q5	7568	2500	2325	2325
q6	196	177	137	137
q7	909	762	622	622
q8	9326	1368	1177	1177
q9	4897	4588	4685	4588
q10	6832	2316	1890	1890
q11	478	284	256	256
q12	355	358	217	217
q13	17772	3670	3098	3098
q14	224	229	209	209
q15	502	465	446	446
q16	629	614	574	574
q17	576	862	350	350
q18	6934	6246	6294	6246
q19	1844	971	573	573
q20	316	334	190	190
q21	2775	2387	1956	1956
q22	379	333	300	300
Total cold run time: 102865 ms
Total hot run time: 31681 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5197	5127	5116	5116
q2	238	332	232	232
q3	2165	2679	2296	2296
q4	1421	1867	1345	1345
q5	4267	4171	4174	4171
q6	209	164	124	124
q7	1894	1860	1817	1817
q8	2667	2591	2587	2587
q9	7281	7038	7245	7038
q10	3060	3223	2822	2822
q11	582	512	500	500
q12	700	798	622	622
q13	3490	4118	3345	3345
q14	282	292	274	274
q15	516	480	456	456
q16	655	666	627	627
q17	1155	1572	1368	1368
q18	7625	7300	7389	7300
q19	830	824	980	824
q20	1957	2042	1856	1856
q21	5412	5054	4878	4878
q22	612	585	555	555
Total cold run time: 52215 ms
Total hot run time: 50153 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183966 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60cdef88da46e52bb60c6e9e721487d0deb33954, data reload: false

query1	963	376	384	376
query2	6534	1848	1810	1810
query3	6797	220	215	215
query4	26631	23732	23553	23553
query5	4314	698	498	498
query6	301	196	209	196
query7	4599	506	298	298
query8	298	245	238	238
query9	8619	2546	2542	2542
query10	459	311	258	258
query11	15423	15118	14963	14963
query12	164	109	101	101
query13	1675	518	388	388
query14	8876	6391	6364	6364
query15	226	203	175	175
query16	7177	635	450	450
query17	1207	741	555	555
query18	1964	405	316	316
query19	233	195	164	164
query20	126	119	116	116
query21	213	123	103	103
query22	4294	4271	4257	4257
query23	33694	32914	32935	32914
query24	8115	2410	2409	2409
query25	559	443	388	388
query26	1223	270	155	155
query27	2615	479	348	348
query28	4240	2417	2392	2392
query29	756	556	444	444
query30	232	181	154	154
query31	908	845	794	794
query32	74	61	62	61
query33	588	385	301	301
query34	775	854	536	536
query35	798	817	741	741
query36	969	991	906	906
query37	120	92	74	74
query38	4185	4296	4235	4235
query39	1446	1392	1384	1384
query40	207	118	104	104
query41	55	50	49	49
query42	127	110	113	110
query43	490	490	481	481
query44	1303	806	796	796
query45	181	167	168	167
query46	883	1054	664	664
query47	1733	1768	1722	1722
query48	403	438	307	307
query49	773	508	431	431
query50	702	729	420	420
query51	4204	4197	4074	4074
query52	111	104	98	98
query53	231	252	187	187
query54	502	480	427	427
query55	88	89	85	85
query56	275	261	256	256
query57	1162	1161	1074	1074
query58	243	233	240	233
query59	2589	2706	2466	2466
query60	303	273	260	260
query61	121	145	118	118
query62	809	717	674	674
query63	243	195	200	195
query64	4324	1005	657	657
query65	3230	3164	3174	3164
query66	1130	402	303	303
query67	15940	15367	15270	15270
query68	7328	778	523	523
query69	489	303	263	263
query70	1192	1100	1102	1100
query71	412	286	276	276
query72	5711	3677	3534	3534
query73	758	745	364	364
query74	9122	9177	8733	8733
query75	3165	3153	2691	2691
query76	3147	1156	736	736
query77	487	437	286	286
query78	9896	10075	9266	9266
query79	2254	855	621	621
query80	593	516	435	435
query81	517	276	245	245
query82	431	124	99	99
query83	176	167	156	156
query84	243	96	75	75
query85	792	350	311	311
query86	381	309	304	304
query87	4600	4471	4599	4471
query88	4116	2231	2224	2224
query89	395	329	315	315
query90	1899	195	202	195
query91	137	145	113	113
query92	76	60	61	60
query93	1816	1036	595	595
query94	676	414	296	296
query95	359	275	258	258
query96	512	561	286	286
query97	2826	2788	2731	2731
query98	236	206	192	192
query99	1304	1458	1248	1248
Total cold run time: 270798 ms
Total hot run time: 183966 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 60cdef88da46e52bb60c6e9e721487d0deb33954, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.41	0.43	0.39
query6	1.16	0.67	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.59	0.52	0.55
query10	0.58	0.58	0.56
query11	0.15	0.10	0.11
query12	0.14	0.11	0.12
query13	0.63	0.60	0.59
query14	2.73	2.74	2.70
query15	0.93	0.84	0.85
query16	0.37	0.40	0.38
query17	1.06	1.07	1.03
query18	0.22	0.20	0.20
query19	1.88	1.83	2.03
query20	0.01	0.02	0.01
query21	15.35	0.89	0.55
query22	0.76	1.29	0.80
query23	14.76	1.38	0.62
query24	10.70	1.37	0.41
query25	0.43	0.26	0.14
query26	0.87	0.18	0.15
query27	0.05	0.04	0.05
query28	6.48	0.77	0.43
query29	12.55	3.96	3.32
query30	0.25	0.09	0.06
query31	2.83	0.58	0.38
query32	3.22	0.54	0.46
query33	2.96	3.03	3.03
query34	15.88	5.19	4.55
query35	4.59	4.58	4.56
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.05	0.03
query39	0.02	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.71 s
Total hot run time: 30.47 s

zhangm365 added a commit to zhangm365/doris that referenced this pull request Feb 19, 2025
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 43.83% (11635/26545)
Line Coverage: 33.75% (97543/289020)
Region Coverage: 32.84% (49925/152023)
Branch Coverage: 28.55% (25090/87882)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60cdef88da46e52bb60c6e9e721487d0deb33954_60cdef88da46e52bb60c6e9e721487d0deb33954/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x-experimental dev/3.0.x-experimental reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants