-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix](Variant) limit cast elimination to one level cast #47778
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
The expression like `cast(cast(v['a'] as bigint) as double) in (1.1, 1.2)` which contains 2 levels cast expr should not push down.Otherwise leading to incorrect result or crash
dcc37a4
to
5bb393d
Compare
run buildall |
1 similar comment
run buildall |
TeamCity be ut coverage result: |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 31920 ms
|
TPC-DS: Total hot run time: 189527 ms
|
ClickBench: Total hot run time: 30.82 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
The expression like `cast(cast(v['a'] as bigint) as double) in (1.1, 1.2)` which contains 2 levels cast expr should not push down.Otherwise leading to incorrect result or crash
The expression like `cast(cast(v['a'] as bigint) as double) in (1.1, 1.2)` which contains 2 levels cast expr should not push down.Otherwise leading to incorrect result or crash
The expression like
cast(cast(v['a'] as bigint) as double) in (1.1, 1.2)
which contains 2 levels cast expr should not push down.Otherwise leading to incorrect result or crashWhat problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)