Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](restore) support force_replace restore #47314

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Jan 22, 2025

What problem does this PR solve?

selectdb/ccr-syncer#396

force_replace flag will only replace table with different schema
except for non-OLAP tables

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat wyxxxcat force-pushed the force_restore branch 3 times, most recently from 6bdc110 to 6abe20c Compare January 23, 2025 07:15
@wyxxxcat
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32318 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6abe20cc6ab1be8240ff4c76bee4d51fb6fd70e3, data reload: false

------ Round 1 ----------------------------------
q1	17595	5455	5372	5372
q2	2052	306	164	164
q3	10578	1234	750	750
q4	10216	984	528	528
q5	7542	2405	2194	2194
q6	196	171	133	133
q7	918	747	598	598
q8	9244	1373	1189	1189
q9	5226	4943	4893	4893
q10	6868	2347	1914	1914
q11	466	262	243	243
q12	339	363	214	214
q13	17758	3697	3092	3092
q14	232	246	209	209
q15	518	469	456	456
q16	611	630	576	576
q17	568	862	328	328
q18	6999	6477	6539	6477
q19	1550	947	539	539
q20	309	319	188	188
q21	2886	2182	1953	1953
q22	369	328	308	308
Total cold run time: 103040 ms
Total hot run time: 32318 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5497	5479	5500	5479
q2	228	329	229	229
q3	2234	2642	2334	2334
q4	1430	1786	1361	1361
q5	4341	4753	4688	4688
q6	170	159	125	125
q7	2051	1899	1801	1801
q8	2608	2778	2751	2751
q9	7331	7247	7315	7247
q10	3031	3282	2781	2781
q11	571	501	502	501
q12	665	736	569	569
q13	3462	3958	3323	3323
q14	281	311	284	284
q15	520	475	469	469
q16	684	699	639	639
q17	1218	1734	1249	1249
q18	7724	7442	7333	7333
q19	795	1113	1106	1106
q20	1986	2036	1894	1894
q21	5694	5248	4868	4868
q22	619	607	602	602
Total cold run time: 53140 ms
Total hot run time: 51633 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191874 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6abe20cc6ab1be8240ff4c76bee4d51fb6fd70e3, data reload: false

query1	1310	990	892	892
query2	6103	2106	1967	1967
query3	10975	4493	4462	4462
query4	61568	29606	23267	23267
query5	5491	601	460	460
query6	436	204	190	190
query7	5550	522	304	304
query8	340	249	235	235
query9	8284	2608	2613	2608
query10	455	310	252	252
query11	17468	14982	15423	14982
query12	168	116	116	116
query13	1422	553	435	435
query14	12342	7008	7317	7008
query15	205	191	189	189
query16	6761	577	503	503
query17	1149	715	552	552
query18	1711	400	307	307
query19	192	180	160	160
query20	133	128	118	118
query21	204	120	105	105
query22	4429	4892	4281	4281
query23	34001	33303	33718	33303
query24	5651	2328	2423	2328
query25	457	450	427	427
query26	673	250	160	160
query27	1887	475	327	327
query28	4220	2463	2464	2463
query29	550	574	431	431
query30	224	194	157	157
query31	941	908	858	858
query32	73	65	59	59
query33	437	365	320	320
query34	734	921	512	512
query35	819	884	762	762
query36	1021	1055	957	957
query37	122	107	72	72
query38	4323	4312	4199	4199
query39	1520	1446	1448	1446
query40	204	124	115	115
query41	52	49	52	49
query42	123	107	120	107
query43	509	550	491	491
query44	1345	838	845	838
query45	181	172	165	165
query46	908	1073	660	660
query47	1937	1956	1883	1883
query48	395	432	334	334
query49	721	516	401	401
query50	654	690	396	396
query51	4314	4313	4197	4197
query52	120	115	99	99
query53	236	270	195	195
query54	521	540	440	440
query55	91	87	83	83
query56	292	286	286	286
query57	1175	1218	1142	1142
query58	258	225	228	225
query59	3130	3197	3194	3194
query60	280	290	274	274
query61	122	112	110	110
query62	728	723	661	661
query63	223	185	186	185
query64	1329	1018	661	661
query65	3269	3131	3115	3115
query66	717	398	309	309
query67	16049	15662	15619	15619
query68	4493	840	549	549
query69	492	305	258	258
query70	1184	1142	1086	1086
query71	408	286	257	257
query72	6003	3896	3868	3868
query73	736	759	350	350
query74	9937	8846	9008	8846
query75	3210	3194	2689	2689
query76	3464	1143	772	772
query77	480	365	270	270
query78	10124	10267	9404	9404
query79	2649	820	603	603
query80	1451	516	456	456
query81	557	284	238	238
query82	342	148	115	115
query83	248	167	150	150
query84	283	96	72	72
query85	782	337	341	337
query86	461	315	312	312
query87	4394	4473	4543	4473
query88	3648	2187	2138	2138
query89	406	332	299	299
query90	1641	191	193	191
query91	138	136	106	106
query92	64	58	52	52
query93	2629	884	535	535
query94	756	407	294	294
query95	337	268	261	261
query96	507	615	290	290
query97	2786	2816	2728	2728
query98	226	210	193	193
query99	1281	1364	1274	1274
Total cold run time: 310349 ms
Total hot run time: 191874 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.74 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6abe20cc6ab1be8240ff4c76bee4d51fb6fd70e3, data reload: false

query1	0.03	0.03	0.04
query2	0.08	0.04	0.05
query3	0.23	0.05	0.06
query4	1.63	0.09	0.09
query5	0.41	0.39	0.40
query6	1.16	0.65	0.65
query7	0.02	0.01	0.02
query8	0.06	0.05	0.05
query9	0.55	0.49	0.50
query10	0.54	0.57	0.54
query11	0.17	0.12	0.12
query12	0.17	0.13	0.13
query13	0.61	0.59	0.59
query14	2.84	2.77	2.83
query15	0.90	0.84	0.85
query16	0.38	0.38	0.38
query17	1.03	1.00	1.02
query18	0.21	0.19	0.20
query19	1.92	1.78	2.02
query20	0.01	0.01	0.01
query21	15.36	0.96	0.65
query22	0.78	0.77	0.70
query23	14.99	1.47	0.68
query24	2.23	0.36	0.23
query25	0.15	0.09	0.09
query26	0.28	0.20	0.18
query27	0.08	0.08	0.08
query28	13.46	1.23	0.55
query29	12.63	4.08	3.37
query30	0.24	0.07	0.06
query31	2.84	0.61	0.40
query32	3.23	0.57	0.48
query33	3.10	2.97	3.06
query34	16.24	5.14	4.49
query35	4.57	4.56	4.58
query36	0.82	0.50	0.48
query37	0.21	0.16	0.16
query38	0.16	0.16	0.15
query39	0.05	0.04	0.04
query40	0.17	0.14	0.13
query41	0.09	0.05	0.05
query42	0.06	0.06	0.05
query43	0.05	0.05	0.04
Total cold run time: 104.74 s
Total hot run time: 30.74 s

@wyxxxcat
Copy link
Contributor Author

run p0

@wyxxxcat
Copy link
Contributor Author

run buildall

@wyxxxcat wyxxxcat requested a review from w41ter January 24, 2025 06:00
@doris-robot
Copy link

TPC-H: Total hot run time: 32337 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 46dda4eef2f2f4780253c3ecd1252a9a22e2e251, data reload: false

------ Round 1 ----------------------------------
q1	17623	5527	5349	5349
q2	2056	299	166	166
q3	10471	1216	779	779
q4	10208	998	543	543
q5	7544	2396	2210	2210
q6	196	176	136	136
q7	909	768	604	604
q8	9227	1369	1165	1165
q9	5217	4960	4908	4908
q10	6858	2369	1921	1921
q11	479	275	272	272
q12	354	364	227	227
q13	17766	3723	3051	3051
q14	227	226	213	213
q15	544	484	476	476
q16	647	634	575	575
q17	583	872	327	327
q18	7312	6483	6390	6390
q19	2686	964	558	558
q20	300	317	185	185
q21	2824	2181	1970	1970
q22	363	337	312	312
Total cold run time: 104394 ms
Total hot run time: 32337 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5641	5581	5466	5466
q2	238	327	230	230
q3	2254	2678	2301	2301
q4	1400	1840	1365	1365
q5	4355	4805	4728	4728
q6	179	165	132	132
q7	2062	1996	1824	1824
q8	2684	2850	2771	2771
q9	7353	7261	7366	7261
q10	3044	3317	2751	2751
q11	568	508	487	487
q12	638	740	620	620
q13	3520	3943	3266	3266
q14	291	297	276	276
q15	515	471	457	457
q16	636	682	643	643
q17	1223	1769	1261	1261
q18	7923	7495	7269	7269
q19	798	1131	1124	1124
q20	2009	2057	1896	1896
q21	5810	5212	4962	4962
q22	602	609	545	545
Total cold run time: 53743 ms
Total hot run time: 51635 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191027 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 46dda4eef2f2f4780253c3ecd1252a9a22e2e251, data reload: false

query1	1308	952	945	945
query2	6418	2063	2015	2015
query3	10956	4429	4456	4429
query4	61096	29187	23107	23107
query5	5621	619	451	451
query6	424	199	196	196
query7	5569	515	300	300
query8	331	251	231	231
query9	8582	2580	2582	2580
query10	469	295	265	265
query11	17446	15043	15573	15043
query12	161	112	116	112
query13	1432	542	426	426
query14	10861	6548	7104	6548
query15	204	213	194	194
query16	7423	643	458	458
query17	1141	731	592	592
query18	1905	416	330	330
query19	193	169	159	159
query20	118	111	110	110
query21	212	124	103	103
query22	4444	4546	4505	4505
query23	33974	34508	33164	33164
query24	5509	2454	2325	2325
query25	475	505	398	398
query26	664	271	159	159
query27	1572	468	335	335
query28	4352	2492	2448	2448
query29	554	563	465	465
query30	217	190	156	156
query31	964	851	833	833
query32	68	54	56	54
query33	424	374	298	298
query34	760	904	539	539
query35	843	850	777	777
query36	1024	1086	966	966
query37	132	96	73	73
query38	4187	4303	4237	4237
query39	1500	1438	1436	1436
query40	210	117	100	100
query41	54	47	47	47
query42	120	103	106	103
query43	509	524	500	500
query44	1338	859	842	842
query45	188	174	161	161
query46	876	1077	655	655
query47	1911	1939	1874	1874
query48	391	416	321	321
query49	707	500	403	403
query50	660	687	422	422
query51	4358	4377	4265	4265
query52	110	102	95	95
query53	231	260	196	196
query54	505	510	441	441
query55	81	78	85	78
query56	280	272	270	270
query57	1183	1216	1109	1109
query58	258	238	249	238
query59	3047	3231	2965	2965
query60	290	284	274	274
query61	145	140	138	138
query62	747	710	652	652
query63	219	183	181	181
query64	1253	1011	689	689
query65	3273	3158	3149	3149
query66	699	393	302	302
query67	15857	15623	15484	15484
query68	5027	838	539	539
query69	483	298	259	259
query70	1184	1168	1153	1153
query71	419	286	253	253
query72	6363	3826	3875	3826
query73	828	772	366	366
query74	9899	9113	8820	8820
query75	3233	3162	2682	2682
query76	3788	1189	765	765
query77	480	346	271	271
query78	10065	9952	9381	9381
query79	3239	815	579	579
query80	1523	519	447	447
query81	541	270	237	237
query82	472	156	115	115
query83	269	167	163	163
query84	290	102	78	78
query85	811	353	297	297
query86	422	310	306	306
query87	4441	4479	4345	4345
query88	4740	2198	2195	2195
query89	390	332	286	286
query90	1609	193	193	193
query91	133	140	104	104
query92	63	59	53	53
query93	2927	861	536	536
query94	909	409	288	288
query95	335	265	269	265
query96	491	603	279	279
query97	2897	2894	2753	2753
query98	229	200	193	193
query99	1289	1389	1284	1284
Total cold run time: 312822 ms
Total hot run time: 191027 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 46dda4eef2f2f4780253c3ecd1252a9a22e2e251, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.05	0.05
query3	0.23	0.06	0.06
query4	1.64	0.08	0.10
query5	0.40	0.40	0.40
query6	1.16	0.66	0.67
query7	0.03	0.02	0.02
query8	0.05	0.05	0.05
query9	0.56	0.50	0.50
query10	0.58	0.57	0.55
query11	0.17	0.12	0.12
query12	0.16	0.13	0.13
query13	0.60	0.60	0.60
query14	2.83	2.71	2.83
query15	0.90	0.83	0.83
query16	0.37	0.37	0.38
query17	1.07	0.97	1.01
query18	0.20	0.20	0.19
query19	1.88	1.76	2.01
query20	0.02	0.02	0.01
query21	15.38	0.95	0.65
query22	0.78	0.81	0.70
query23	14.90	1.48	0.68
query24	2.26	0.33	0.24
query25	0.15	0.08	0.08
query26	0.29	0.19	0.17
query27	0.08	0.08	0.08
query28	13.43	1.28	0.54
query29	12.66	4.16	3.42
query30	0.25	0.08	0.06
query31	2.85	0.61	0.40
query32	3.23	0.59	0.48
query33	3.04	3.07	3.03
query34	16.14	5.23	4.52
query35	4.56	4.58	4.57
query36	0.83	0.47	0.48
query37	0.20	0.16	0.16
query38	0.16	0.16	0.16
query39	0.05	0.04	0.04
query40	0.17	0.14	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.05
Total cold run time: 104.57 s
Total hot run time: 30.81 s

w41ter
w41ter previously approved these changes Jan 24, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 24, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Feb 5, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 5, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 32187 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17ea84373e24726e9e9e20612b40624ae8058668, data reload: false

------ Round 1 ----------------------------------
q1	17619	5502	5349	5349
q2	2058	294	170	170
q3	10442	1246	737	737
q4	10208	1008	546	546
q5	7549	2441	2171	2171
q6	194	177	135	135
q7	933	754	596	596
q8	9237	1374	1187	1187
q9	5241	4857	4888	4857
q10	6852	2332	1895	1895
q11	481	275	251	251
q12	343	361	219	219
q13	17759	3718	3091	3091
q14	236	238	219	219
q15	531	478	453	453
q16	637	609	600	600
q17	571	888	326	326
q18	7297	6488	6337	6337
q19	2843	960	551	551
q20	305	308	185	185
q21	2907	2247	1989	1989
q22	383	354	323	323
Total cold run time: 104626 ms
Total hot run time: 32187 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5608	5495	5458	5458
q2	240	333	230	230
q3	2283	2669	2343	2343
q4	1468	1840	1370	1370
q5	4357	4772	4780	4772
q6	177	165	128	128
q7	2090	1972	1796	1796
q8	2632	2782	2752	2752
q9	7296	7205	7423	7205
q10	3011	3292	2779	2779
q11	575	502	482	482
q12	658	745	572	572
q13	3560	4020	3305	3305
q14	296	328	281	281
q15	540	484	482	482
q16	650	671	654	654
q17	1263	1805	1256	1256
q18	7799	7521	7364	7364
q19	819	835	1183	835
q20	2039	2078	1936	1936
q21	5761	5183	5008	5008
q22	607	642	591	591
Total cold run time: 53729 ms
Total hot run time: 51599 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190467 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17ea84373e24726e9e9e20612b40624ae8058668, data reload: false

query1	1345	935	924	924
query2	6264	2054	2023	2023
query3	11003	4530	4446	4446
query4	32490	23216	22922	22922
query5	3562	611	477	477
query6	292	226	206	206
query7	3975	476	308	308
query8	303	238	236	236
query9	9400	2655	2650	2650
query10	441	305	254	254
query11	17676	15558	14667	14667
query12	169	105	103	103
query13	1556	544	388	388
query14	10119	7370	6302	6302
query15	223	222	194	194
query16	7697	628	485	485
query17	1591	745	569	569
query18	2069	431	330	330
query19	212	191	181	181
query20	125	120	121	120
query21	204	128	109	109
query22	4683	4469	4376	4376
query23	34226	33794	33245	33245
query24	6638	2288	2327	2288
query25	503	503	423	423
query26	823	285	163	163
query27	2102	483	337	337
query28	5506	2500	2522	2500
query29	562	554	445	445
query30	220	185	158	158
query31	967	873	832	832
query32	65	60	59	59
query33	485	368	313	313
query34	744	877	531	531
query35	831	874	772	772
query36	1009	1052	962	962
query37	122	134	78	78
query38	4300	4316	4243	4243
query39	1507	1431	1435	1431
query40	211	111	102	102
query41	50	52	54	52
query42	128	104	99	99
query43	520	520	492	492
query44	1331	820	842	820
query45	193	172	166	166
query46	864	1071	659	659
query47	1943	1898	1839	1839
query48	382	402	336	336
query49	745	497	405	405
query50	674	683	401	401
query51	4383	4273	4236	4236
query52	106	102	96	96
query53	242	255	188	188
query54	502	533	423	423
query55	87	89	81	81
query56	260	256	247	247
query57	1193	1211	1143	1143
query58	254	237	240	237
query59	3036	3189	3133	3133
query60	280	279	261	261
query61	119	121	121	121
query62	788	736	667	667
query63	234	197	192	192
query64	3008	1042	674	674
query65	3361	3214	3210	3210
query66	825	405	292	292
query67	16362	15597	15490	15490
query68	5164	818	535	535
query69	483	292	252	252
query70	1197	1133	1164	1133
query71	380	293	246	246
query72	5307	3891	3907	3891
query73	634	741	362	362
query74	9891	8898	8972	8898
query75	3142	3146	2661	2661
query76	3101	1165	764	764
query77	466	367	269	269
query78	9965	9932	9364	9364
query79	3441	796	591	591
query80	641	541	451	451
query81	493	274	237	237
query82	594	153	120	120
query83	181	165	146	146
query84	238	93	77	77
query85	790	416	301	301
query86	391	323	306	306
query87	4311	4390	4305	4305
query88	4919	2162	2141	2141
query89	393	329	291	291
query90	1817	189	196	189
query91	134	143	111	111
query92	68	54	52	52
query93	2209	869	535	535
query94	684	405	300	300
query95	338	322	258	258
query96	499	612	283	283
query97	2771	2868	2746	2746
query98	231	195	199	195
query99	1282	1415	1345	1345
Total cold run time: 284245 ms
Total hot run time: 190467 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.82 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 17ea84373e24726e9e9e20612b40624ae8058668, data reload: false

query1	0.03	0.03	0.03
query2	0.09	0.04	0.05
query3	0.23	0.05	0.05
query4	1.65	0.07	0.08
query5	0.40	0.41	0.41
query6	1.18	0.66	0.66
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.56	0.50	0.50
query10	0.56	0.57	0.55
query11	0.17	0.12	0.12
query12	0.16	0.13	0.12
query13	0.61	0.60	0.59
query14	2.75	2.78	2.75
query15	0.91	0.85	0.84
query16	0.37	0.38	0.39
query17	1.03	1.04	1.03
query18	0.20	0.19	0.20
query19	1.84	1.82	2.01
query20	0.02	0.01	0.01
query21	15.38	0.96	0.68
query22	0.78	0.78	0.70
query23	15.00	1.54	0.69
query24	2.24	0.37	0.22
query25	0.15	0.09	0.08
query26	0.28	0.20	0.18
query27	0.08	0.08	0.09
query28	13.32	1.24	0.55
query29	12.68	4.03	3.38
query30	0.25	0.08	0.05
query31	2.85	0.60	0.39
query32	3.22	0.58	0.49
query33	3.01	2.97	2.99
query34	16.23	5.12	4.54
query35	4.59	4.54	4.56
query36	0.61	0.48	0.47
query37	0.20	0.17	0.15
query38	0.17	0.15	0.16
query39	0.05	0.04	0.04
query40	0.16	0.14	0.13
query41	0.10	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.05	0.04
Total cold run time: 104.29 s
Total hot run time: 30.82 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR approved by at least one committer and no changes requested.

@w41ter w41ter requested a review from dataroaring February 7, 2025 02:05
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants