Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression-test](framework) fix bug when sql returns two column with same name #47087

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[regression-test](framework) fix bug when sql returns two column with same name #47087

merged 2 commits into from
Jan 17, 2025

Conversation

shuke987
Copy link
Collaborator

@shuke987 shuke987 commented Jan 16, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
sql_return_maparray use map data structure to save sql results. If sql returns two column with same name, map will merge these two column results, causing error results.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987 shuke987 requested a review from gavinchou January 16, 2025 08:48
@shuke987
Copy link
Collaborator Author

run buildall

@shuke987 shuke987 changed the title [regression-test](framework) fix bug when sql returns two same header… [regression-test](framework) fix bug when sql returns two column with same name Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@hello-stephen hello-stephen merged commit 8189af5 into apache:master Jan 17, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 17, 2025
@shuke987
[regression-test](framework) fix bug when sql returns two column with…
5c79fff 
… same name (#47087)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
sql_return_maparray use map data structure to save sql results. If sql
returns two column with same name, map will merge these two column
results, causing error results.
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 17, 2025
@shuke987
[regression-test](framework) fix bug when sql returns two column with…
cc34df0 
… same name (#47087)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
sql_return_maparray use map data structure to save sql results. If sql
returns two column with same name, map will merge these two column
results, causing error results.
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jan 17, 2025
@github-actions @shuke987
branch-2.1: [regression-test](framework) fix bug when sql returns two…
df02005 
… column with same name #47087 (#47137)

Cherry-picked from #47087

Co-authored-by: shuke <shuke@selectdb.com>
hello-stephen pushed a commit that referenced this pull request Jan 23, 2025
@github-actions @shuke987
branch-3.0: [regression-test](framework) fix bug when sql returns two…
5d70ee5 
… column with same name #47087 (#47135)

Cherry-picked from #47087

Co-authored-by: shuke <shuke@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@shuke987 @lzyy2024
[regression-test](framework) fix bug when sql returns two column with…
2a0069c 
… same name (apache#47087)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
sql_return_maparray use map data structure to save sql results. If sql
returns two column with same name, map will merge these two column
results, causing error results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@Al-assad Al-assad Al-assad approved these changes

@dataroaring dataroaring dataroaring approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shuke987 @hello-stephen @gavinchou @Al-assad @dataroaring @morrySnow @yiguolei @wm1581066