Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optimization](agg) add float/double type in agg percentile_array #43953

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[optimization](agg) add float/double type in agg percentile_array #43953

merged 1 commit into from
Nov 18, 2024

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Nov 14, 2024 •
edited
Loading

What problem does this PR solve?

Related PR: #41206
Problem Summary:
before in pr #41206 have support float/double in percentile function,
and percentile_array is the same logical, so it's could support float/double also.

doc: apache/doris-website#1350

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes. after support float/double, it's no need to cast others integer type

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.94% (9887/26060)
Line Coverage: 29.14% (82624/283565)
Region Coverage: 28.27% (42471/150230)
Branch Coverage: 24.85% (21541/86678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f909f82ccd82c1b69d81d57f565ff9839a874ddf_f909f82ccd82c1b69d81d57f565ff9839a874ddf/report/index.html

HappenLee
HappenLee approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zclllyybb
zclllyybb approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangstar333 zhangstar333 merged commit d22b5b8 into apache:master Nov 18, 2024
27 of 30 checks passed
@yiguolei yiguolei added usercase Important user case type label dev/3.0.x labels Feb 17, 2025
@yiguolei yiguolei mentioned this pull request Feb 17, 2025
Closed
3 tasks
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Feb 19, 2025
@zhangstar333
[optimization](agg) add float/double type in agg percentile_array (ap…
5c21935 
…ache#43953)

Related PR: apache#41206
Problem Summary:
before in pr apache#41206 have support float/double in percentile function,
and percentile_array is the same logical, so it's could support
float/double also.

doc: apache/doris-website#1350
@zhangstar333 zhangstar333 mentioned this pull request Feb 19, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Feb 22, 2025
@zhangstar333
[cherry-pick](branch-30) add float/double type in agg percentile_array (
d2464dd 
#43953) (#48094)

cherry-pick from master #43953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.5-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangstar333 @doris-robot @HappenLee @zclllyybb @yiguolei @dataroaring