Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](inverted index) Remove float/double support in index writer (#35615) #43462

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[fix](inverted index) Remove float/double support in index writer (#35615) #43462

merged 1 commit into from
Nov 8, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Nov 7, 2024

bp #35615

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@qidaye
Copy link
Contributor Author

qidaye commented Nov 7, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.55% (8308/21553)
Line Coverage: 30.25% (68678/227054)
Region Coverage: 29.68% (35371/119182)
Branch Coverage: 25.44% (18190/71488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/520166cc4dfea2a59ed4e5aa2305ce26d0a6dfcf_520166cc4dfea2a59ed4e5aa2305ce26d0a6dfcf/report/index.html

airborne12
airborne12 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 71694f5 into apache:branch-2.0 Nov 8, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qidaye @doris-robot @airborne12