[bugfix](segmentload) should remove segment from segment cache if load segment failed #41608
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
| auto status = [this]() { | ||
| return _inverted_index_file_reader_open.call( | ||
| [&] { return _open_inverted_index(); }); | ||
| }(); |
There was a problem hiding this comment.
ditto why not just
| auto status = [this]() { | |
| return _inverted_index_file_reader_open.call( | |
| [&] { return _open_inverted_index(); }); | |
| }(); | |
| auto status = _inverted_index_file_reader_open.call([&] { return _open_inverted_index(); }); |
| Defer defer([&]() { _footer_pb.reset(); }); | ||
| return _create_column_readers(*_footer_pb); | ||
| }); | ||
| auto status = [this]() { |
There was a problem hiding this comment.
why not just
auto status = _create_column_readers_once_call.call(...);
|
TeamCity be ut coverage result: |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…d segment failed (apache#41608) ## Proposed changes 1. If the segment load failed, it is not recoverable, should remove it from segment cache and the query will create new segment again. 2. Could not depend on remove segment from cache during load index failed, because the call once may throw exception and the error handle logic is not reached. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>
…d segment failed (apache#41608) ## Proposed changes 1. If the segment load failed, it is not recoverable, should remove it from segment cache and the query will create new segment again. 2. Could not depend on remove segment from cache during load index failed, because the call once may throw exception and the error handle logic is not reached. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>
## Proposed changes Issue Number: close #xxx introduced by #41608 <!--Describe your changes.--> Co-authored-by: yiguolei <yiguolei@gmail.com>
…he#41685) ## Proposed changes Issue Number: close #xxx introduced by apache#41608 <!--Describe your changes.--> Co-authored-by: yiguolei <yiguolei@gmail.com>
…d segment failed (apache#41608) ## Proposed changes 1. If the segment load failed, it is not recoverable, should remove it from segment cache and the query will create new segment again. 2. Could not depend on remove segment from cache during load index failed, because the call once may throw exception and the error handle logic is not reached. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>
…d segment failed (apache#41608) ## Proposed changes 1. If the segment load failed, it is not recoverable, should remove it from segment cache and the query will create new segment again. 2. Could not depend on remove segment from cache during load index failed, because the call once may throw exception and the error handle logic is not reached. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>
…he#41685) ## Proposed changes Issue Number: close #xxx introduced by apache#41608 <!--Describe your changes.--> Co-authored-by: yiguolei <yiguolei@gmail.com>
…d segment failed (apache#41608) ## Proposed changes 1. If the segment load failed, it is not recoverable, should remove it from segment cache and the query will create new segment again. 2. Could not depend on remove segment from cache during load index failed, because the call once may throw exception and the error handle logic is not reached. --------- Co-authored-by: yiguolei <yiguolei@gmail.com>
…he#41685) ## Proposed changes Issue Number: close #xxx introduced by apache#41608 <!--Describe your changes.--> Co-authored-by: yiguolei <yiguolei@gmail.com>
Proposed changes