Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](file-cache) add evict file number per round #39721

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

morningman
Copy link
Contributor

Previously, when getting block from file cache, it may try to evict
lots of blocks to reserve capacity for lru cache. This operation may take long time
while hold the lock, causing other operation blocked.

This PR add a new BE config file_cache_max_evict_num_per_round,
default is 1000, so that it will not hold lock for a long time.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@morningman morningman marked this pull request as draft August 21, 2024 10:45
@morningman
Copy link
Contributor Author

run buildall

@morningman morningman marked this pull request as ready for review August 27, 2024 16:26
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@morningman morningman merged commit 6915d76 into apache:branch-2.1 Aug 28, 2024
19 of 21 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants