-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) should push project through limit after eliminate union node #39640
Merged
morrySnow
merged 2 commits into
apache:master
from
morrySnow:fix_push_limit_conflict_with_union_elimiante
Aug 22, 2024
Merged
[fix](Nereids) should push project through limit after eliminate union node #39640
morrySnow
merged 2 commits into
apache:master
from
morrySnow:fix_push_limit_conflict_with_union_elimiante
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
9399a78
to
a1e599b
Compare
run buildall |
TPC-H: Total hot run time: 37687 ms
|
a1e599b
to
f00331c
Compare
run buildall |
other wise: push limit through union could generate plan: ``` limit +-- union |-- limit | +-- empty relation +-- limit +-- project ``` and then eliminate union will generate plan: ``` +-- limit +- project +-- limit +-- project ``` it could not be processed by tranlator correctly
f00331c
to
c7ae49a
Compare
run buildall |
TPC-H: Total hot run time: 38371 ms
|
TPC-DS: Total hot run time: 190607 ms
|
ClickBench: Total hot run time: 31.35 s
|
run cloud_p1 |
run feut |
run external |
run buildall |
TPC-H: Total hot run time: 38040 ms
|
TPC-DS: Total hot run time: 196786 ms
|
ClickBench: Total hot run time: 32.3 s
|
924060929
approved these changes
Aug 22, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Aug 22, 2024
morrySnow
added a commit
that referenced
this pull request
Aug 22, 2024
…n node (#39640) pick from master #39640 otherwise: push limit through union could generate plan: limit +-- union |-- limit | +-- empty relation +-- limit +-- project and then eliminate union will generate plan: +-- limit +- project +-- limit +-- project it could not be processed by tranlator correctly
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Aug 22, 2024
…n node (apache#39640) pick from master apache#39640 otherwise: push limit through union could generate plan: limit +-- union |-- limit | +-- empty relation +-- limit +-- project and then eliminate union will generate plan: +-- limit +- project +-- limit +-- project it could not be processed by tranlator correctly
morrySnow
added a commit
that referenced
this pull request
Aug 22, 2024
…n node (#39640) (#39761) pick from master #39640 otherwise: push limit through union could generate plan: limit +-- union |-- limit | +-- empty relation +-- limit +-- project and then eliminate union will generate plan: +-- limit +- project +-- limit +-- project it could not be processed by tranlator correctly
morrySnow
added a commit
that referenced
this pull request
Aug 22, 2024
…n node (#39640) (#39755) pick from master #39640 otherwise: push limit through union could generate plan: limit +-- union |-- limit | +-- empty relation +-- limit +-- project and then eliminate union will generate plan: +-- limit +- project +-- limit +-- project it could not be processed by tranlator correctly
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
…n node (#39640) otherwise: push limit through union could generate plan: limit +-- union |-- limit | +-- empty relation +-- limit +-- project and then eliminate union will generate plan: +-- limit +- project +-- limit +-- project it could not be processed by tranlator correctly
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Dec 11, 2024
…n node (apache#39640) (apache#39761) pick from master apache#39640 otherwise: push limit through union could generate plan: limit +-- union |-- limit | +-- empty relation +-- limit +-- project and then eliminate union will generate plan: +-- limit +- project +-- limit +-- project it could not be processed by tranlator correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.0.15-merged
dev/2.1.6-merged
dev/3.0.2-merged
reviewed
usercase
Important user case type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
other wise:
push limit through union could generate plan:
and then eliminate union will generate plan:
it could not be processed by tranlator correctly
Proposed changes
Issue Number: close #xxx