Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement](delete) Add a hint msg for forbidden delete when MV or rollup exists #39505

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

TangSiyang2001
Copy link
Collaborator

Proposed changes

When MV or Rollup exists, delete is forbidden on the base table currently. Add a hint msg to indicate it.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@TangSiyang2001
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 16, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 38435 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a304e43fba04c57026e8d2d437a81ac197ac0af, data reload: false

------ Round 1 ----------------------------------
q1	17933	4538	4404	4404
q2	2870	223	214	214
q3	11082	1143	1074	1074
q4	10906	821	733	733
q5	8456	2898	2763	2763
q6	264	159	161	159
q7	1026	664	653	653
q8	9381	2080	2092	2080
q9	7046	6565	6559	6559
q10	7098	2232	2221	2221
q11	505	273	272	272
q12	426	265	265	265
q13	17804	3026	2983	2983
q14	302	258	254	254
q15	574	527	533	527
q16	545	420	416	416
q17	989	720	718	718
q18	7440	6837	6784	6784
q19	6613	1140	1092	1092
q20	705	363	348	348
q21	4281	2879	2894	2879
q22	1131	1044	1037	1037
Total cold run time: 117377 ms
Total hot run time: 38435 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4510	4282	4303	4282
q2	414	323	316	316
q3	2848	2618	2626	2618
q4	1914	1616	1617	1616
q5	5354	5418	5381	5381
q6	235	150	149	149
q7	2122	1728	1740	1728
q8	3205	3385	3349	3349
q9	8413	8381	8326	8326
q10	3401	3200	3167	3167
q11	644	539	562	539
q12	799	648	604	604
q13	16778	2998	2968	2968
q14	316	296	287	287
q15	557	511	517	511
q16	491	444	440	440
q17	1780	1493	1492	1492
q18	7867	8289	7658	7658
q19	2882	1593	1664	1593
q20	2066	1820	1816	1816
q21	14111	5077	5108	5077
q22	1140	1046	1036	1036
Total cold run time: 81847 ms
Total hot run time: 54953 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190727 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7a304e43fba04c57026e8d2d437a81ac197ac0af, data reload: false

query1	1006	428	389	389
query2	6736	2074	2026	2026
query3	6669	222	240	222
query4	27993	23521	23288	23288
query5	4394	715	713	713
query6	312	212	204	204
query7	4627	340	334	334
query8	479	435	424	424
query9	8547	2533	2520	2520
query10	509	340	353	340
query11	17811	15008	15049	15008
query12	192	142	136	136
query13	1720	463	466	463
query14	10090	7473	6709	6709
query15	313	191	189	189
query16	8190	512	503	503
query17	1662	594	581	581
query18	2179	338	334	334
query19	296	172	168	168
query20	145	137	138	137
query21	249	146	142	142
query22	4308	4002	4053	4002
query23	34371	33420	33341	33341
query24	11277	2894	2902	2894
query25	642	439	413	413
query26	1149	183	179	179
query27	2372	311	312	311
query28	7479	2194	2137	2137
query29	858	451	442	442
query30	337	191	181	181
query31	1052	829	825	825
query32	119	77	81	77
query33	807	342	344	342
query34	906	508	503	503
query35	899	771	773	771
query36	1119	963	928	928
query37	176	101	101	101
query38	3979	3893	3882	3882
query39	1540	1477	1456	1456
query40	235	154	155	154
query41	140	140	138	138
query42	131	115	119	115
query43	557	526	526	526
query44	1236	782	804	782
query45	226	205	191	191
query46	1129	780	761	761
query47	1938	1856	1855	1855
query48	414	335	338	335
query49	1269	593	579	579
query50	860	482	480	480
query51	6863	6727	6724	6724
query52	116	108	114	108
query53	296	233	220	220
query54	976	508	504	504
query55	93	91	96	91
query56	336	315	306	306
query57	1212	1147	1164	1147
query58	325	319	308	308
query59	3142	2911	2961	2911
query60	350	332	326	326
query61	153	148	146	146
query62	891	694	705	694
query63	262	228	226	226
query64	5432	2379	1842	1842
query65	3238	3218	3148	3148
query66	1124	685	679	679
query67	15562	14949	14812	14812
query68	4871	583	588	583
query69	723	400	337	337
query70	1223	1170	1135	1135
query71	489	315	311	311
query72	7565	2278	2060	2060
query73	800	354	361	354
query74	9232	8779	8711	8711
query75	4242	2716	2769	2716
query76	3652	1085	1000	1000
query77	846	441	435	435
query78	10588	9624	9235	9235
query79	8484	561	585	561
query80	1186	621	600	600
query81	636	263	260	260
query82	1220	152	158	152
query83	424	235	214	214
query84	292	98	95	95
query85	811	360	352	352
query86	453	323	323	323
query87	4393	4227	4261	4227
query88	5394	2566	2557	2557
query89	547	326	329	326
query90	1979	228	228	228
query91	158	125	127	125
query92	87	73	77	73
query93	6048	555	560	555
query94	824	319	310	310
query95	389	294	296	294
query96	628	282	285	282
query97	3264	3077	3076	3076
query98	235	229	233	229
query99	1590	1312	1288	1288
Total cold run time: 309288 ms
Total hot run time: 190727 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.53 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7a304e43fba04c57026e8d2d437a81ac197ac0af, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.05
query3	0.23	0.05	0.05
query4	1.67	0.10	0.08
query5	0.50	0.49	0.48
query6	1.14	0.74	0.73
query7	0.02	0.02	0.02
query8	0.06	0.04	0.05
query9	0.54	0.49	0.48
query10	0.55	0.54	0.55
query11	0.15	0.12	0.12
query12	0.16	0.12	0.13
query13	0.61	0.60	0.60
query14	0.77	0.77	0.79
query15	0.86	0.82	0.83
query16	0.37	0.38	0.39
query17	1.00	0.99	1.01
query18	0.23	0.23	0.22
query19	1.92	1.78	1.74
query20	0.02	0.01	0.01
query21	15.40	0.67	0.67
query22	4.05	7.29	2.22
query23	18.29	1.44	1.26
query24	2.09	0.24	0.22
query25	0.16	0.09	0.10
query26	0.30	0.23	0.23
query27	0.46	0.23	0.24
query28	13.30	1.03	1.01
query29	12.65	3.36	3.35
query30	0.44	0.24	0.20
query31	2.80	0.39	0.40
query32	3.24	0.49	0.49
query33	2.93	2.98	2.99
query34	16.79	4.33	4.49
query35	4.47	4.39	4.41
query36	0.66	0.48	0.50
query37	0.20	0.17	0.18
query38	0.17	0.16	0.16
query39	0.06	0.05	0.05
query40	0.17	0.15	0.15
query41	0.11	0.06	0.06
query42	0.08	0.07	0.07
query43	0.06	0.06	0.06
Total cold run time: 109.8 s
Total hot run time: 31.53 s

@dataroaring dataroaring merged commit ff892b3 into apache:master Aug 18, 2024
30 of 31 checks passed
TangSiyang2001 added a commit to TangSiyang2001/doris that referenced this pull request Aug 23, 2024
…rollup exists (apache#39505)

## Proposed changes

When MV or Rollup exists, delete is forbidden on the base table
currently. Add a hint msg to indicate it.
dataroaring pushed a commit that referenced this pull request Aug 23, 2024
…rollup exists (#39505) (#39857)

## Proposed changes

When MV or Rollup exists, delete is forbidden on the base table
currently. Add a hint msg to indicate it.
dataroaring pushed a commit that referenced this pull request Aug 23, 2024
…rollup exists (#39505)

## Proposed changes

When MV or Rollup exists, delete is forbidden on the base table
currently. Add a hint msg to indicate it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants