[fix](nereids)prevent null pointer exception if datetime value overflows #39482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38165 ms |
TPC-DS: Total hot run time: 190725 ms |
ClickBench: Total hot run time: 31.03 s |
|
run buildall |
TPC-H: Total hot run time: 38128 ms |
TPC-DS: Total hot run time: 195911 ms |
ClickBench: Total hot run time: 31.93 s |
morrySnow
reviewed
Aug 20, 2024
| @@ -336,7 +336,7 @@ protected boolean checkDate() { | |||
| } | |||
|
|
|||
| protected static boolean isDateOutOfRange(LocalDateTime dateTime) { | |||
| return dateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY); | |||
| return dateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY) || dateTime == null; | |||
There was a problem hiding this comment.
Suggested change
| return dateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY) || dateTime == null; | |
| return dateTime == null || dateTime.isBefore(START_OF_A_DAY) || dateTime.isAfter(END_OF_A_DAY); |
| break; | ||
| } | ||
| } catch (Exception ex) { | ||
| // do nothing |
There was a problem hiding this comment.
exception is expensive, could we process it without try catch
f54c15b to
b27f498
Compare
|
run buildall |
TPC-H: Total hot run time: 38313 ms |
TPC-DS: Total hot run time: 190750 ms |
ClickBench: Total hot run time: 31.29 s |
morrySnow
approved these changes
Aug 21, 2024
LiBinfeng-01
approved these changes
Aug 21, 2024
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
This was referenced Aug 21, 2024
dataroaring
pushed a commit
that referenced
this pull request
Sep 26, 2024
…lows (#39482) date and datetime literal's plusXXX method( plusDays, plusWeeks, plusMonths) may return NullLiteral, So we should only convert the return value to date or datetime literal when it's not a NullLiteral
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Dec 11, 2024
…ows (apache#39676) pick from master apache#39482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date and datetime literal's plusXXX method( plusDays, plusWeeks, plusMonths) may return NullLiteral, So we should only convert the return value to date or datetime literal when it's not a NullLiteral