Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) npe when delete with cte and without using #39379

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[fix](Nereids) npe when delete with cte and without using #39379

merged 1 commit into from
Aug 15, 2024

Conversation

morrySnow
Copy link
Contributor

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 14, 2024
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37475 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit acf232dd1e9d218a43812c133edb6007c4a460eb, data reload: false

------ Round 1 ----------------------------------
q1	18180	4498	4384	4384
q2	2485	227	175	175
q3	12050	1160	1039	1039
q4	10735	658	787	658
q5	8189	2830	2806	2806
q6	222	142	144	142
q7	949	604	588	588
q8	9322	2010	2042	2010
q9	7278	6532	6455	6455
q10	7039	2204	2230	2204
q11	474	259	248	248
q12	387	227	225	225
q13	18754	3002	3021	3002
q14	270	258	235	235
q15	514	494	508	494
q16	496	402	392	392
q17	969	649	738	649
q18	7439	6838	6766	6766
q19	3537	1072	984	984
q20	676	321	352	321
q21	3937	2894	2702	2702
q22	1100	1002	996	996
Total cold run time: 115002 ms
Total hot run time: 37475 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4444	4249	4281	4249
q2	377	278	252	252
q3	2866	2633	2589	2589
q4	1900	1677	1610	1610
q5	5382	5391	5372	5372
q6	218	130	131	130
q7	2055	1666	1681	1666
q8	3157	3314	3341	3314
q9	8422	8325	8280	8280
q10	3369	3146	3122	3122
q11	613	494	502	494
q12	757	603	604	603
q13	16848	2985	2998	2985
q14	317	283	269	269
q15	519	481	488	481
q16	462	411	426	411
q17	1818	1489	1451	1451
q18	7643	7535	7413	7413
q19	1691	1642	1635	1635
q20	1997	1834	1793	1793
q21	5114	5250	5083	5083
q22	1064	1024	989	989
Total cold run time: 71033 ms
Total hot run time: 54191 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185379 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit acf232dd1e9d218a43812c133edb6007c4a460eb, data reload: false

query1	909	388	373	373
query2	6452	1942	1855	1855
query3	6665	209	220	209
query4	34308	23257	23079	23079
query5	4273	489	518	489
query6	304	175	182	175
query7	4585	304	288	288
query8	236	200	192	192
query9	8484	2461	2418	2418
query10	434	260	257	257
query11	17697	14943	15038	14943
query12	157	98	94	94
query13	1635	369	373	369
query14	8585	7215	7069	7069
query15	241	169	170	169
query16	7708	491	477	477
query17	1570	569	555	555
query18	1927	289	292	289
query19	205	150	152	150
query20	111	106	109	106
query21	212	108	101	101
query22	4151	3975	3861	3861
query23	33878	33202	33322	33202
query24	12274	2923	2952	2923
query25	659	380	381	380
query26	1856	154	152	152
query27	3043	276	275	275
query28	7905	2038	2028	2028
query29	1158	396	388	388
query30	302	149	150	149
query31	984	742	764	742
query32	95	56	55	55
query33	783	292	280	280
query34	991	457	461	457
query35	836	736	714	714
query36	1088	953	929	929
query37	274	84	82	82
query38	3993	3812	3767	3767
query39	1442	1381	1405	1381
query40	271	116	116	116
query41	50	46	44	44
query42	121	99	99	99
query43	499	463	470	463
query44	1188	743	733	733
query45	199	162	166	162
query46	1117	746	761	746
query47	1835	1733	1762	1733
query48	373	286	286	286
query49	1195	423	447	423
query50	810	399	403	399
query51	6748	6789	6613	6613
query52	110	94	97	94
query53	262	189	191	189
query54	950	449	441	441
query55	77	78	76	76
query56	274	250	253	250
query57	1182	1067	1056	1056
query58	239	217	231	217
query59	2903	2720	2850	2720
query60	294	259	257	257
query61	99	95	111	95
query62	828	658	657	657
query63	217	186	184	184
query64	6295	2264	1718	1718
query65	3194	3162	3142	3142
query66	1379	336	334	334
query67	14994	14976	14846	14846
query68	6211	549	552	549
query69	607	380	286	286
query70	1142	1098	1122	1098
query71	540	276	268	268
query72	6515	2283	2070	2070
query73	814	317	314	314
query74	9206	8803	8755	8755
query75	4032	2654	2702	2654
query76	3747	1038	989	989
query77	653	329	324	324
query78	11211	9565	9742	9565
query79	7950	525	527	525
query80	809	508	504	504
query81	579	230	227	227
query82	597	145	137	137
query83	188	153	146	146
query84	275	74	84	74
query85	688	351	280	280
query86	428	269	297	269
query87	4327	4243	4164	4164
query88	4815	2322	2293	2293
query89	416	298	296	296
query90	1935	190	191	190
query91	120	96	93	93
query92	64	50	50	50
query93	4041	532	539	532
query94	770	282	296	282
query95	344	266	257	257
query96	612	266	268	266
query97	3165	3064	2979	2979
query98	216	209	198	198
query99	1729	1242	1230	1230
Total cold run time: 308859 ms
Total hot run time: 185379 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.91 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit acf232dd1e9d218a43812c133edb6007c4a460eb, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.08	0.08
query5	0.50	0.49	0.49
query6	1.12	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.54	0.48	0.48
query10	0.55	0.54	0.54
query11	0.16	0.11	0.11
query12	0.15	0.13	0.12
query13	0.61	0.61	0.59
query14	0.76	0.77	0.79
query15	0.85	0.82	0.81
query16	0.38	0.36	0.36
query17	1.00	1.03	0.99
query18	0.24	0.21	0.22
query19	1.78	1.79	1.76
query20	0.01	0.02	0.01
query21	15.41	0.75	0.65
query22	4.50	7.35	2.00
query23	18.28	1.33	1.26
query24	2.08	0.24	0.22
query25	0.15	0.08	0.09
query26	0.31	0.21	0.20
query27	0.46	0.23	0.23
query28	13.29	1.01	0.99
query29	12.65	3.38	3.35
query30	0.24	0.06	0.05
query31	2.90	0.39	0.40
query32	3.23	0.48	0.48
query33	2.99	2.96	2.98
query34	16.97	4.38	4.39
query35	4.40	4.41	4.40
query36	0.65	0.46	0.48
query37	0.18	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.03	0.03
query40	0.15	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.03	0.04
Total cold run time: 109.99 s
Total hot run time: 30.91 s

@morrySnow
Copy link
Contributor Author

run p0

@morrySnow
Copy link
Contributor Author

run cloud_p0

@morrySnow
Copy link
Contributor Author

run p0

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit ae27e92 into apache:master Aug 15, 2024
29 of 31 checks passed
@morrySnow morrySnow deleted the fix_delete_npe branch August 15, 2024 12:45
morrySnow added a commit that referenced this pull request Aug 15, 2024
@morrySnow
[fix](Nereids) npe when delete with cte and without using (#39379)
5051ab1 
pick from master #39379
@morrySnow morrySnow mentioned this pull request Aug 15, 2024
Merged
morrySnow added a commit that referenced this pull request Aug 16, 2024
@morrySnow
[fix](Nereids) npe when delete with cte and without using (#39379) (#…
ec0e413 
…39441)

pick from master #39379
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@morrySnow @dataroaring
[fix](Nereids) npe when delete with cte and without using (#39379)
da3b0bd
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged doing reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @doris-robot @starocean999 @feiniaofeiafei @dataroaring