-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](mtmv)use name instead of id in meta of MTMV #39355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 37874 ms
|
TPC-DS: Total hot run time: 190838 ms
|
ClickBench: Total hot run time: 31.92 s
|
run buildall |
TPC-H: Total hot run time: 38249 ms
|
morrySnow
reviewed
Aug 15, 2024
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVRefreshPartitionSnapshot.java
Outdated
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 38574 ms
|
TPC-DS: Total hot run time: 190582 ms
|
ClickBench: Total hot run time: 31.59 s
|
morrySnow
previously approved these changes
Aug 16, 2024
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 37955 ms
|
run buildall |
TPC-H: Total hot run time: 38319 ms
|
TPC-DS: Total hot run time: 190115 ms
|
ClickBench: Total hot run time: 31.05 s
|
run p0 |
run cloud_p1 |
run buildall |
run performance |
TPC-H: Total hot run time: 38107 ms
|
TPC-DS: Total hot run time: 191857 ms
|
ClickBench: Total hot run time: 30.72 s
|
morrySnow
approved these changes
Aug 21, 2024
zddr
added a commit
to zddr/incubator-doris
that referenced
this pull request
Aug 22, 2024
What is currently stored is the ID. When the catalog is rebuilt, the ID of the catalog will change, and an error will be reported when refreshing the materialized view. After the modification, the name is saved. compatibility: At startup, the appropriate name will be found based on the ID and saved. When retrieving a table, if the name is not saved, an attempt will be made to use the ID to retrieve the table
morrySnow
pushed a commit
that referenced
this pull request
Aug 23, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
What is currently stored is the ID. When the catalog is rebuilt, the ID of the catalog will change, and an error will be reported when refreshing the materialized view. After the modification, the name is saved. compatibility: At startup, the appropriate name will be found based on the ID and saved. When retrieving a table, if the name is not saved, an attempt will be made to use the ID to retrieve the table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.6-merged
dev/3.0.2-merged
doing
reviewed
usercase
Important user case type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is currently stored is the ID.
When the catalog is rebuilt, the ID of the catalog will change, and an error will be reported when refreshing the materialized view.
After the modification, the name is saved.
compatibility:
At startup, the appropriate name will be found based on the ID and saved.
When retrieving a table, if the name is not saved, an attempt will be made to use the ID to retrieve the table