[fix](sink) The issue with 2GB limit of protocol buffer (#37990) #39112
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
| RETURN_IF_ERROR(VExprContext::get_output_block_after_execute_exprs(_output_vexpr_ctxs, | ||
| input_block, &block)); | ||
| template <bool is_binary_format> | ||
| Status VMysqlResultWriter<is_binary_format>::_write_one_block(RuntimeState* state, Block& block) { |
There was a problem hiding this comment.
warning: function '_write_one_block' exceeds recommended size/complexity thresholds [readability-function-size]
Status VMysqlResultWriter<is_binary_format>::_write_one_block(RuntimeState* state, Block& block) {
^Additional context
be/src/vec/sink/vmysql_result_writer.cpp:148: 95 lines including whitespace and comments (threshold 80)
Status VMysqlResultWriter<is_binary_format>::_write_one_block(RuntimeState* state, Block& block) {
^``` Fail to serialize doris.PFetchDataResult ``` If the size of `PFetchDataResult` is greater than 2G, protocol buffer cannot serialize the message.
|
run buildall |
| RETURN_IF_ERROR(VExprContext::get_output_block_after_execute_exprs(_output_vexpr_ctxs, | ||
| input_block, &block)); | ||
| template <bool is_binary_format> | ||
| Status VMysqlResultWriter<is_binary_format>::_write_one_block(Block& block) { |
There was a problem hiding this comment.
warning: function '_write_one_block' exceeds recommended size/complexity thresholds [readability-function-size]
Status VMysqlResultWriter<is_binary_format>::_write_one_block(Block& block) {
^Additional context
be/src/vec/sink/vmysql_result_writer.cpp:148: 95 lines including whitespace and comments (threshold 80)
Status VMysqlResultWriter<is_binary_format>::_write_one_block(Block& block) {
^|
TeamCity be ut coverage result: |
If the size of
PFetchDataResultis greater than 2G, protocol buffer cannot serialize the message.pick #37990