Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[branch-2.1] Picks "[Fix](partial update) Persist partial_update_info in RocksDB in case of BE restart after a partial update has commited #38331" #39035

Merged
merged 3 commits into from
Aug 8, 2024
Merged

[branch-2.1] Picks "[Fix](partial update) Persist partial_update_info in RocksDB in case of BE restart after a partial update has commited #38331" #39035

merged 3 commits into from
Aug 8, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Aug 7, 2024 •
edited
Loading

picks #38331 and #39066

@bobhan1
update
1c24ac0 
tmp

tmp

tmp

tmp

finish

finish case

tmp

fix

fix complie

tmp

tmp

tmp

tmp

fix deserilize

fix compile
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1 bobhan1 mentioned this pull request Aug 7, 2024
Merged
@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 7, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/olap/partial_update_info.cpp

#include "olap/partial_update_info.h"

#include <gen_cpp/olap_file.pb.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/olap_file.pb.h' file not found [clang-diagnostic-error]

#include <gen_cpp/olap_file.pb.h>
         ^

be/src/olap/rowset/rowset_meta_manager.h
@@ -18,6 +18,8 @@
#ifndef DORIS_BE_SRC_OLAP_ROWSET_ROWSET_META_MANAGER_H
#define DORIS_BE_SRC_OLAP_ROWSET_ROWSET_META_MANAGER_H

#include <gen_cpp/olap_file.pb.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/olap_file.pb.h' file not found [clang-diagnostic-error]

#include <gen_cpp/olap_file.pb.h>
         ^

@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 8, 2024

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Aug 8, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.35% (9260/25474)
Line Coverage: 27.83% (75683/271927)
Region Coverage: 26.69% (38940/145896)
Branch Coverage: 23.41% (19756/84408)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e9fb588d6e843baefd45b38b1ad364f1d1e32e64_e9fb588d6e843baefd45b38b1ad364f1d1e32e64/report/index.html

@zhannngchen zhannngchen merged commit 1fbfb81 into apache:branch-2.1 Aug 8, 2024
19 of 21 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
meta-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobhan1 @doris-robot @zhannngchen