Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor](fix) Fix incorrect fmt arguments #38840

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the doing label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 41447 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c73445f34e591a795aa2bed087a71c12d5b782c1, data reload: false

------ Round 1 ----------------------------------
q1	17603	4116	4104	4104
q2	2028	197	192	192
q3	10625	1288	1354	1288
q4	10266	834	975	834
q5	7636	2987	2968	2968
q6	218	137	137	137
q7	1051	604	597	597
q8	9445	1896	1933	1896
q9	8560	6580	6652	6580
q10	8757	3881	3835	3835
q11	446	239	241	239
q12	405	221	219	219
q13	17758	2925	2946	2925
q14	271	243	237	237
q15	515	483	485	483
q16	526	382	382	382
q17	973	926	929	926
q18	8036	7321	7215	7215
q19	2349	1085	1234	1085
q20	584	323	337	323
q21	5416	4698	4706	4698
q22	356	296	284	284
Total cold run time: 113824 ms
Total hot run time: 41447 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4111	4001	4053	4001
q2	329	228	222	222
q3	3003	3016	3146	3016
q4	1991	2030	1967	1967
q5	5601	5488	5423	5423
q6	220	130	129	129
q7	2131	1791	1798	1791
q8	3352	3352	3343	3343
q9	8653	8646	8780	8646
q10	3899	4069	3885	3885
q11	549	447	446	446
q12	819	588	613	588
q13	16532	3113	3177	3113
q14	300	267	262	262
q15	539	481	507	481
q16	451	415	410	410
q17	1758	1764	1734	1734
q18	8156	7818	7644	7644
q19	1730	1733	1731	1731
q20	2045	1837	1865	1837
q21	5661	5440	5383	5383
q22	535	492	470	470
Total cold run time: 72365 ms
Total hot run time: 56522 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169504 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c73445f34e591a795aa2bed087a71c12d5b782c1, data reload: false

query1	910	369	377	369
query2	6341	1673	1659	1659
query3	6676	211	218	211
query4	19951	17637	17329	17329
query5	3634	512	513	512
query6	281	181	163	163
query7	4598	299	297	297
query8	251	193	188	188
query9	8507	2328	2329	2328
query10	420	280	283	280
query11	10606	10051	9902	9902
query12	126	93	91	91
query13	1632	385	389	385
query14	9916	7627	6762	6762
query15	207	160	168	160
query16	6664	461	463	461
query17	959	587	560	560
query18	1926	296	290	290
query19	195	146	154	146
query20	89	87	88	87
query21	209	97	98	97
query22	4307	4007	3912	3912
query23	33970	33869	33765	33765
query24	10405	3161	3110	3110
query25	713	431	429	429
query26	1851	153	154	153
query27	2943	301	299	299
query28	7499	1995	1970	1970
query29	1281	442	439	439
query30	256	158	161	158
query31	991	775	789	775
query32	104	57	58	57
query33	688	334	338	334
query34	911	492	497	492
query35	881	768	723	723
query36	984	859	881	859
query37	203	79	83	79
query38	2909	2742	2770	2742
query39	889	831	835	831
query40	253	115	119	115
query41	47	45	46	45
query42	122	102	99	99
query43	470	421	422	421
query44	1203	749	750	749
query45	218	182	184	182
query46	1075	844	795	795
query47	1814	1735	1752	1735
query48	367	305	302	302
query49	952	437	434	434
query50	897	436	442	436
query51	6686	6800	6679	6679
query52	104	95	90	90
query53	252	182	185	182
query54	623	464	459	459
query55	77	75	76	75
query56	287	258	353	258
query57	1163	1013	1059	1013
query58	272	259	271	259
query59	2532	2436	2293	2293
query60	308	269	277	269
query61	97	93	91	91
query62	917	668	650	650
query63	204	177	189	177
query64	5606	1907	1876	1876
query65	3168	3084	3106	3084
query66	1330	330	346	330
query67	15492	14818	14759	14759
query68	6804	592	595	592
query69	773	355	319	319
query70	1153	1059	1086	1059
query71	546	273	277	273
query72	8103	2651	2487	2487
query73	915	332	336	332
query74	6109	5681	5728	5681
query75	4593	2687	2722	2687
query76	4713	1232	1272	1232
query77	752	298	302	298
query78	9533	8897	8950	8897
query79	4255	528	531	528
query80	958	509	491	491
query81	554	223	230	223
query82	775	133	131	131
query83	330	172	167	167
query84	314	79	82	79
query85	1393	315	303	303
query86	426	315	284	284
query87	3342	3086	3084	3084
query88	4178	2523	2520	2520
query89	453	278	291	278
query90	2067	188	193	188
query91	122	96	101	96
query92	57	48	48	48
query93	4804	623	631	623
query94	922	290	277	277
query95	386	260	273	260
query96	628	294	284	284
query97	3194	3051	3077	3051
query98	228	244	199	199
query99	1590	1272	1292	1272
Total cold run time: 277389 ms
Total hot run time: 169504 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c73445f34e591a795aa2bed087a71c12d5b782c1, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.04	0.06
query4	1.66	0.08	0.08
query5	0.50	0.49	0.49
query6	1.13	0.71	0.71
query7	0.02	0.01	0.01
query8	0.06	0.04	0.05
query9	0.56	0.50	0.50
query10	0.55	0.56	0.55
query11	0.15	0.12	0.12
query12	0.14	0.12	0.12
query13	0.61	0.61	0.59
query14	0.78	0.78	0.80
query15	0.91	0.86	0.87
query16	0.36	0.35	0.36
query17	1.00	0.96	1.08
query18	0.22	0.21	0.21
query19	1.85	1.77	1.71
query20	0.01	0.01	0.01
query21	15.40	0.73	0.65
query22	3.92	8.14	1.19
query23	18.02	1.38	1.28
query24	2.28	0.21	0.21
query25	0.18	0.08	0.08
query26	0.32	0.21	0.21
query27	0.45	0.23	0.22
query28	13.20	0.99	0.97
query29	12.51	3.31	3.27
query30	0.25	0.06	0.06
query31	2.87	0.41	0.41
query32	3.23	0.48	0.48
query33	2.92	2.94	2.91
query34	15.43	4.25	4.27
query35	4.28	4.29	4.29
query36	0.69	0.47	0.49
query37	0.18	0.16	0.16
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.15	0.14	0.13
query41	0.10	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.05
Total cold run time: 107.52 s
Total hot run time: 29.77 s

@yiguolei yiguolei merged commit 06d3a97 into apache:master Aug 5, 2024
29 of 31 checks passed
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Aug 5, 2024
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Aug 7, 2024
## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
morningman pushed a commit to morningman/doris that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged doing reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants