[improvement](Nereids) add where Null rule to create empty relation as where false #38135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
morrySnow
reviewed
Jul 19, 2024
| @@ -43,12 +44,13 @@ public class EliminateFilter implements RewriteRuleFactory { | |||
| @Override | |||
| public List<Rule> buildRules() { | |||
| return ImmutableList.of(logicalFilter().when( | |||
| filter -> ExpressionUtils.containsType(filter.getConjuncts(), BooleanLiteral.class)) | |||
| filter -> ExpressionUtils.containsType(filter.getConjuncts(), BooleanLiteral.class) | |||
There was a problem hiding this comment.
add some java ut for this rule
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40106 ms |
TPC-DS: Total hot run time: 173479 ms |
ClickBench: Total hot run time: 31.07 s |
|
run buildall |
TPC-H: Total hot run time: 40099 ms |
TPC-DS: Total hot run time: 171875 ms |
ClickBench: Total hot run time: 31.14 s |
|
run buildall |
TPC-H: Total hot run time: 39821 ms |
TPC-DS: Total hot run time: 173618 ms |
|
run p0 |
ClickBench: Total hot run time: 31.15 s |
|
run External Regression |
1 similar comment
|
run External Regression |
|
run External |
|
./run external |
englefly
approved these changes
Jul 24, 2024
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Jul 25, 2024
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jul 25, 2024
…false (apache#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jul 25, 2024
…false (apache#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jul 31, 2024
…false (apache#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jul 31, 2024
…false (apache#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Jul 31, 2024
…false (apache#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
LiBinfeng-01
added a commit
to LiBinfeng-01/doris
that referenced
this pull request
Aug 2, 2024
…false (apache#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…false (#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…false (#38135) explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Aug 27, 2024
…false (apache#38135) (apache#38362) cherry-pick: apache#38135 explain shape plan select * from table2 where Null; explain shape plan select * from table2 where false; in this case, null literal can be regard as same as false literal ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explain shape plan select * from table2 where Null;
explain shape plan select * from table2 where false;
in this case, null literal can be regard as same as false literal