-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](insert-overwrite) Fix insert overwrite auto detect transaction safe #38103
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39646 ms
|
TPC-DS: Total hot run time: 173630 ms
|
ClickBench: Total hot run time: 30.99 s
|
ADD TEST ! |
run buildall |
TPC-H: Total hot run time: 39540 ms
|
TPC-DS: Total hot run time: 173961 ms
|
run buildall |
ClickBench: Total hot run time: 30.53 s
|
TPC-H: Total hot run time: 39896 ms
|
TPC-DS: Total hot run time: 173042 ms
|
ClickBench: Total hot run time: 30.59 s
|
fe/fe-core/src/main/java/org/apache/doris/insertoverwrite/InsertOverwriteManager.java
Outdated
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 39702 ms
|
TPC-DS: Total hot run time: 174107 ms
|
ClickBench: Total hot run time: 30.96 s
|
run buildall |
TPC-H: Total hot run time: 40143 ms
|
TPC-DS: Total hot run time: 173147 ms
|
ClickBench: Total hot run time: 30.87 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…safe (apache#38103) Before, if insert overwrite auto detect failed because of some transaction conflicts, it will go into an unexpected situation with some of the partition replace success but some retains. Now it will wholly success, or wholly failed.
…safe (#38103) Before, if insert overwrite auto detect failed because of some transaction conflicts, it will go into an unexpected situation with some of the partition replace success but some retains. Now it will wholly success, or wholly failed.
Proposed changes
Issue Number: close #xxx
Before, if insert overwrite auto detect failed because of some transaction conflicts, it will go into an unexpected situation with some of the partition replace success but some retains.
Now it will wholly success, or wholly failed.