[fix](load) fix memtable agg functions #38017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
reviewed
Jul 17, 2024
be/src/olap/memtable.cpp
Outdated
| @@ -187,7 +187,7 @@ Status MemTable::insert(const vectorized::Block* input_block, | |||
| _vec_row_comparator->set_block(&_input_mutable_block); | |||
| _output_mutable_block = vectorized::MutableBlock::build_mutable_block(&cloneBlock); | |||
| if (_keys_type != KeysType::DUP_KEYS) { | |||
| _init_agg_functions(input_block); | |||
| _init_agg_functions(&cloneBlock); | |||
There was a problem hiding this comment.
add comment here, to explain why cloned block not input block
liaoxin01
reviewed
Jul 17, 2024
be/src/olap/memtable.cpp
Outdated
| @@ -187,6 +187,8 @@ Status MemTable::insert(const vectorized::Block* input_block, | |||
| _vec_row_comparator->set_block(&_input_mutable_block); | |||
| _output_mutable_block = vectorized::MutableBlock::build_mutable_block(&cloneBlock); | |||
| if (_keys_type != KeysType::DUP_KEYS) { | |||
| // there may be additional intermediate columns in input_block | |||
| // we only need columns indicated by column offset in the output | |||
| _init_agg_functions(&cloneBlock); | |||
There was a problem hiding this comment.
cloneBlock -> clone_block
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40273 ms |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40176 ms |
yiguolei
approved these changes
Jul 17, 2024
TPC-DS: Total hot run time: 172571 ms |
ClickBench: Total hot run time: 30.97 s |
yiguolei
pushed a commit
that referenced
this pull request
Jul 17, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jul 18, 2024
## Proposed changes fix init agg functions in memtable.
dataroaring
pushed a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix init agg functions in memtable.