Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](function) fix mod function cause core dump #37999

Merged
merged 2 commits into from
Jul 20, 2024
Merged

[Bug](function) fix mod function cause core dump #37999

merged 2 commits into from
Jul 20, 2024

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

as (-9223372036854775808 % -1) will cause coredump directly by fpe,
so check this case and throw exception.

core-dump

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40042 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 115000104bf922c598cb82fc9d46c481d7f57a98, data reload: false

------ Round 1 ----------------------------------
q1	17632	4335	4270	4270
q2	2022	193	185	185
q3	10467	1184	1148	1148
q4	10365	853	785	785
q5	7542	2661	2585	2585
q6	220	139	138	138
q7	967	597	607	597
q8	9362	2097	2069	2069
q9	8744	6626	6643	6626
q10	8793	3792	3804	3792
q11	443	252	239	239
q12	399	223	225	223
q13	17822	3011	3031	3011
q14	279	234	237	234
q15	554	493	505	493
q16	521	379	384	379
q17	962	661	744	661
q18	7985	7506	7374	7374
q19	7959	1557	1472	1472
q20	694	331	349	331
q21	5027	3139	3269	3139
q22	354	291	292	291
Total cold run time: 119113 ms
Total hot run time: 40042 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4630	4434	4328	4328
q2	397	282	283	282
q3	3226	3070	3082	3070
q4	1985	1771	1759	1759
q5	5579	5581	5492	5492
q6	238	137	134	134
q7	2314	1883	1818	1818
q8	3302	3467	3424	3424
q9	8761	8891	8748	8748
q10	4098	3664	3865	3664
q11	607	499	498	498
q12	814	664	620	620
q13	17237	3142	3170	3142
q14	324	299	299	299
q15	531	502	503	502
q16	496	446	423	423
q17	1801	1490	1511	1490
q18	8245	7831	7771	7771
q19	1755	1460	1620	1460
q20	3117	1888	1903	1888
q21	14228	4875	4723	4723
q22	623	508	528	508
Total cold run time: 84308 ms
Total hot run time: 56043 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173509 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 115000104bf922c598cb82fc9d46c481d7f57a98, data reload: false

query1	906	373	371	371
query2	6474	1920	1813	1813
query3	6652	208	219	208
query4	24481	17759	17392	17392
query5	3630	498	478	478
query6	266	171	156	156
query7	4584	291	295	291
query8	228	191	188	188
query9	8451	2410	2407	2407
query10	457	273	254	254
query11	11457	10207	9983	9983
query12	117	82	82	82
query13	1636	354	357	354
query14	10236	7260	7714	7260
query15	210	169	167	167
query16	7588	318	318	318
query17	1345	563	539	539
query18	1809	289	286	286
query19	206	163	156	156
query20	91	86	83	83
query21	207	127	126	126
query22	4285	4185	3957	3957
query23	34035	33700	33580	33580
query24	12019	3004	3014	3004
query25	670	409	398	398
query26	1652	146	147	146
query27	2989	276	276	276
query28	7573	2060	2055	2055
query29	1048	670	647	647
query30	265	155	154	154
query31	973	757	766	757
query32	87	55	57	55
query33	749	304	285	285
query34	1026	492	495	492
query35	696	567	571	567
query36	1138	975	989	975
query37	157	84	87	84
query38	2991	2872	2828	2828
query39	897	839	874	839
query40	257	126	122	122
query41	45	47	47	47
query42	112	100	101	100
query43	510	471	457	457
query44	1205	727	736	727
query45	195	164	167	164
query46	1093	716	703	703
query47	1882	1759	1768	1759
query48	359	294	294	294
query49	910	407	426	407
query50	770	382	385	382
query51	6944	6895	6845	6845
query52	102	100	90	90
query53	356	282	289	282
query54	983	445	440	440
query55	76	74	73	73
query56	280	267	257	257
query57	1167	1041	1074	1041
query58	267	252	249	249
query59	2946	2537	2600	2537
query60	293	265	280	265
query61	97	95	94	94
query62	790	653	640	640
query63	319	287	288	287
query64	10381	2220	5958	2220
query65	3170	3122	3150	3122
query66	1228	338	332	332
query67	15459	15287	14978	14978
query68	5455	537	531	531
query69	681	421	329	329
query70	1166	1095	1113	1095
query71	488	281	273	273
query72	8520	5233	5595	5233
query73	759	325	324	324
query74	6163	5659	5718	5659
query75	4079	2771	2715	2715
query76	3656	952	948	948
query77	632	302	303	302
query78	9688	9034	8995	8995
query79	3407	528	525	525
query80	1930	477	488	477
query81	593	222	224	222
query82	1495	137	143	137
query83	351	173	176	173
query84	273	88	92	88
query85	1477	328	336	328
query86	420	315	319	315
query87	3293	3131	3075	3075
query88	4654	2392	2390	2390
query89	505	394	382	382
query90	1946	192	254	192
query91	134	97	102	97
query92	62	49	48	48
query93	4634	507	498	498
query94	1282	215	226	215
query95	409	319	314	314
query96	616	274	270	270
query97	3172	3012	3048	3012
query98	228	197	197	197
query99	1547	1225	1251	1225
Total cold run time: 290192 ms
Total hot run time: 173509 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.5 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 115000104bf922c598cb82fc9d46c481d7f57a98, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.06	0.06
query4	1.66	0.08	0.10
query5	0.50	0.49	0.47
query6	1.15	0.75	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.50	0.49
query10	0.56	0.55	0.56
query11	0.15	0.12	0.12
query12	0.15	0.13	0.12
query13	0.59	0.59	0.58
query14	0.76	0.78	0.81
query15	0.86	0.81	0.82
query16	0.35	0.37	0.36
query17	1.00	1.02	1.00
query18	0.24	0.21	0.21
query19	1.76	1.74	1.70
query20	0.01	0.00	0.01
query21	15.41	0.74	0.65
query22	3.53	8.57	1.71
query23	18.28	1.37	1.27
query24	2.19	0.23	0.22
query25	0.15	0.08	0.09
query26	0.30	0.21	0.21
query27	0.46	0.23	0.22
query28	13.30	1.03	1.01
query29	12.57	3.32	3.27
query30	0.25	0.06	0.06
query31	2.87	0.38	0.38
query32	3.26	0.48	0.47
query33	2.89	2.92	2.95
query34	17.07	4.41	4.42
query35	4.48	4.41	4.39
query36	0.65	0.47	0.48
query37	0.19	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.03	0.04
query40	0.16	0.13	0.12
query41	0.10	0.05	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.1 s
Total hot run time: 30.5 s

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40210 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08a37844208a2f24a631d9f44743c6f959969e45, data reload: false

------ Round 1 ----------------------------------
q1	17604	4447	4294	4294
q2	2029	197	208	197
q3	10423	1248	1123	1123
q4	10192	782	846	782
q5	7542	2756	2714	2714
q6	221	136	136	136
q7	981	607	611	607
q8	9220	2137	2153	2137
q9	8698	6618	6629	6618
q10	8812	3814	3855	3814
q11	459	254	252	252
q12	402	220	234	220
q13	18843	2988	2960	2960
q14	278	236	237	236
q15	530	489	472	472
q16	486	386	378	378
q17	989	640	649	640
q18	8102	7552	7366	7366
q19	7413	1416	1454	1416
q20	683	322	349	322
q21	5053	3247	3394	3247
q22	352	295	279	279
Total cold run time: 119312 ms
Total hot run time: 40210 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4423	4251	4274	4251
q2	385	284	280	280
q3	3162	2939	2991	2939
q4	2020	1774	1696	1696
q5	5541	5476	5559	5476
q6	245	139	135	135
q7	2237	1840	1842	1840
q8	3353	3450	3446	3446
q9	8772	8959	8784	8784
q10	4103	3746	3914	3746
q11	589	529	507	507
q12	832	638	667	638
q13	15923	3170	3227	3170
q14	314	297	315	297
q15	539	507	481	481
q16	491	431	455	431
q17	1813	1509	1499	1499
q18	8204	8057	7970	7970
q19	1796	1594	1673	1594
q20	2184	1895	1847	1847
q21	10656	4754	4830	4754
q22	609	528	513	513
Total cold run time: 78191 ms
Total hot run time: 56294 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 176017 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08a37844208a2f24a631d9f44743c6f959969e45, data reload: false

query1	918	384	374	374
query2	6451	1904	1846	1846
query3	6635	208	221	208
query4	25574	17552	17430	17430
query5	3768	485	527	485
query6	271	175	176	175
query7	4587	294	289	289
query8	235	199	199	199
query9	8511	2511	2476	2476
query10	418	278	284	278
query11	11402	10249	10172	10172
query12	115	85	89	85
query13	1639	362	366	362
query14	10234	7982	7834	7834
query15	221	170	171	170
query16	7180	316	307	307
query17	1361	584	543	543
query18	1693	276	293	276
query19	201	150	149	149
query20	88	84	80	80
query21	212	132	127	127
query22	4408	4005	3970	3970
query23	34075	33974	33615	33615
query24	10247	2940	2922	2922
query25	600	429	394	394
query26	708	156	164	156
query27	2369	287	290	287
query28	5969	2132	2118	2118
query29	912	669	681	669
query30	255	182	158	158
query31	965	782	750	750
query32	98	58	57	57
query33	651	296	310	296
query34	895	514	491	491
query35	722	583	626	583
query36	1165	1019	983	983
query37	144	87	89	87
query38	2968	2881	2807	2807
query39	862	838	811	811
query40	193	119	120	119
query41	48	47	43	43
query42	119	107	104	104
query43	498	461	470	461
query44	1092	740	738	738
query45	204	171	165	165
query46	1106	777	770	770
query47	1882	1792	1781	1781
query48	378	301	300	300
query49	846	430	442	430
query50	801	395	397	395
query51	6866	6783	6834	6783
query52	112	94	99	94
query53	369	301	301	301
query54	877	471	459	459
query55	75	76	75	75
query56	302	286	299	286
query57	1130	1074	1067	1067
query58	252	262	258	258
query59	2870	2544	2546	2544
query60	331	295	308	295
query61	121	133	115	115
query62	790	657	655	655
query63	322	294	298	294
query64	9255	2339	7628	2339
query65	3176	3087	3150	3087
query66	766	342	358	342
query67	15821	14958	15204	14958
query68	6166	552	555	552
query69	727	429	377	377
query70	1263	1146	1148	1146
query71	472	308	286	286
query72	8949	5719	5865	5719
query73	766	327	324	324
query74	6235	5743	5639	5639
query75	4103	2713	2745	2713
query76	3653	967	966	966
query77	716	307	303	303
query78	11472	9429	9547	9429
query79	9093	542	546	542
query80	2272	486	495	486
query81	588	235	220	220
query82	571	140	135	135
query83	289	165	167	165
query84	268	86	85	85
query85	710	309	302	302
query86	459	311	288	288
query87	3333	3122	3117	3117
query88	4378	2404	2420	2404
query89	507	399	387	387
query90	2072	196	200	196
query91	132	97	100	97
query92	63	49	48	48
query93	5156	509	513	509
query94	1268	215	218	215
query95	421	321	325	321
query96	614	276	272	272
query97	3234	3071	3052	3052
query98	225	204	200	200
query99	1519	1255	1245	1245
Total cold run time: 292023 ms
Total hot run time: 176017 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08a37844208a2f24a631d9f44743c6f959969e45, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.07
query5	0.50	0.49	0.50
query6	1.14	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.48
query10	0.56	0.55	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.59
query14	0.75	0.79	0.77
query15	0.86	0.81	0.82
query16	0.37	0.36	0.36
query17	1.04	1.02	0.96
query18	0.24	0.22	0.22
query19	1.76	1.78	1.73
query20	0.01	0.01	0.00
query21	15.39	0.75	0.67
query22	4.30	8.03	1.28
query23	18.29	1.35	1.31
query24	2.03	0.27	0.22
query25	0.16	0.10	0.09
query26	0.29	0.21	0.22
query27	0.45	0.23	0.23
query28	13.25	1.00	0.99
query29	12.56	3.42	3.46
query30	0.26	0.06	0.06
query31	2.86	0.41	0.39
query32	3.26	0.49	0.48
query33	2.93	2.87	2.94
query34	17.23	4.32	4.33
query35	4.40	4.44	4.48
query36	0.65	0.46	0.48
query37	0.19	0.15	0.15
query38	0.15	0.14	0.14
query39	0.04	0.04	0.03
query40	0.15	0.12	0.12
query41	0.10	0.05	0.06
query42	0.06	0.05	0.05
query43	0.05	0.05	0.04
Total cold run time: 109.8 s
Total hot run time: 30.15 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 287f5ca into apache:master Jul 20, 2024
26 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Jul 22, 2024
@zhangstar333 @dataroaring
[Bug](function) fix mod function cause core dump (#37999)
e789bf2 
## Proposed changes

as (-9223372036854775808 % -1) will cause coredump directly by fpe, 
so check this case and throw exception.


![core-dump](https://github.com/user-attachments/assets/fc68d707-4582-4098-9714-4fe3958cd8a2)

<!--Describe your changes.-->
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Jul 24, 2024
@zhangstar333
[Bug](function) fix mod function cause core dump (apache#37999)
d0c9290 
## Proposed changes

as (-9223372036854775808 % -1) will cause coredump directly by fpe, 
so check this case and throw exception.


![core-dump](https://github.com/user-attachments/assets/fc68d707-4582-4098-9714-4fe3958cd8a2)

<!--Describe your changes.-->
@zhangstar333 zhangstar333 mentioned this pull request Jul 24, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 25, 2024
@zhangstar333
[cherry-pick](branch-21) fix mod function cause core dump (#37999) (#…
e9052e2 
…38308)

## Proposed changes
cherry-pick from master #37999

<!--Describe your changes.-->

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@Mryange Mryange Mryange approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangstar333 @doris-robot @yiguolei @Mryange @HappenLee @dataroaring