Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](bug) fix the divide zero in local shuffle #37906

Merged
merged 1 commit into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion be/src/pipeline/pipeline_fragment_context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -884,8 +884,12 @@ Status PipelineFragmentContext::_plan_local_exchange(
}
}

// if 'num_buckets == 0' means the fragment is colocated by exchange node not the
// scan node. so here use `_num_instance` to replace the `num_buckets` to prevent dividing 0
// still keep colocate plan after local shuffle
RETURN_IF_ERROR(_plan_local_exchange(
_pipelines[pip_idx]->operator_xs().front()->ignore_data_hash_distribution()
_pipelines[pip_idx]->operator_xs().front()->ignore_data_hash_distribution() ||
num_buckets == 0
? _num_instances
: num_buckets,
pip_idx, _pipelines[pip_idx], bucket_seq_to_instance_idx,
Expand Down
52 changes: 52 additions & 0 deletions regression-test/data/query_p0/limit/sql/withGroupByUnion.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !withGroupByUnion --
0 ALGERIA
1 ALGERIA
1 ARGENTINA
1 BRAZIL
1 CANADA
1 CHINA
1 EGYPT
1 ETHIOPIA
1 FRANCE
1 GERMANY
1 INDIA
1 INDONESIA
1 IRAN
1 IRAQ
1 JAPAN
1 JORDAN
1 KENYA
1 MOROCCO
1 MOZAMBIQUE
1 PERU
1 ROMANIA
1 RUSSIA
1 SAUDI ARABIA
1 UNITED KINGDOM
1 UNITED STATES
1 VIETNAM
2 BRAZIL
3 CANADA
4 EGYPT
5 ETHIOPIA
6 FRANCE
7 GERMANY
8 INDIA
9 INDONESIA
10 IRAN
11 IRAQ
12 JAPAN
13 JORDAN
14 KENYA
15 MOROCCO
16 MOZAMBIQUE
17 PERU
18 CHINA
19 ROMANIA
20 SAUDI ARABIA
21 VIETNAM
22 RUSSIA
23 UNITED KINGDOM
24 UNITED STATES

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
select * from (select count(a.nationkey), a.name from tpch_tiny_nation a join[shuffle] tpch_tiny_nation b on a.name = b.name group by a.name union select sum(c.nationkey), c.name from tpch_tiny_nation c join[shuffle] tpch_tiny_nation d on c.name = d.name group by c.name) t order by 1,2 limit 50;
Loading