-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](function) fix FE impl of some time functions #37746
Conversation
run buildall |
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
TPC-H: Total hot run time: 39784 ms
|
TPC-DS: Total hot run time: 172531 ms
|
ClickBench: Total hot run time: 30.84 s
|
run buildall |
653aba3
to
60e32e4
Compare
run buildall |
TPC-H: Total hot run time: 39811 ms
|
TPC-DS: Total hot run time: 173924 ms
|
ClickBench: Total hot run time: 31.25 s
|
60e32e4
to
68a6637
Compare
run buildall |
68a6637
to
a6c39c9
Compare
run buildall |
TPC-H: Total hot run time: 39977 ms
|
TPC-DS: Total hot run time: 173372 ms
|
ClickBench: Total hot run time: 30.97 s
|
a6c39c9
to
8dc60dd
Compare
run buildall |
TPC-H: Total hot run time: 39910 ms
|
TPC-DS: Total hot run time: 172794 ms
|
ClickBench: Total hot run time: 30.9 s
|
8dc60dd
to
5693cb4
Compare
run buildall |
TPC-H: Total hot run time: 39588 ms
|
TPC-DS: Total hot run time: 174985 ms
|
ClickBench: Total hot run time: 32.29 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not remove convert_tz in fe. In order to make constant folding and partition prune work. we have to implement this function in correct way in fe.
5693cb4
to
e4712db
Compare
run buildall |
66b2678
to
ac0989d
Compare
run buildall |
TPC-H: Total hot run time: 39779 ms
|
TPC-DS: Total hot run time: 174397 ms
|
ClickBench: Total hot run time: 30.6 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
before: ```sql mysql> select date_ceil("2020-12-12 12:12:12.123", interval 2 second); +-----------------------+ | '2020-12-12 12:12:12' | +-----------------------+ | 2020-12-12 12:12:12 | +-----------------------+ 1 row in set (0.10 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/Galapagos'); +------+ | NULL | +------+ | NULL | +------+ 1 row in set (0.09 sec) mysql [(none)]>select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/GalapaGoS'); +-----------------------------------------------------------------------------------------------------------+ | convert_tz(cast('9999-12-31 23:59:59.999999' as DATETIMEV2(6)), 'Pacific/Galapagos', 'Pacific/GalapaGoS') | +-----------------------------------------------------------------------------------------------------------+ | 9999-12-31 23:59:59.999999 | +-----------------------------------------------------------------------------------------------------------+ 1 row in set (0.08 sec) --- gone to BE ``` after: ```sql mysql> select date_ceil("2020-12-12 12:12:12.123", interval 2 second); +------------------------------+ | '2020-12-12 12:12:14.000000' | +------------------------------+ | 2020-12-12 12:12:14 | +------------------------------+ 1 row in set (0.11 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/Galapagos'); +-----------------------------------------------------------------------------------------------------------+ | convert_tz(cast('9999-12-31 23:59:59.999999' as DATETIMEV2(6)), 'Pacific/Galapagos', 'Pacific/Galapagos') | +-----------------------------------------------------------------------------------------------------------+ | 9999-12-31 23:59:59.999999 | +-----------------------------------------------------------------------------------------------------------+ 1 row in set (0.23 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/GalapaGoS'); +------------------------------+ | '9999-12-31 23:59:59.999999' | +------------------------------+ | 9999-12-31 23:59:59.999999 | +------------------------------+ 1 row in set (0.11 sec) --- finished in FE ```
before: ```sql mysql> select date_ceil("2020-12-12 12:12:12.123", interval 2 second); +-----------------------+ | '2020-12-12 12:12:12' | +-----------------------+ | 2020-12-12 12:12:12 | +-----------------------+ 1 row in set (0.10 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/Galapagos'); +------+ | NULL | +------+ | NULL | +------+ 1 row in set (0.09 sec) mysql [(none)]>select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/GalapaGoS'); +-----------------------------------------------------------------------------------------------------------+ | convert_tz(cast('9999-12-31 23:59:59.999999' as DATETIMEV2(6)), 'Pacific/Galapagos', 'Pacific/GalapaGoS') | +-----------------------------------------------------------------------------------------------------------+ | 9999-12-31 23:59:59.999999 | +-----------------------------------------------------------------------------------------------------------+ 1 row in set (0.08 sec) --- gone to BE ``` after: ```sql mysql> select date_ceil("2020-12-12 12:12:12.123", interval 2 second); +------------------------------+ | '2020-12-12 12:12:14.000000' | +------------------------------+ | 2020-12-12 12:12:14 | +------------------------------+ 1 row in set (0.11 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/Galapagos'); +-----------------------------------------------------------------------------------------------------------+ | convert_tz(cast('9999-12-31 23:59:59.999999' as DATETIMEV2(6)), 'Pacific/Galapagos', 'Pacific/Galapagos') | +-----------------------------------------------------------------------------------------------------------+ | 9999-12-31 23:59:59.999999 | +-----------------------------------------------------------------------------------------------------------+ 1 row in set (0.23 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/GalapaGoS'); +------------------------------+ | '9999-12-31 23:59:59.999999' | +------------------------------+ | 9999-12-31 23:59:59.999999 | +------------------------------+ 1 row in set (0.11 sec) --- finished in FE ```
…38316) pick #37746 before: ```sql mysql> select date_ceil("2020-12-12 12:12:12.123", interval 2 second); +-----------------------+ | '2020-12-12 12:12:12' | +-----------------------+ | 2020-12-12 12:12:12 | +-----------------------+ 1 row in set (0.10 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/Galapagos'); +------+ | NULL | +------+ | NULL | +------+ 1 row in set (0.09 sec) mysql [(none)]>select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/GalapaGoS'); +-----------------------------------------------------------------------------------------------------------+ | convert_tz(cast('9999-12-31 23:59:59.999999' as DATETIMEV2(6)), 'Pacific/Galapagos', 'Pacific/GalapaGoS') | +-----------------------------------------------------------------------------------------------------------+ | 9999-12-31 23:59:59.999999 | +-----------------------------------------------------------------------------------------------------------+ 1 row in set (0.08 sec) --- gone to BE ``` after: ```sql mysql> select date_ceil("2020-12-12 12:12:12.123", interval 2 second); +------------------------------+ | '2020-12-12 12:12:14.000000' | +------------------------------+ | 2020-12-12 12:12:14 | +------------------------------+ 1 row in set (0.11 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/Galapagos'); +-----------------------------------------------------------------------------------------------------------+ | convert_tz(cast('9999-12-31 23:59:59.999999' as DATETIMEV2(6)), 'Pacific/Galapagos', 'Pacific/Galapagos') | +-----------------------------------------------------------------------------------------------------------+ | 9999-12-31 23:59:59.999999 | +-----------------------------------------------------------------------------------------------------------+ 1 row in set (0.23 sec) mysql> select CONVERT_TZ('9999-12-31 23:59:59.999999', 'Pacific/Galapagos', 'Pacific/GalapaGoS'); +------------------------------+ | '9999-12-31 23:59:59.999999' | +------------------------------+ | 9999-12-31 23:59:59.999999 | +------------------------------+ 1 row in set (0.11 sec) --- finished in FE ```
Proposed changes
Issue Number: close #xxx
before:
after: