Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](compaction) optimizing memory usage for compaction (#37099) #37486

Merged
merged 5 commits into from
Aug 4, 2024
Merged

[enhancement](compaction) optimizing memory usage for compaction (#37099) #37486

merged 5 commits into from
Aug 4, 2024

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented Jul 8, 2024 •
edited by dataroaring
Loading

pick #37099

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions[bot]
github-actions bot reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/olap/base_compaction_test.cpp
// specific language governing permissions and limitations
// under the License.

#include "olap/base_compaction.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'olap/base_compaction.h' file not found [clang-diagnostic-error]

#include "olap/base_compaction.h"
         ^

@dataroaring
Copy link
Contributor

run buildall

@luwei16
Copy link
Contributor Author

luwei16 commented Jul 9, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.36% (9164/25201)
Line Coverage: 27.91% (74884/268333)
Region Coverage: 26.82% (38664/144144)
Branch Coverage: 23.51% (19597/83348)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7d8fff8c5fdffbcf308bfeb77c5b0c38de47a13d_7d8fff8c5fdffbcf308bfeb77c5b0c38de47a13d/report/index.html

@luwei16
Copy link
Contributor Author

luwei16 commented Jul 13, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.63% (9281/25336)
Line Coverage: 28.16% (75960/269781)
Region Coverage: 26.98% (39053/144761)
Branch Coverage: 23.68% (19833/83746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9edf23fa4c7129f3b3f3a49bf0041513df84b22b_9edf23fa4c7129f3b3f3a49bf0041513df84b22b/report/index.html

@dataroaring
Copy link
Contributor

pending for a while to test.

@dataroaring dataroaring merged commit 0603ec1 into apache:branch-2.1 Aug 4, 2024
19 of 21 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luwei16 @doris-robot @dataroaring