Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](array)fix array with empty arg in be behavior #36845

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[fix](array)fix array with empty arg in be behavior #36845

merged 1 commit into from
Jun 26, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

be behavior with empty arg for array construct func , will make be core
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@amorynan amorynan changed the title [FIX](array)fix array with empty arg in be behavior [fix](array)fix array with empty arg in be behavior Jun 26, 2024
@amorynan
Copy link
Contributor Author

run buildall

HappenLee
HappenLee approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39882 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4b5fd5aac5c59a56fe75256437191cc50e68c1e9, data reload: false

------ Round 1 ----------------------------------
q1	18070	4396	4432	4396
q2	2497	190	194	190
q3	11135	1088	1011	1011
q4	10544	815	850	815
q5	7812	2670	2691	2670
q6	227	135	136	135
q7	955	608	627	608
q8	9878	2084	2073	2073
q9	8878	6514	6459	6459
q10	8950	3751	3709	3709
q11	482	242	241	241
q12	410	235	228	228
q13	17795	2986	2986	2986
q14	252	227	214	214
q15	503	487	473	473
q16	520	380	376	376
q17	956	708	738	708
q18	8140	7383	7400	7383
q19	2883	1418	1399	1399
q20	642	324	316	316
q21	4859	3144	3973	3144
q22	407	348	353	348
Total cold run time: 116795 ms
Total hot run time: 39882 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4383	4258	4186	4186
q2	366	269	268	268
q3	2926	2758	2715	2715
q4	1869	1609	1553	1553
q5	5235	5285	5283	5283
q6	224	130	129	129
q7	2114	1722	1674	1674
q8	3194	3348	3322	3322
q9	8331	8227	8327	8227
q10	3874	3699	3674	3674
q11	605	493	499	493
q12	799	576	618	576
q13	17592	2945	2987	2945
q14	287	277	261	261
q15	526	476	498	476
q16	478	413	417	413
q17	1773	1462	1469	1462
q18	7640	7467	7482	7467
q19	1720	1562	1686	1562
q20	1990	1785	1772	1772
q21	4795	4768	4751	4751
q22	624	539	551	539
Total cold run time: 71345 ms
Total hot run time: 53748 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172772 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4b5fd5aac5c59a56fe75256437191cc50e68c1e9, data reload: false

query1	911	357	364	357
query2	6430	2476	2369	2369
query3	6637	208	209	208
query4	19062	17312	17447	17312
query5	4146	453	453	453
query6	249	162	169	162
query7	4589	297	297	297
query8	308	293	294	293
query9	8589	2464	2454	2454
query10	600	286	269	269
query11	10628	9958	10049	9958
query12	129	92	85	85
query13	1643	379	369	369
query14	9564	6875	7498	6875
query15	241	195	189	189
query16	7849	264	270	264
query17	1799	523	524	523
query18	1949	272	279	272
query19	210	151	157	151
query20	90	79	85	79
query21	214	126	121	121
query22	4433	4065	3972	3972
query23	33788	32989	33242	32989
query24	12011	2799	2905	2799
query25	670	367	357	357
query26	1821	158	161	158
query27	2987	314	313	313
query28	7690	2107	2097	2097
query29	1134	634	631	631
query30	296	151	149	149
query31	938	724	742	724
query32	95	55	59	55
query33	777	286	285	285
query34	960	467	478	467
query35	737	630	618	618
query36	1082	931	920	920
query37	192	73	71	71
query38	2857	2712	2713	2712
query39	853	783	801	783
query40	277	129	123	123
query41	54	55	53	53
query42	116	99	101	99
query43	591	568	546	546
query44	1199	735	748	735
query45	187	162	159	159
query46	1082	717	696	696
query47	1884	1753	1777	1753
query48	378	309	299	299
query49	1182	415	410	410
query50	763	385	390	385
query51	6826	6760	6828	6760
query52	115	94	96	94
query53	366	298	297	297
query54	1066	466	456	456
query55	77	77	75	75
query56	346	269	272	269
query57	1122	1071	1041	1041
query58	255	263	270	263
query59	3683	3263	3140	3140
query60	299	273	279	273
query61	96	92	90	90
query62	655	453	442	442
query63	322	300	290	290
query64	9880	2281	1748	1748
query65	3184	3120	3112	3112
query66	1393	340	331	331
query67	15656	14787	15252	14787
query68	4605	547	539	539
query69	451	301	306	301
query70	1132	1159	1146	1146
query71	405	274	274	274
query72	6966	5500	5618	5500
query73	762	331	332	331
query74	5925	5480	5429	5429
query75	3448	2623	2729	2623
query76	2631	1019	954	954
query77	425	302	289	289
query78	10361	9907	9714	9714
query79	2565	523	513	513
query80	921	467	468	467
query81	561	219	218	218
query82	747	106	99	99
query83	269	167	172	167
query84	238	88	90	88
query85	1728	340	274	274
query86	480	297	306	297
query87	3215	3104	3085	3085
query88	4217	2487	2492	2487
query89	481	388	388	388
query90	1806	197	190	190
query91	130	103	105	103
query92	71	49	50	49
query93	2052	504	499	499
query94	1222	194	190	190
query95	414	324	316	316
query96	592	271	271	271
query97	3264	3036	3039	3036
query98	231	198	195	195
query99	1235	863	854	854
Total cold run time: 275762 ms
Total hot run time: 172772 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4b5fd5aac5c59a56fe75256437191cc50e68c1e9, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.21	0.05	0.05
query4	1.68	0.09	0.10
query5	0.51	0.49	0.50
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.49
query10	0.55	0.54	0.55
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.59	0.59	0.59
query14	0.75	0.79	0.78
query15	0.82	0.80	0.82
query16	0.38	0.37	0.37
query17	1.04	1.05	0.97
query18	0.23	0.26	0.21
query19	1.80	1.69	1.75
query20	0.02	0.01	0.01
query21	15.46	0.67	0.66
query22	4.29	7.34	1.86
query23	18.24	1.35	1.24
query24	2.08	0.23	0.22
query25	0.16	0.09	0.08
query26	0.27	0.17	0.18
query27	0.08	0.08	0.08
query28	13.30	1.03	1.00
query29	12.61	3.30	3.31
query30	0.25	0.06	0.05
query31	2.86	0.39	0.37
query32	3.31	0.46	0.48
query33	2.92	2.88	2.97
query34	17.10	4.41	4.45
query35	4.49	4.55	4.52
query36	0.65	0.48	0.47
query37	0.18	0.14	0.15
query38	0.15	0.14	0.14
query39	0.04	0.03	0.03
query40	0.17	0.17	0.14
query41	0.09	0.05	0.05
query42	0.06	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 109.53 s
Total hot run time: 30.49 s

@HappenLee HappenLee merged commit f0b7422 into apache:master Jun 26, 2024
27 of 31 checks passed
dataroaring pushed a commit that referenced this pull request Jun 28, 2024
@amorynan @dataroaring
[fix](array)fix array with empty arg in be behavior (#36845)
1efbb90
@amorynan
Copy link
Contributor Author

amorynan commented Aug 1, 2024

branch2.0 is not need to merge this pr, it just for neredis

@amorynan amorynan mentioned this pull request Aug 1, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 5, 2024
@amorynan
[pick](array-funcs)fix array with empty arg in be behavior (#38708)
2653087 
## Proposed changes
backport: #36845
Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amorynan @doris-robot @HappenLee @zhiqiang-hhhh @xiaokang @yiguolei @dataroaring