Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](inverted index) remove duplicate stats of inverted_index_query_cache_miss #36707

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[Fix](inverted index) remove duplicate stats of inverted_index_query_cache_miss #36707

merged 1 commit into from
Jun 24, 2024

Conversation

airborne12
Copy link
Member

Proposed changes

inverted_index_query_cache_miss is already processed in handle_query_cache function

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@airborne12
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39974 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit de8f38ae9e8b5061fd5cfffd813025ee72b019a7, data reload: false

------ Round 1 ----------------------------------
q1	17632	4695	4263	4263
q2	2029	195	201	195
q3	10517	1205	1123	1123
q4	10259	770	710	710
q5	7477	2727	2722	2722
q6	227	134	134	134
q7	952	613	590	590
q8	9235	2062	2082	2062
q9	9038	6514	6493	6493
q10	8956	3722	3701	3701
q11	441	247	234	234
q12	407	231	232	231
q13	17762	2999	2982	2982
q14	273	218	237	218
q15	513	498	485	485
q16	514	382	384	382
q17	973	694	660	660
q18	8010	7599	7410	7410
q19	4950	1516	1459	1459
q20	727	333	351	333
q21	5067	3243	4057	3243
q22	401	348	344	344
Total cold run time: 116360 ms
Total hot run time: 39974 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4334	4228	4274	4228
q2	373	275	264	264
q3	2969	2978	2898	2898
q4	1991	1709	1722	1709
q5	5708	5484	5451	5451
q6	237	128	130	128
q7	2198	1891	1861	1861
q8	3294	3434	3427	3427
q9	8739	8758	8776	8758
q10	4126	3804	3796	3796
q11	595	531	531	531
q12	814	646	651	646
q13	17126	3165	3174	3165
q14	315	275	299	275
q15	510	481	483	481
q16	516	468	454	454
q17	1819	1507	1493	1493
q18	8114	7925	7758	7758
q19	3485	1663	1689	1663
q20	2119	1893	1877	1877
q21	5231	4883	4779	4779
q22	635	561	560	560
Total cold run time: 75248 ms
Total hot run time: 56202 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 175219 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit de8f38ae9e8b5061fd5cfffd813025ee72b019a7, data reload: false

query1	909	385	379	379
query2	6451	2503	2425	2425
query3	6630	215	219	215
query4	19449	17422	17417	17417
query5	3539	479	475	475
query6	236	166	181	166
query7	4582	306	295	295
query8	312	299	287	287
query9	8416	2405	2360	2360
query10	563	316	288	288
query11	10414	10021	10080	10021
query12	120	91	87	87
query13	1638	381	367	367
query14	10154	7537	7867	7537
query15	238	188	193	188
query16	7531	275	263	263
query17	1902	537	527	527
query18	1587	284	274	274
query19	200	154	152	152
query20	95	81	82	81
query21	208	132	126	126
query22	4322	4092	3972	3972
query23	33957	33806	33789	33789
query24	10961	2952	3008	2952
query25	626	390	360	360
query26	1103	163	168	163
query27	2859	345	326	326
query28	7320	2159	2139	2139
query29	901	646	632	632
query30	260	155	155	155
query31	960	780	780	780
query32	89	58	55	55
query33	737	294	311	294
query34	1023	483	472	472
query35	753	654	641	641
query36	1123	969	971	969
query37	167	81	76	76
query38	2978	2821	2846	2821
query39	874	862	845	845
query40	214	164	127	127
query41	58	51	53	51
query42	112	106	109	106
query43	608	593	573	573
query44	1212	741	748	741
query45	199	165	166	165
query46	1083	727	755	727
query47	1858	1738	1792	1738
query48	384	300	300	300
query49	843	401	415	401
query50	778	408	409	408
query51	6951	6887	6762	6762
query52	106	99	92	92
query53	366	291	285	285
query54	887	462	438	438
query55	76	76	73	73
query56	289	274	264	264
query57	1115	1091	1038	1038
query58	261	264	255	255
query59	3619	3298	3061	3061
query60	298	281	290	281
query61	118	131	88	88
query62	613	436	445	436
query63	321	300	284	284
query64	8815	2240	1777	1777
query65	3195	3089	3121	3089
query66	843	320	332	320
query67	15542	15453	14764	14764
query68	4455	540	555	540
query69	448	309	316	309
query70	1232	1159	1166	1159
query71	402	278	289	278
query72	7246	5936	5649	5649
query73	741	336	333	333
query74	5972	5530	5454	5454
query75	3389	2666	2715	2666
query76	2466	1033	997	997
query77	456	318	302	302
query78	10409	9775	9775	9775
query79	2733	515	533	515
query80	1191	476	469	469
query81	599	221	222	221
query82	805	105	106	105
query83	239	178	169	169
query84	249	87	88	87
query85	1449	301	271	271
query86	470	312	304	304
query87	3282	3045	3136	3045
query88	3752	2470	2467	2467
query89	490	381	389	381
query90	1681	194	193	193
query91	135	104	102	102
query92	67	53	51	51
query93	1801	512	518	512
query94	1066	190	190	190
query95	404	317	321	317
query96	595	285	270	270
query97	3258	3033	3068	3033
query98	240	205	202	202
query99	1197	838	850	838
Total cold run time: 269870 ms
Total hot run time: 175219 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit de8f38ae9e8b5061fd5cfffd813025ee72b019a7, data reload: false

query1	0.05	0.03	0.03
query2	0.09	0.04	0.04
query3	0.23	0.06	0.05
query4	1.69	0.08	0.10
query5	0.50	0.49	0.49
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.51	0.49
query10	0.55	0.54	0.55
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.60	0.58	0.59
query14	0.78	0.78	0.78
query15	0.85	0.81	0.83
query16	0.37	0.35	0.36
query17	1.01	0.96	1.01
query18	0.22	0.25	0.21
query19	1.93	1.73	1.82
query20	0.02	0.01	0.01
query21	15.41	0.65	0.66
query22	3.74	6.67	2.65
query23	18.33	1.35	1.27
query24	2.11	0.23	0.23
query25	0.16	0.09	0.09
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.25	1.04	0.99
query29	12.61	3.42	3.44
query30	0.26	0.07	0.06
query31	2.87	0.38	0.39
query32	3.27	0.48	0.47
query33	2.96	2.94	2.93
query34	17.21	4.40	4.41
query35	4.55	4.43	4.46
query36	0.64	0.50	0.46
query37	0.19	0.16	0.15
query38	0.16	0.15	0.16
query39	0.05	0.04	0.04
query40	0.18	0.14	0.14
query41	0.10	0.05	0.05
query42	0.05	0.06	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.43 s
Total hot run time: 31.45 s

qidaye
qidaye approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 0db0b18 into apache:master Jun 24, 2024
26 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jun 26, 2024
@airborne12 @dataroaring
[Fix](inverted index) remove duplicate stats of inverted_index_query_…
c1cbf46 
…cache_miss (#36707)

inverted_index_query_cache_miss is already processed in
handle_query_cache function
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Jul 31, 2024
@airborne12
[Fix](inverted index) remove duplicate stats of inverted_index_query_…
8bf770f 
…cache_miss (apache#36707)

inverted_index_query_cache_miss is already processed in
handle_query_cache function
@airborne12 airborne12 mentioned this pull request Jul 31, 2024
Merged
airborne12 added a commit that referenced this pull request Jul 31, 2024
@airborne12
[Fix](inverted index) remove duplicate stats of inverted_index_query_…
aed0cc8 
…cache_miss #36707 (#38580)

cherry pick from #36707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qidaye qidaye qidaye approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@airborne12 @doris-robot @qidaye @eldenmoon @xiaokang @dataroaring