-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](sqlserver catalog) Configurable whether to use encrypt when connecting to SQL Server using the catalog #36659
Conversation
…ion when connecting to SQL Server using the catalog
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39487 ms
|
TPC-DS: Total hot run time: 174138 ms
|
ClickBench: Total hot run time: 31.52 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run external |
run buildall |
TPC-H: Total hot run time: 39409 ms
|
TPC-DS: Total hot run time: 174004 ms
|
ClickBench: Total hot run time: 31.05 s
|
…when connecting to SQL Server using the catalog (apache#36659) In previous versions, we used druid as the default JDBC connection pool, which can use custom decryption to parse the certificate when SQL Server encryption is turned on. However, in the new version, after changing HikariCP as the default connection pool, the SQLServer certificate cannot be parsed, so encryption needs to be turned off for normal use. Therefore, a parameter is added to decide whether to disable SQLServer encryption. It is not disabled by default.
…when connecting to SQL Server using the catalog (#36659) In previous versions, we used druid as the default JDBC connection pool, which can use custom decryption to parse the certificate when SQL Server encryption is turned on. However, in the new version, after changing HikariCP as the default connection pool, the SQLServer certificate cannot be parsed, so encryption needs to be turned off for normal use. Therefore, a parameter is added to decide whether to disable SQLServer encryption. It is not disabled by default.
…_encrypt` to `force_sqlserver_jdbc_encrypt_false` (#37015) Front #36659 Renamed the configuration parameter `disable_jdbc_sqlserver_encrypt` to `force_sqlserver_jdbc_encrypt_false` to make its purpose clearer and more explicit. This new name better indicates that the parameter forces the JDBC URL to set `encrypt=false` when enabled.
…use encrypt when connecting to SQL Server using the catalog (#36971) pick (#36659) pick #37015 In previous versions, we used druid as the default JDBC connection pool, which can use custom decryption to parse the certificate when SQL Server encryption is turned on. However, in the new version, after changing HikariCP as the default connection pool, the SQLServer certificate cannot be parsed, so encryption needs to be turned off for normal use. Therefore, a parameter is added to decide whether to disable SQLServer encryption. It is not disabled by default.
…_encrypt` to `force_sqlserver_jdbc_encrypt_false` (#37015) Front #36659 Renamed the configuration parameter `disable_jdbc_sqlserver_encrypt` to `force_sqlserver_jdbc_encrypt_false` to make its purpose clearer and more explicit. This new name better indicates that the parameter forces the JDBC URL to set `encrypt=false` when enabled.
… use encryption when connecting to SQL Server using the catalog (apache#36940) pick apache#36659 pick apache#37015
In previous versions, we used druid as the default JDBC connection pool, which can use custom decryption to parse the certificate when SQL Server encryption is turned on. However, in the new version, after changing HikariCP as the default connection pool, the SQLServer certificate cannot be parsed, so encryption needs to be turned off for normal use. Therefore, a parameter is added to decide whether to disable SQLServer encryption. It is not disabled by default.