Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature](json_functions) support json-keys #36411

Merged
merged 6 commits into from
Jun 26, 2024
Merged

[Feature](json_functions) support json-keys #36411

merged 6 commits into from
Jun 26, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

support json_keys
sql reference MYSQL: https://dev.mysql.com/doc/refman/8.0/en/json-search-functions.html#function_json-keys
Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions[bot]
github-actions bot reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/functions/function_jsonb.cpp
}
const char* l_raw = reinterpret_cast<const char*>(&ldata[l_off]);
JsonbDocument* doc = JsonbDocument::createDocument(l_raw, l_size);
if (UNLIKELY(!doc || !doc->getValue())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]

            if (UNLIKELY(!doc || !doc->getValue())) {
                ^
Additional context

be/src/common/compiler_util.h:35: expanded from macro 'UNLIKELY'

#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
                                         ^

be/src/vec/functions/function_jsonb.cpp
dst_arr.insert_default();
continue;
}
ObjectVal* obj = (ObjectVal*)obj_val;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]

Suggested change
ObjectVal* obj = (ObjectVal*)obj_val;
auto* obj = (ObjectVal*)obj_val;

xiaokang
xiaokang previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 20, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39870 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 14bfd6526471884c53e8151315c921fac06986c7, data reload: false

------ Round 1 ----------------------------------
q1	17613	4854	4250	4250
q2	2019	189	198	189
q3	10447	1147	1086	1086
q4	10203	785	853	785
q5	8248	2718	2674	2674
q6	224	139	137	137
q7	961	614	648	614
q8	9369	2046	2085	2046
q9	8925	6459	6482	6459
q10	8929	3681	3695	3681
q11	456	242	231	231
q12	423	225	230	225
q13	17748	2962	2968	2962
q14	263	229	226	226
q15	502	478	474	474
q16	501	386	375	375
q17	955	716	743	716
q18	8056	7587	7446	7446
q19	7287	1436	1478	1436
q20	648	306	336	306
q21	4830	3214	4024	3214
q22	403	338	342	338
Total cold run time: 119010 ms
Total hot run time: 39870 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4397	4187	4209	4187
q2	369	252	256	252
q3	2964	2715	2732	2715
q4	1853	1608	1559	1559
q5	5236	5252	5252	5252
q6	215	124	129	124
q7	2074	1699	1719	1699
q8	3145	3335	3309	3309
q9	8285	8314	8285	8285
q10	3887	3617	3607	3607
q11	590	487	488	487
q12	769	614	606	606
q13	16728	2943	2981	2943
q14	293	257	272	257
q15	538	477	480	477
q16	461	406	404	404
q17	1751	1475	1471	1471
q18	7529	7455	7402	7402
q19	1668	1589	1598	1589
q20	1952	1775	1760	1760
q21	4821	4808	4672	4672
q22	608	532	550	532
Total cold run time: 70133 ms
Total hot run time: 53589 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.47% (9009/24702)
Line Coverage: 28.01% (73885/263770)
Region Coverage: 27.49% (38368/139555)
Branch Coverage: 24.20% (19561/80824)
Coverage Report: http://coverage.selectdb-in.cc/coverage/14bfd6526471884c53e8151315c921fac06986c7_14bfd6526471884c53e8151315c921fac06986c7/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 168698 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 14bfd6526471884c53e8151315c921fac06986c7, data reload: false

query1	934	379	380	379
query2	6465	2338	2358	2338
query3	6652	207	213	207
query4	19081	17259	17224	17224
query5	4157	481	457	457
query6	256	169	175	169
query7	4584	290	283	283
query8	294	283	294	283
query9	8686	2454	2424	2424
query10	615	300	287	287
query11	10465	10000	9912	9912
query12	135	88	87	87
query13	1686	358	363	358
query14	9930	6701	7385	6701
query15	221	188	197	188
query16	7825	262	256	256
query17	1848	545	541	541
query18	1952	264	269	264
query19	191	159	170	159
query20	92	83	80	80
query21	215	132	123	123
query22	4530	3993	3985	3985
query23	33399	32840	32956	32840
query24	11971	2808	2851	2808
query25	672	352	349	349
query26	1793	153	153	153
query27	2965	301	308	301
query28	7594	2065	2066	2065
query29	1148	650	605	605
query30	280	149	147	147
query31	946	755	762	755
query32	99	57	56	56
query33	803	283	286	283
query34	977	476	459	459
query35	725	611	631	611
query36	1089	940	932	932
query37	214	71	69	69
query38	2912	2756	2725	2725
query39	845	803	777	777
query40	280	126	123	123
query41	56	52	54	52
query42	130	101	98	98
query43	585	570	534	534
query44	1216	721	733	721
query45	199	159	167	159
query46	1084	714	704	704
query47	1846	1778	1762	1762
query48	363	291	291	291
query49	1191	398	399	398
query50	775	383	381	381
query51	6810	6874	6718	6718
query52	105	93	98	93
query53	354	294	286	286
query54	988	446	443	443
query55	75	74	73	73
query56	297	274	300	274
query57	1127	1061	1032	1032
query58	260	229	232	229
query59	3554	3257	2947	2947
query60	296	269	265	265
query61	92	92	89	89
query62	636	457	445	445
query63	334	291	289	289
query64	9851	2241	1722	1722
query65	3163	3098	3087	3087
query66	1402	345	334	334
query67	15300	14857	14961	14857
query68	4610	524	546	524
query69	445	297	314	297
query70	1100	1191	1128	1128
query71	395	270	267	267
query72	7155	2732	2552	2552
query73	741	319	318	318
query74	5974	5574	5487	5487
query75	3430	2641	2682	2641
query76	2680	942	914	914
query77	438	306	299	299
query78	10249	9727	9827	9727
query79	2301	511	511	511
query80	899	460	470	460
query81	578	218	216	216
query82	725	102	98	98
query83	255	166	166	166
query84	235	84	86	84
query85	1897	267	267	267
query86	482	312	319	312
query87	3284	3091	3070	3070
query88	4169	2348	2353	2348
query89	467	377	371	371
query90	1819	188	184	184
query91	126	99	105	99
query92	64	49	50	49
query93	2462	516	492	492
query94	1253	182	186	182
query95	400	319	317	317
query96	596	263	262	262
query97	3228	3043	3010	3010
query98	207	200	194	194
query99	1311	848	806	806
Total cold run time: 275590 ms
Total hot run time: 168698 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.33 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 14bfd6526471884c53e8151315c921fac06986c7, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.51	0.49	0.47
query6	1.34	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.55	0.54	0.53
query11	0.15	0.10	0.11
query12	0.15	0.12	0.11
query13	0.59	0.58	0.60
query14	0.78	0.78	0.78
query15	0.83	0.80	0.80
query16	0.37	0.37	0.36
query17	0.95	1.02	0.97
query18	0.24	0.23	0.25
query19	1.88	1.74	1.68
query20	0.01	0.01	0.01
query21	15.47	0.68	0.67
query22	4.60	7.03	1.74
query23	18.30	1.29	1.31
query24	2.12	0.25	0.22
query25	0.14	0.09	0.09
query26	0.27	0.18	0.18
query27	0.08	0.08	0.08
query28	13.23	1.01	1.00
query29	12.65	3.29	3.27
query30	0.26	0.07	0.06
query31	2.89	0.39	0.38
query32	3.28	0.48	0.48
query33	2.87	2.91	2.89
query34	17.06	4.40	4.41
query35	4.46	4.43	4.52
query36	0.66	0.46	0.51
query37	0.19	0.16	0.16
query38	0.16	0.16	0.14
query39	0.04	0.03	0.04
query40	0.17	0.15	0.14
query41	0.10	0.04	0.04
query42	0.07	0.05	0.04
query43	0.05	0.05	0.05
Total cold run time: 110.11 s
Total hot run time: 30.33 s

morrySnow
morrySnow reviewed Jun 21, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java Outdated
Comment on lines 717 to 718
scalar(JsonKeys.class, "json_keys"),
scalar(JsonKeys.class, "jsonb_keys"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
scalar(JsonKeys.class, "json_keys"),
scalar(JsonKeys.class, "jsonb_keys"),
scalar(JsonKeys.class, "json_keys", "jsonb_keys"),

@amorynan
Copy link
Contributor Author

run buildall

@amorynan amorynan requested a review from morrySnow June 21, 2024 04:39
@doris-robot
Copy link

TPC-H: Total hot run time: 40655 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f15dd382b1a5e9a3c49505094c585edfbe350b31, data reload: false

------ Round 1 ----------------------------------
q1	17610	4319	4227	4227
q2	2036	192	196	192
q3	10539	1204	1148	1148
q4	10434	788	764	764
q5	7517	2684	2684	2684
q6	222	141	138	138
q7	974	617	613	613
q8	9652	2116	2076	2076
q9	9165	6489	6468	6468
q10	8896	3707	3718	3707
q11	459	246	241	241
q12	540	242	235	235
q13	18733	2956	3002	2956
q14	259	228	216	216
q15	523	479	482	479
q16	489	394	379	379
q17	959	692	677	677
q18	7940	7517	7451	7451
q19	1865	1508	1507	1507
q20	653	310	324	310
q21	4896	3846	3871	3846
q22	396	341	349	341
Total cold run time: 114757 ms
Total hot run time: 40655 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4269	4263	4185	4185
q2	371	255	267	255
q3	2982	2756	2738	2738
q4	1872	1609	1618	1609
q5	5186	5239	5236	5236
q6	218	129	128	128
q7	2137	1752	1732	1732
q8	3192	3334	3295	3295
q9	8301	8321	8307	8307
q10	3897	3699	3684	3684
q11	599	499	491	491
q12	786	638	628	628
q13	17404	2985	3021	2985
q14	301	251	274	251
q15	520	484	474	474
q16	466	407	419	407
q17	1741	1457	1457	1457
q18	7627	7606	7277	7277
q19	3674	1544	1666	1544
q20	1954	1800	1768	1768
q21	4860	4642	4901	4642
q22	590	535	544	535
Total cold run time: 72947 ms
Total hot run time: 53628 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.47% (9010/24706)
Line Coverage: 28.00% (73890/263870)
Region Coverage: 27.48% (38377/139658)
Branch Coverage: 24.18% (19561/80892)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f15dd382b1a5e9a3c49505094c585edfbe350b31_f15dd382b1a5e9a3c49505094c585edfbe350b31/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 170389 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f15dd382b1a5e9a3c49505094c585edfbe350b31, data reload: false

query1	945	383	385	383
query2	6462	2491	2323	2323
query3	6653	210	219	210
query4	19193	17406	17334	17334
query5	4188	465	481	465
query6	253	157	158	157
query7	4603	299	305	299
query8	334	296	299	296
query9	8465	2419	2400	2400
query10	601	295	291	291
query11	10589	10073	9964	9964
query12	137	84	92	84
query13	1629	361	358	358
query14	10227	7080	7591	7080
query15	236	192	184	184
query16	8002	261	275	261
query17	1903	568	520	520
query18	2040	275	277	275
query19	198	157	153	153
query20	93	86	89	86
query21	214	138	132	132
query22	4267	4061	3902	3902
query23	33754	33029	33088	33029
query24	11910	2891	2790	2790
query25	676	364	360	360
query26	1738	159	152	152
query27	2979	315	317	315
query28	7565	2083	2089	2083
query29	1048	635	608	608
query30	285	164	150	150
query31	956	739	758	739
query32	97	60	58	58
query33	769	298	278	278
query34	953	476	486	476
query35	731	608	603	603
query36	1094	921	890	890
query37	192	72	75	72
query38	2844	2740	2724	2724
query39	879	808	799	799
query40	276	129	125	125
query41	61	53	54	53
query42	123	96	104	96
query43	587	538	546	538
query44	1197	748	747	747
query45	200	170	169	169
query46	1096	731	712	712
query47	1857	1754	1747	1747
query48	368	305	298	298
query49	1204	445	407	407
query50	762	386	388	386
query51	6920	6851	6707	6707
query52	108	93	99	93
query53	362	290	294	290
query54	976	442	441	441
query55	77	73	78	73
query56	283	260	282	260
query57	1137	1082	1030	1030
query58	253	242	262	242
query59	3493	3383	3223	3223
query60	296	276	294	276
query61	96	94	91	91
query62	635	444	449	444
query63	350	304	295	295
query64	9827	2229	1737	1737
query65	3188	3268	3124	3124
query66	1389	349	332	332
query67	15233	14909	14967	14909
query68	4572	540	521	521
query69	448	309	333	309
query70	1193	1156	1163	1156
query71	385	281	286	281
query72	7230	5149	2990	2990
query73	744	325	323	323
query74	5850	5471	5452	5452
query75	3343	2677	2665	2665
query76	2456	997	1015	997
query77	430	303	293	293
query78	10619	9775	9708	9708
query79	2677	516	522	516
query80	2176	471	469	469
query81	581	217	215	215
query82	885	110	100	100
query83	275	177	174	174
query84	270	84	87	84
query85	2097	290	276	276
query86	496	309	333	309
query87	3232	3054	3059	3054
query88	4177	2373	2339	2339
query89	478	374	398	374
query90	1805	191	197	191
query91	128	116	100	100
query92	59	49	52	49
query93	2673	515	513	513
query94	1291	189	191	189
query95	412	312	317	312
query96	596	273	263	263
query97	3241	3026	3021	3021
query98	227	207	196	196
query99	1213	838	822	822
Total cold run time: 278315 ms
Total hot run time: 170389 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.83 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f15dd382b1a5e9a3c49505094c585edfbe350b31, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.66	0.08	0.07
query5	0.50	0.48	0.49
query6	1.15	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.48
query10	0.54	0.54	0.54
query11	0.15	0.12	0.12
query12	0.16	0.13	0.13
query13	0.59	0.59	0.59
query14	0.77	0.77	0.77
query15	0.86	0.81	0.82
query16	0.36	0.36	0.36
query17	0.97	0.96	1.01
query18	0.26	0.24	0.25
query19	1.80	1.78	1.73
query20	0.02	0.01	0.00
query21	15.42	0.67	0.67
query22	4.32	6.74	2.05
query23	18.38	1.35	1.33
query24	2.19	0.24	0.22
query25	0.16	0.09	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.08
query28	13.18	1.01	1.00
query29	12.65	3.36	3.39
query30	0.26	0.08	0.06
query31	2.86	0.41	0.39
query32	3.26	0.47	0.47
query33	2.82	2.96	2.85
query34	16.91	4.44	4.42
query35	4.46	4.44	4.48
query36	0.65	0.45	0.46
query37	0.19	0.15	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.18	0.14	0.14
query41	0.10	0.05	0.05
query42	0.05	0.06	0.04
query43	0.05	0.05	0.04
Total cold run time: 109.38 s
Total hot run time: 30.83 s

@doris-robot
Copy link

ClickBench: Total hot run time: 31.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a92c05073799d6d858d02110e01c34da62d3b78c, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.07
query5	0.49	0.47	0.49
query6	1.14	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.54	0.48	0.48
query10	0.54	0.55	0.54
query11	0.16	0.12	0.12
query12	0.15	0.12	0.13
query13	0.60	0.60	0.59
query14	0.77	0.77	0.83
query15	0.86	0.84	0.84
query16	0.38	0.37	0.37
query17	1.01	1.04	1.01
query18	0.22	0.23	0.26
query19	1.81	1.74	1.80
query20	0.01	0.01	0.01
query21	15.43	0.66	0.65
query22	3.80	6.84	2.76
query23	18.29	1.43	1.27
query24	2.09	0.23	0.22
query25	0.15	0.08	0.08
query26	0.26	0.17	0.18
query27	0.08	0.09	0.09
query28	13.26	1.07	1.03
query29	12.63	3.32	3.32
query30	0.26	0.06	0.05
query31	2.87	0.40	0.38
query32	3.24	0.48	0.48
query33	2.92	2.94	3.00
query34	17.00	4.58	4.43
query35	4.54	4.55	4.55
query36	0.67	0.49	0.48
query37	0.19	0.16	0.16
query38	0.15	0.16	0.15
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.05	0.05
Total cold run time: 108.98 s
Total hot run time: 31.75 s

morrySnow
morrySnow previously approved these changes Jun 24, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

eldenmoon
eldenmoon previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amorynan amorynan dismissed stale reviews from eldenmoon and morrySnow via 265f8e0 June 25, 2024 09:38
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 25, 2024
@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40107 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 265f8e09417bc631fe9bc4bb3e19b91a9abb989f, data reload: false

------ Round 1 ----------------------------------
q1	18044	5132	4469	4469
q2	2619	186	207	186
q3	11609	1145	1152	1145
q4	10361	894	740	740
q5	7675	2694	2674	2674
q6	229	141	142	141
q7	970	600	617	600
q8	9613	2044	2096	2044
q9	8799	6486	6461	6461
q10	9028	3741	3714	3714
q11	449	241	233	233
q12	412	234	235	234
q13	18852	3003	2952	2952
q14	268	220	231	220
q15	519	482	489	482
q16	543	382	379	379
q17	960	728	716	716
q18	8263	7466	7440	7440
q19	7307	1474	1557	1474
q20	664	327	319	319
q21	4888	3151	3990	3151
q22	389	333	336	333
Total cold run time: 122461 ms
Total hot run time: 40107 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4410	4288	4262	4262
q2	358	265	263	263
q3	2985	2746	2735	2735
q4	1883	1615	1617	1615
q5	5288	5303	5277	5277
q6	210	131	132	131
q7	2144	1795	1762	1762
q8	3212	3304	3283	3283
q9	8365	8410	8370	8370
q10	3880	3667	3743	3667
q11	584	482	477	477
q12	784	612	596	596
q13	17488	2972	3029	2972
q14	275	257	264	257
q15	517	486	482	482
q16	483	414	420	414
q17	1786	1478	1474	1474
q18	7711	7427	7307	7307
q19	1736	1680	1494	1494
q20	1972	1788	1807	1788
q21	4954	4895	4788	4788
q22	597	565	547	547
Total cold run time: 71622 ms
Total hot run time: 53961 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172664 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 265f8e09417bc631fe9bc4bb3e19b91a9abb989f, data reload: false

query1	925	400	385	385
query2	6437	2389	2426	2389
query3	6688	203	201	201
query4	19159	17526	17391	17391
query5	4324	472	470	470
query6	252	159	157	157
query7	4588	290	287	287
query8	309	289	284	284
query9	8553	2386	2368	2368
query10	596	281	285	281
query11	10644	10018	10092	10018
query12	131	85	80	80
query13	1631	380	360	360
query14	10094	7581	6659	6659
query15	234	193	185	185
query16	8063	262	257	257
query17	1904	511	531	511
query18	2048	278	262	262
query19	194	153	160	153
query20	92	85	80	80
query21	213	123	132	123
query22	4417	4073	4117	4073
query23	33801	32898	33093	32898
query24	11841	2751	2857	2751
query25	650	348	354	348
query26	1747	151	152	151
query27	2924	312	318	312
query28	7318	2058	2055	2055
query29	1047	610	595	595
query30	293	152	148	148
query31	963	730	732	730
query32	93	52	54	52
query33	774	280	278	278
query34	953	459	476	459
query35	750	633	614	614
query36	1092	971	953	953
query37	195	71	71	71
query38	2909	2737	2768	2737
query39	853	772	794	772
query40	288	128	129	128
query41	52	52	56	52
query42	123	99	99	99
query43	583	547	552	547
query44	1214	728	742	728
query45	191	160	168	160
query46	1071	704	703	703
query47	1850	1754	1804	1754
query48	380	298	298	298
query49	1190	407	413	407
query50	761	380	379	379
query51	6930	6850	6760	6760
query52	111	93	96	93
query53	358	295	289	289
query54	955	454	440	440
query55	78	71	74	71
query56	302	261	267	261
query57	1174	1045	1057	1045
query58	254	244	254	244
query59	3511	3159	3131	3131
query60	301	307	298	298
query61	141	88	89	88
query62	660	477	451	451
query63	317	293	288	288
query64	9887	2284	1749	1749
query65	3185	3078	3098	3078
query66	1376	337	367	337
query67	15504	14983	14973	14973
query68	5853	568	547	547
query69	589	439	380	380
query70	1182	1158	1146	1146
query71	443	270	272	270
query72	7284	5465	6114	5465
query73	801	319	323	319
query74	5986	5520	5528	5520
query75	3873	2687	2692	2687
query76	3577	839	966	839
query77	656	311	303	303
query78	10338	9808	9834	9808
query79	2540	512	526	512
query80	1350	476	465	465
query81	571	222	222	222
query82	1331	106	105	105
query83	194	172	175	172
query84	273	86	88	86
query85	1412	339	269	269
query86	460	326	333	326
query87	3248	3066	3098	3066
query88	4071	2367	2342	2342
query89	467	393	381	381
query90	1812	189	187	187
query91	125	100	100	100
query92	65	51	48	48
query93	2701	521	518	518
query94	1188	188	187	187
query95	402	316	308	308
query96	599	268	265	265
query97	3253	3053	3025	3025
query98	221	198	195	195
query99	1308	878	852	852
Total cold run time: 280619 ms
Total hot run time: 172664 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.06 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 265f8e09417bc631fe9bc4bb3e19b91a9abb989f, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.66	0.08	0.08
query5	0.50	0.49	0.52
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.56	0.48	0.48
query10	0.55	0.54	0.55
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.59
query14	0.76	0.79	0.81
query15	0.84	0.82	0.81
query16	0.36	0.37	0.36
query17	1.04	0.96	1.01
query18	0.20	0.25	0.22
query19	1.85	1.71	1.80
query20	0.01	0.01	0.01
query21	15.46	0.67	0.66
query22	4.37	6.68	2.33
query23	18.30	1.43	1.33
query24	2.18	0.21	0.22
query25	0.15	0.09	0.08
query26	0.25	0.18	0.18
query27	0.08	0.07	0.08
query28	13.20	1.03	1.01
query29	12.61	3.34	3.36
query30	0.27	0.06	0.06
query31	2.84	0.40	0.39
query32	3.24	0.47	0.47
query33	2.88	2.88	2.94
query34	17.15	4.39	4.46
query35	4.47	4.48	4.45
query36	0.64	0.48	0.46
query37	0.19	0.15	0.15
query38	0.15	0.14	0.13
query39	0.04	0.04	0.04
query40	0.19	0.16	0.15
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.03	0.03
Total cold run time: 109.62 s
Total hot run time: 31.06 s

@amorynan amorynan requested a review from eldenmoon June 25, 2024 13:40
eldenmoon
eldenmoon approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 309df53 into apache:master Jun 26, 2024
27 of 31 checks passed
dataroaring pushed a commit that referenced this pull request Jun 28, 2024
@amorynan @dataroaring
[Feature](json_functions) support json-keys (#36411)
d66b292 
support json_keys 
sql reference MYSQL:
https://dev.mysql.com/doc/refman/8.0/en/json-search-functions.html#function_json-keys
@xiaokang xiaokang added usercase Important user case type label dev/2.0.x dev/2.1.x and removed dev/2.0.x labels Jul 31, 2024
@amorynan amorynan mentioned this pull request Jul 31, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 2, 2024
@amorynan
[pick](json-keys) support json_keys function (#38631)
556f0fc 
## Proposed changes
backport: #36411
Issue Number: close #xxx

<!--Describe your changes.-->
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@eldenmoon eldenmoon eldenmoon approved these changes

@morrySnow morrySnow morrySnow approved these changes

@xiaokang xiaokang xiaokang left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.0-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amorynan @doris-robot @xiaokang @eldenmoon @morrySnow @yiguolei @dataroaring