Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](regression test) test_alter_colocate_group due to force_olap_table_replication_num #35835

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Jun 4, 2024

Exception in alter_p2/test_alter_colocate_group.groovy(line 94):

)
DISTRIBUTED BY HASH(k2) BUCKETS 5
PROPERTIES
(
"colocate_with" = "group_2",
"replication_num" = "1"
);
"""

sql """
^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^
CREATE TABLE tbl3
(
`uuid` varchar(255) NULL,
`action_datetime` date NULL
)
DUPLICATE KEY(uuid)
PARTITION BY RANGE(action_datetime)()
DISTRIBUTED BY HASH(uuid) BUCKETS 4
PROPERTIES
(

Exception:
java.sql.SQLSyntaxErrorException: Colocate tables must have same replication allocation:

{ tag.location.default: 1 }
should be

{ tag.location.default: 3 }
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:120)

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777
Copy link
Collaborator Author

yujun777 commented Jun 4, 2024

run buildall

Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jun 4, 2024

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Jun 4, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jun 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 4, 2024
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 4, 2024
@yujun777
Copy link
Collaborator Author

yujun777 commented Jun 4, 2024

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6a005b6 into apache:master Jun 5, 2024
27 of 28 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by at least one committer and no changes requested.

dataroaring pushed a commit that referenced this pull request Jun 7, 2024
…ble_replication_num (#35835)

```
Exception in alter_p2/test_alter_colocate_group.groovy(line 94):

)
DISTRIBUTED BY HASH(k2) BUCKETS 5
PROPERTIES
(
"colocate_with" = "group_2",
"replication_num" = "1"
);
"""

sql """
^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^
CREATE TABLE tbl3
(
`uuid` varchar(255) NULL,
`action_datetime` date NULL
)
DUPLICATE KEY(uuid)
PARTITION BY RANGE(action_datetime)()
DISTRIBUTED BY HASH(uuid) BUCKETS 4
PROPERTIES
(

Exception:
java.sql.SQLSyntaxErrorException: Colocate tables must have same replication allocation:

{ tag.location.default: 1 }
should be

{ tag.location.default: 3 }
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:120)
```
yujun777 added a commit to yujun777/doris that referenced this pull request Jul 18, 2024
…ble_replication_num (apache#35835)

```
Exception in alter_p2/test_alter_colocate_group.groovy(line 94):

)
DISTRIBUTED BY HASH(k2) BUCKETS 5
PROPERTIES
(
"colocate_with" = "group_2",
"replication_num" = "1"
);
"""

sql """
^^^^^^^^^^^^^^^^^^^^^^^^^ERROR LINE^^^^^^^^^^^^^^^^^^^^^^^^^
CREATE TABLE tbl3
(
`uuid` varchar(255) NULL,
`action_datetime` date NULL
)
DUPLICATE KEY(uuid)
PARTITION BY RANGE(action_datetime)()
DISTRIBUTED BY HASH(uuid) BUCKETS 4
PROPERTIES
(

Exception:
java.sql.SQLSyntaxErrorException: Colocate tables must have same replication allocation:

{ tag.location.default: 1 }
should be

{ tag.location.default: 3 }
at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:120)
```
dataroaring pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants