Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](parquet) the end offset of column chunk may be wrong in parquet metadata #28893

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

AshinGau
Copy link
Member

backport: #28891

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang xiaokang requested a review from morningman December 23, 2023 03:25
@AshinGau AshinGau force-pushed the wrong_end_offset_br2 branch from 31349fb to 00c92dc Compare December 23, 2023 09:16
@AshinGau
Copy link
Member Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.74% (7990/21170)
Line Coverage: 29.45% (64914/220412)
Region Coverage: 28.92% (33391/115464)
Branch Coverage: 24.79% (17131/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/00c92dc619375f720158682affae764c91c269c9_00c92dc619375f720158682affae764c91c269c9/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.3 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 30.5 seconds inserted 10000000 Rows, about 327K ops/s
storage size: 17167903773 Bytes

@morningman morningman added dev/2.0.4 usercase Important user case type label and removed usercase Important user case type label dev/2.0.4 labels Dec 23, 2023
@morningman morningman merged commit adb7730 into apache:branch-2.0 Dec 23, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants