-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pipelineX](refactor) rename functions #28846
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -57,7 +57,7 @@ class AssertNumRowsOperatorX final : public StreamingOperatorX<AssertNumRowsLoca | |||||
|
||||||
[[nodiscard]] bool is_source() const override { return false; } | ||||||
|
||||||
DataDistribution get_local_exchange_type() const override { | ||||||
DataDistribution required_data_distribution() const override { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
return {ExchangeType::PASSTHROUGH}; | ||||||
} | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -117,7 +117,7 @@ class ExchangeSourceOperatorX final : public OperatorX<ExchangeLocalState> { | |||||
return _sub_plan_query_statistics_recvr; | ||||||
} | ||||||
|
||||||
DataDistribution get_local_exchange_type() const override { | ||||||
DataDistribution required_data_distribution() const override { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
if (OperatorX<ExchangeLocalState>::ignore_data_distribution()) { | ||||||
return {ExchangeType::NOOP}; | ||||||
} | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -163,7 +163,7 @@ class HashJoinProbeOperatorX final : public JoinProbeOperatorX<HashJoinProbeLoca | |||||
SourceState& source_state) const override; | ||||||
|
||||||
bool need_more_input_data(RuntimeState* state) const override; | ||||||
DataDistribution get_local_exchange_type() const override { | ||||||
DataDistribution required_data_distribution() const override { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
if (_join_op == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN) { | ||||||
return {ExchangeType::NOOP}; | ||||||
} | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -102,7 +102,7 @@ class NestedLoopJoinBuildSinkOperatorX final | |||||
Status sink(RuntimeState* state, vectorized::Block* in_block, | ||||||
SourceState source_state) override; | ||||||
|
||||||
DataDistribution get_local_exchange_type() const override { | ||||||
DataDistribution required_data_distribution() const override { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
if (_join_op == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN) { | ||||||
return {ExchangeType::NOOP}; | ||||||
} | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -227,7 +227,7 @@ class NestedLoopJoinProbeOperatorX final | |||||
return _old_version_flag ? _row_descriptor : *_intermediate_row_desc; | ||||||
} | ||||||
|
||||||
DataDistribution get_local_exchange_type() const override { | ||||||
DataDistribution required_data_distribution() const override { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
if (_join_op == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN) { | ||||||
return {ExchangeType::NOOP}; | ||||||
} | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -105,9 +105,9 @@ class PartitionSortSinkOperatorX final : public DataSinkOperatorX<PartitionSortS | |||||
Status open(RuntimeState* state) override; | ||||||
Status sink(RuntimeState* state, vectorized::Block* in_block, | ||||||
SourceState source_state) override; | ||||||
DataDistribution get_local_exchange_type() const override { | ||||||
DataDistribution required_data_distribution() const override { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
if (_topn_phase == TPartTopNPhase::TWO_PHASE_GLOBAL) { | ||||||
return DataSinkOperatorX<PartitionSortSinkLocalState>::get_local_exchange_type(); | ||||||
return DataSinkOperatorX<PartitionSortSinkLocalState>::required_data_distribution(); | ||||||
} | ||||||
return {ExchangeType::PASSTHROUGH}; | ||||||
} | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -120,7 +120,7 @@ class StreamingAggSinkOperatorX final : public AggSinkOperatorX<StreamingAggSink | |||||
Status init(const TPlanNode& tnode, RuntimeState* state) override; | ||||||
Status sink(RuntimeState* state, vectorized::Block* in_block, | ||||||
SourceState source_state) override; | ||||||
DataDistribution get_local_exchange_type() const override { | ||||||
DataDistribution required_data_distribution() const override { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]
Suggested change
|
||||||
return {ExchangeType::PASSTHROUGH}; | ||||||
} | ||||||
}; | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method 'required_data_distribution' can be made static [readability-convert-member-functions-to-static]