-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](analyze_cmd) add show-tablets-belong stmt for analyzing a batch of tablet-ids #27994
Conversation
…batch of tablet-ids
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it have to do with ANALYZE
? ANALYZE
should only used for collection statistic infomation. i cannot find any relation bewteen this statement and ANALYZE
. If u want show detail info about tablet, please use more appropriate keyword
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
PR approved by at least one committer and no changes requested. |
run feut |
run p0 |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2704,6 +2709,62 @@ private void handleShowAnalyze() { | |||
resultSet = new ShowResultSet(showStmt.getMetaData(), resultRows); | |||
} | |||
|
|||
private void handleShowAnalyzeTablet() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to belongxxx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
…atch of tablet-ids (apache#27994)
…atch of tablet-ids (apache#27994)
…atch of tablet-ids (apache#27994)
This #27994 introduce a new keyword BELONG, need to add it as reserve keyword
This #27994 introduce a new keyword BELONG, need to add it as reserve keyword
This apache#27994 introduce a new keyword BELONG, need to add it as reserve keyword
…atch of tablet-ids (apache#27994) (apache#31255) bp apache#27994 apache#31230
Some cmds return tablet-id list, such as:

show proc '/cluster_health/tablet_health/73421';
but it is hard to identify the tables and show their infos, which these tablets belong to.

this pr add a show-tablets-belong stmt to resolve this problem.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...