Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](analyze_cmd) add show-tablets-belong stmt for analyzing a batch of tablet-ids #27994

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

Yulei-Yang
Copy link
Contributor

@Yulei-Yang Yulei-Yang commented Dec 5, 2023

Some cmds return tablet-id list, such as: show proc '/cluster_health/tablet_health/73421';
image

but it is hard to identify the tables and show their infos, which these tablets belong to.
this pr add a show-tablets-belong stmt to resolve this problem.
image

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Yulei-Yang
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.39 seconds
stream load tsv: 565 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.2 seconds inserted 10000000 Rows, about 354K ops/s
storage size: 17163775417 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 7806607ac282a371f2457bee16966e5349794e73, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4898	4744	4691	4691
q2	362	165	162	162
q3	1481	1294	1309	1294
q4	1136	951	957	951
q5	3220	3217	3213	3213
q6	257	127	132	127
q7	1017	510	546	510
q8	2225	2248	2226	2226
q9	6829	6815	6835	6815
q10	3253	3313	3326	3313
q11	339	210	203	203
q12	358	206	210	206
q13	4625	3881	3851	3851
q14	250	218	213	213
q15	608	541	530	530
q16	448	388	399	388
q17	1028	645	631	631
q18	8057	7547	7325	7325
q19	1525	1520	1526	1520
q20	582	300	331	300
q21	3390	2978	2921	2921
q22	380	306	310	306
Total cold run time: 46268 ms
Total hot run time: 41696 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4653	4608	4611	4608
q2	300	196	191	191
q3	3718	3725	3721	3721
q4	2531	2520	2506	2506
q5	6126	6105	6136	6105
q6	240	122	123	122
q7	2572	1948	1959	1948
q8	3720	3704	3742	3704
q9	9394	9362	9365	9362
q10	4013	4105	4123	4105
q11	604	484	482	482
q12	814	648	677	648
q13	4348	3637	3651	3637
q14	273	237	236	236
q15	609	537	542	537
q16	513	483	496	483
q17	1957	1963	1993	1963
q18	9237	8872	9329	8872
q19	1721	1718	1783	1718
q20	2315	1962	1953	1953
q21	7104	6716	6717	6716
q22	651	549	565	549
Total cold run time: 67413 ms
Total hot run time: 64166 ms

xy720
xy720 previously approved these changes Dec 5, 2023
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 5, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

PR approved by anyone and no changes requested.

lide-reed
lide-reed previously approved these changes Dec 5, 2023
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it have to do with ANALYZE? ANALYZE should only used for collection statistic infomation. i cannot find any relation bewteen this statement and ANALYZE. If u want show detail info about tablet, please use more appropriate keyword

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 5, 2023
@Yulei-Yang Yulei-Yang dismissed stale reviews from lide-reed and xy720 via 91c3121 December 5, 2023 12:55
@Yulei-Yang
Copy link
Contributor Author

run buildall

@Yulei-Yang Yulei-Yang requested a review from morrySnow December 5, 2023 12:59
@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.17 seconds
stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.0 seconds inserted 10000000 Rows, about 357K ops/s
storage size: 17164312562 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 91c3121ba00e535aff8618c12f7079075a63448c, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4788	4495	4511	4495
q2	370	145	157	145
q3	1469	1255	1228	1228
q4	1124	947	917	917
q5	3174	3198	3201	3198
q6	255	130	131	130
q7	998	502	485	485
q8	2207	2232	2178	2178
q9	6724	6685	6710	6685
q10	3226	3263	3296	3263
q11	331	212	195	195
q12	370	222	205	205
q13	4621	3883	3777	3777
q14	247	216	216	216
q15	567	531	515	515
q16	437	381	388	381
q17	1011	620	600	600
q18	7477	7182	8444	7182
q19	1527	1433	1388	1388
q20	954	325	295	295
q21	3117	2689	2707	2689
q22	352	294	294	294
Total cold run time: 45346 ms
Total hot run time: 40461 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4449	4457	4409	4409
q2	269	164	178	164
q3	3540	3537	3527	3527
q4	2393	2382	2380	2380
q5	5767	5748	5754	5748
q6	243	119	119	119
q7	2382	1845	1843	1843
q8	3538	3544	3549	3544
q9	9121	9071	9035	9035
q10	3917	3995	4013	3995
q11	511	393	378	378
q12	761	608	582	582
q13	4324	3561	3551	3551
q14	272	255	248	248
q15	568	525	519	519
q16	490	461	460	460
q17	1868	1860	1876	1860
q18	8667	8213	8244	8213
q19	1748	1778	1769	1769
q20	2258	1943	1932	1932
q21	6528	6156	6158	6156
q22	513	405	434	405
Total cold run time: 64127 ms
Total hot run time: 60837 ms

morrySnow
morrySnow previously approved these changes Dec 6, 2023
@Yulei-Yang Yulei-Yang changed the title [feature](analyze_cmd) add show-analyze-tablets stmt for analyzing a batch of tablet-ids [feature](analyze_cmd) add show-tablets-belong stmt for analyzing a batch of tablet-ids Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2023
@Yulei-Yang
Copy link
Contributor Author

run feut

@Yulei-Yang
Copy link
Contributor Author

run p0

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 6, 2023
@Yulei-Yang
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.17 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162311623 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit d077f95876a9d4784f89ff431c702f0447199c7c, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4695	4394	4495	4394
q2	382	150	159	150
q3	1464	1253	1247	1247
q4	1127	967	922	922
q5	3183	3174	3223	3174
q6	247	129	127	127
q7	993	502	489	489
q8	2221	2229	2197	2197
q9	6718	6697	6686	6686
q10	3220	3282	3293	3282
q11	327	202	214	202
q12	352	216	214	214
q13	4605	3830	3819	3819
q14	243	217	218	217
q15	570	532	528	528
q16	444	394	403	394
q17	1021	611	658	611
q18	7483	7175	8502	7175
q19	1523	1376	1447	1376
q20	549	411	296	296
q21	3123	2680	2682	2680
q22	351	288	299	288
Total cold run time: 44841 ms
Total hot run time: 40468 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4372	4374	4332	4332
q2	270	163	172	163
q3	3540	3520	3520	3520
q4	2393	2375	2376	2375
q5	5752	5741	5740	5740
q6	242	122	123	122
q7	2371	1860	1824	1824
q8	3532	3537	3530	3530
q9	9067	9006	9049	9006
q10	3921	4008	4010	4008
q11	499	377	388	377
q12	756	634	604	604
q13	4310	3539	3536	3536
q14	281	262	253	253
q15	570	531	527	527
q16	490	462	463	462
q17	1874	1848	1881	1848
q18	8622	8321	8296	8296
q19	1760	1754	1776	1754
q20	2263	1958	1918	1918
q21	6517	6197	6140	6140
q22	497	432	440	432
Total cold run time: 63899 ms
Total hot run time: 60767 ms

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2704,6 +2709,62 @@ private void handleShowAnalyze() {
resultSet = new ShowResultSet(showStmt.getMetaData(), resultRows);
}

private void handleShowAnalyzeTablet() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to belongxxx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@lide-reed lide-reed merged commit fa5096f into apache:master Dec 6, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Feb 22, 2024
morningman pushed a commit to morningman/doris that referenced this pull request Feb 22, 2024
morningman added a commit that referenced this pull request Feb 22, 2024
This #27994 introduce a new keyword BELONG, need to add it as reserve keyword
yiguolei pushed a commit that referenced this pull request Feb 22, 2024
This #27994 introduce a new keyword BELONG, need to add it as reserve keyword
morningman added a commit that referenced this pull request Feb 22, 2024
feiniaofeiafei pushed a commit to feiniaofeiafei/doris that referenced this pull request Feb 23, 2024
This apache#27994 introduce a new keyword BELONG, need to add it as reserve keyword
@Yulei-Yang Yulei-Yang deleted the show_analyze_tablets branch April 3, 2024 05:29
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants