Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bitmap, hll, segment v2 DefaultValue bug #2570

Merged
merged 3 commits into from
Dec 27, 2019
Merged

Fix bitmap, hll, segment v2 DefaultValue bug #2570

merged 3 commits into from
Dec 27, 2019

Conversation

kangkaisen
Copy link
Contributor

For #2529

  1. Change the bitmap and HLL default value to empty bitmap and empty bitmap HLL
  2. Fix DefaultValueColumnIterator bug
  3. Fix uint24.h ostream bug

@kangkaisen kangkaisen closed this Dec 26, 2019
@kangkaisen kangkaisen reopened this Dec 26, 2019
imay
imay reviewed Dec 26, 2019
View reviewed changes
be/src/olap/rowset/segment_v2/column_reader.h Outdated
@@ -305,9 +307,12 @@ class DefaultValueColumnIterator : public ColumnIterator {
std::string _default_value;
bool _is_nullable;
FieldType _type;
size_t _length;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add some comments for length and value_size. This may cause people confused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Rename these two variables.

imay
imay approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 5fd7133 into apache:master Dec 27, 2019
infearOnTheWay pushed a commit to infearOnTheWay/incubator-doris that referenced this pull request Jan 6, 2020
@kangkaisen @infearOnTheWay
Fix bitmap, hll, segment v2 DefaultValue bug (apache#2570)
fd84d71 
1. Change the bitmap and HLL default value to empty bitmap and empty bitmap HLL
2. Fix DefaultValueColumnIterator bug
3. Fix uint24.h ostream bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangkaisen @imay