Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](Nereids) remove between expression to simplify planner #23421

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[opt](Nereids) remove between expression to simplify planner #23421

merged 1 commit into from
Aug 25, 2023

Conversation

morrySnow
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow morrySnow force-pushed the fix_between_type_coercion branch from 184ada8 to f2ec245 Compare August 24, 2023 07:46
@morrySnow
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.8 seconds
stream load tsv: 540 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17161867736 Bytes

@morrySnow morrySnow force-pushed the fix_between_type_coercion branch from f2ec245 to e258634 Compare August 24, 2023 15:07
@morrySnow morrySnow force-pushed the fix_between_type_coercion branch from e258634 to fbef81b Compare August 24, 2023 15:15
@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 25, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 372f83d into apache:master Aug 25, 2023
xiaokang pushed a commit that referenced this pull request Aug 25, 2023
@morrySnow @xiaokang
[opt](Nereids) remove between expression to simplify planner (#23421)
f1f13be
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Open
@morrySnow morrySnow deleted the fix_between_type_coercion branch September 4, 2023 02:44
yujun777 added a commit to yujun777/doris that referenced this pull request Feb 19, 2025
@yujun777
revert apache#23421: add between predicate back
e056760
yujun777 added a commit to yujun777/doris that referenced this pull request Feb 19, 2025
@yujun777
revert apache#23421: add between predicate back
9588b9a
@yujun777 yujun777 mentioned this pull request Feb 19, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keanji-x keanji-x keanji-x approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged merge_conflict p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @hello-stephen @keanji-x @starocean999 @xiaokang