Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](regression) Add 'sync' after stream_load in some cases #18945

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Apr 23, 2023

Proposed changes

When running regression testing in a multi-fe environment, sometimes test cases fail due to no rows selected.

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 63e8fb7 into apache:master Apr 23, 2023
@yiguolei yiguolei added the dev/2.0.0-alpha1 should be merged into branch-2.0-alpha label Apr 23, 2023
@xiaokang xiaokang added dev/2.0.0-alpha1-merged and removed dev/2.0.0-alpha1 should be merged into branch-2.0-alpha labels Apr 30, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.0-alpha1-merged kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants