Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test](multi-catalog) Fix test_hive_parquet regression test order issue. #18879

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Apr 20, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

l_orderkey cannot guarantee unique order.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

morningman
morningman previously approved these changes Apr 20, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 20, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@kaka11chen kaka11chen force-pushed the fix_test_hive_parquet_test branch from 57bef9f to 32c505d Compare April 21, 2023 00:44
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 21, 2023
@morningman
Copy link
Contributor

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 6eea3d9 into apache:master Apr 21, 2023
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Apr 22, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 25, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants